Re: [RFC][stable 3.0.x] lib: Switch to pthread_mutexattr_setrobust

[Florian Bezdeka <florian.bezdeka@siemens.com>]

On Mon, 2022-11-21 at 18:49 +0100, Jan Kiszka wrote:
> On 21.11.22 10:51, Bezdeka, Florian (T CED SES-DE) wrote:
> > On Mon, 2022-11-21 at 10:16 +0100, Jan Kiszka wrote:
> > > On 18.11.22 16:42, Florian Bezdeka wrote:
> > > > With recent glibc (at least 2.34), autoconf fails to detect
> > > > pthread_mutexattr_setrobust_np. But that is long deprecated anyway. So
> > > > switch to pthread_mutexattr_setrobust and only fall back to _np when
> > > > needed.
> > > > 
> > > > This is a backport of the following commits from stable 3.2:
> > > > 
> > > > 746cbeb6ccc0 ("lib: Switch to pthread_mutexattr_setrobust")
> > > > 3f85c174e297 ("lib: Fix fallback signature of pthread_mutexattr_setrobust")
> > > > 2d947e6fe3f8 ("lib: Re-add "static" to pthread_mutexattr_setrobust fallback stub")
> > > > 
> > > > Backporting allows the stable 3.0 branch to be build with the latest
> > > > Debian toolchain, so we don't need a special CI setup for the 3.0
> > > > branch.
> > > > 
> > > > Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> > > > ---
> > > > 
> > > > Hi all,
> > > > 
> > > > would it be acceptable to apply this patch to the 3.0.x stable branch? 
> > > > It would allow us to build this branch with the same infrastructure once 
> > > > we like to update to the next Debian version (12).
> > > > 
> > > > Especially the y2038 tests require a recent glibc version the next 
> > > > Debian stable release (bookworm, Debian 12) will ship such a version.
> > > > 
> > > > One alternative would be to use different build environments for
> > > > different Xenomai stable branches. I fear that's hard to maintain -
> > > > especially the CI configuration will likely explode.
> > > > 
> > > > WDYT?
> > > > 
> > > > This patch has been tested with both build environments, so Debian 11
> > > > (as is now) and the upcoming Debian 12.
> > > > 
> > > 
> > > I don't mind backporting with this use case in mind, but why can't we
> > > cherry-pick and possibly massage the original commits?
> > 
> > Hi Jan,
> > 
> > I tried but the first one requires merging / does not apply directly to
> > the 3.0.x stable branch.
> > 
> > How to proceed? Should I resend without RFC tag?
> > 
> 
> I've merged these four into stable/3.0.x here:
> 
> fed3436a19 lib: Re-add "static" to pthread_mutexattr_setrobust fallback stub
> e4111b3c17 lib: Fix fallback signature of pthread_mutexattr_setrobust
> 87c719d48a lib: Switch to pthread_mutexattr_setrobust
> cafb1e21ef lib/boilerplate: Convert pthread_mutexattr_setrobust_np stub into inline function
> 
> Only the second one (from the bottom) required a simple conflict 
> resolution.

Works! Thanks a lot.

> 
> Jan
>