All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Hunt <johunt@akamai.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
	Florian Westphal <fw@strlen.de>
Cc: herbert@gondor.apana.org.au, David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>
Subject: Re: crash in __xfrm_state_lookup on 4.19 LTS
Date: Mon, 16 Dec 2019 12:34:30 -0800	[thread overview]
Message-ID: <70a8c07d-effc-012d-5513-656e172e882e@akamai.com> (raw)
In-Reply-To: <20191213111322.GE26283@gauss3.secunet.de>

On 12/13/19 3:13 AM, Steffen Klassert wrote:
> On Fri, Dec 13, 2019 at 11:25:12AM +0100, Florian Westphal wrote:
>> Steffen Klassert <steffen.klassert@secunet.com> wrote:
>>>
>>> We destroy the states with a workqueue by doing schedule_work().
>>> I think we should better use call_rcu to make sure that a
>>> rcu grace period has elapsed before the states are destroyed.
>>
>> xfrm_state_gc_task calls synchronize_rcu after stealing the gc list and
>> before destroying those states, so I don't think this is a problem.
> 
> That's true, I've missed this. In that case, I don't
> have an idea what is the root cause of these crashes.
> We need to find a way to reproduce it.
> 

Thanks. I will try reproducing. Please let me know if you have any 
suggestions on how I may be able to trigger this behavior.

Josh

      reply	other threads:[~2019-12-16 20:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 22:52 crash in __xfrm_state_lookup on 4.19 LTS Josh Hunt
2019-12-12 13:21 ` Steffen Klassert
2019-12-12 20:44   ` Josh Hunt
2019-12-13  7:21     ` Steffen Klassert
2019-12-13 10:25       ` Florian Westphal
2019-12-13 11:13         ` Steffen Klassert
2019-12-16 20:34           ` Josh Hunt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70a8c07d-effc-012d-5513-656e172e882e@akamai.com \
    --to=johunt@akamai.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.