From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bBs2L-0004F1-PJ
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 19:09:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bBs2I-0000WH-Hk
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 19:09:53 -0400
Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:36371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bBs2I-0000WD-At
	for qemu-devel@nongnu.org; Sat, 11 Jun 2016 19:09:50 -0400
Received: by mail-pf0-x22d.google.com with SMTP id t190so33992863pfb.3
	for <qemu-devel@nongnu.org>; Sat, 11 Jun 2016 16:09:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <CAFEAcA-1RZrdEC+f+WxM=uahtcbdEC+SZDyTkYSeObWPKVEP9w@mail.gmail.com>
	<CAFEAcA8nFKcG5vy3EoWJhjLYmzOLFS1nYY74Dtu3E51oWPnuEw@mail.gmail.com>
	<20160610163432.GA22231@flamenco>
	<CAFEAcA8ALC0i250JFBWn0G-ZwyaryrKTR6r=ixscngbrjT7M3w@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <70be5f34-9090-8996-328f-61cf69730cf0@twiddle.net>
Date: Sat, 11 Jun 2016 16:09:47 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8ALC0i250JFBWn0G-ZwyaryrKTR6r=ixscngbrjT7M3w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 00/15] tb hash improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Emilio G. Cota" <cota@braap.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 06/10/2016 09:41 AM, Peter Maydell wrote:
> On 10 June 2016 at 17:34, Emilio G. Cota <cota@braap.org> wrote:
>> On Fri, Jun 10, 2016 at 16:33:10 +0100, Peter Maydell wrote:
>>> Fails to build on ppc64be :-(
>>>
>>> In file included from /home/pm215/qemu/include/qemu/thread.h:4:0,
>>>                  from /home/pm215/qemu/include/block/aio.h:20,
>>>                  from /home/pm215/qemu/include/block/block.h:4,
>>>                  from /home/pm215/qemu/include/monitor/monitor.h:6,
>>>                  from /home/pm215/qemu/trace/control.c:23:
>>> /home/pm215/qemu/include/qemu/processor.h:24:35: error: expected
>>> identifier or ‘(’ before string constant
>>>                                    "or 2, 2, 2;" ::: "memory")
>>
>> On Fri, Jun 10, 2016 at 16:57:19 +0100, Peter Maydell wrote:
>>> Also fails trying to build a test on 32-bit:
>>>
>>> /home/petmay01/qemu/tests/qht-bench.c: In function 'pr_params':
>>> /home/petmay01/qemu/tests/qht-bench.c:270:5: error: format '%zu'
>>> expects argument of type 'size_t', but argument 2 has type 'long
>>> unsigned int' [-Werror=format=]
>>>      printf(" lookup range:      %zu\n", lookup_range);
>>
>> Can you please test again after applying the appended delta?
>
> I will test.
>
> For the PPC asm, is it not just wanting the "\n" between instructions?
> Shouldn't be necessary to use two separate asm() lines...

It has a ; between instructions.  That's not the problem.

What it needs is a \ to continue the macro to the second line.

I've just finished a build on ppc64 with that one character fix.


r~