From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/3] drm/i915: Hold a wakeref for probing the ring registers Date: Tue, 30 May 2017 13:37:23 +0100 Message-ID: <70d0b33c-f163-5498-dda4-d30efd242e8d@linux.intel.com> References: <20170530121334.17364-1-chris@chris-wilson.co.uk> <20170530121334.17364-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 157E789E26 for ; Tue, 30 May 2017 12:37:27 +0000 (UTC) In-Reply-To: <20170530121334.17364-2-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDMwLzA1LzIwMTcgMTM6MTMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBbGxvdyBpbnRlbF9l bmdpbmVfaXNfaWRsZSgpIHRvIGJlIGNhbGxlZCBvdXRzaWRlIG9mIHRoZSBHVCB3YWtlcmVmIGJ5 Cj4gYWNxdWlyaW5nIHRoZSBkZXZpY2UgcnVudGltZSBwbSBmb3Igb3Vyc2VsdmVzLiBUaGlzIGFs bG93cyB0aGUgZnVuY3Rpb24KPiB0byBhY3QgYXMgY2hlY2sgYWZ0ZXIgd2UgYXNzdW1lIHRoZSBl bmdpbmUgaXMgaWRsZSBhbmQgd2UgcmVsZWFzZSB0aGUgR1QKPiB3YWtlcmVmIGhlbGQgd2hpbHN0 IHdlIGhhdmUgcmVxdWVzdHMuCj4gCj4gWyAyNjEzLjQwMTY0N10gUlBNIHdha2Vsb2NrIHJlZiBu b3QgaGVsZCBkdXJpbmcgSFcgYWNjZXNzCj4gWyAyNjEzLjQwMTY4NF0gLS0tLS0tLS0tLS0tWyBj dXQgaGVyZSBdLS0tLS0tLS0tLS0tCj4gWyAyNjEzLjQwMTcyMF0gV0FSTklORzogQ1BVOiA1IFBJ RDogNzczOSBhdCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaDoxNzg3IGdlbjZfcmVh ZDMyKzB4MjFmLzB4MmIwIFtpOTE1XQo+IFsgMjYxMy40MDE3MzFdIE1vZHVsZXMgbGlua2VkIGlu OiBzbmRfaGRhX2ludGVsIGk5MTUgdmdlbSBzbmRfaGRhX2NvZGVjX2hkbWkgeDg2X3BrZ190ZW1w X3RoZXJtYWwgaW50ZWxfcG93ZXJjbGFtcCBzbmRfaGRhX2NvZGVjX3JlYWx0ZWsgY29yZXRlbXAg c25kX2hkYV9jb2RlY19nZW5lcmljIGNyY3QxMGRpZl9wY2xtdWwgY3JjMzJfcGNsbXVsIGdoYXNo X2NsbXVsbmlfaW50ZWwgc25kX2hkYV9jb2RlYyBzbmRfaHdkZXAgc25kX2hkYV9jb3JlIHNuZF9w Y20gcjgxNjkgbWlpIG1laV9tZSBscGNfaWNoIG1laSBwcmltZV9udW1iZXJzIFtsYXN0IHVubG9h ZGVkOiBpOTE1XQo+IFsgMjYxMy40MDE4MjNdIENQVTogNSBQSUQ6IDc3MzkgQ29tbTogZHJ2X21p c3NlZF9pcnEgVGFpbnRlZDogRyAgICAgVSAgICAgICAgICA0LjEyLjAtcmMyLUNJLUNJX0RSTV80 MjErICMxCj4gWyAyNjEzLjQwMTgyNV0gSGFyZHdhcmUgbmFtZTogTVNJIE1TLTc5MjQvWjk3TS1H NDMoTVMtNzkyNCksIEJJT1MgVjEuMTIgMDIvMTUvMjAxNgo+IFsgMjYxMy40MDE4NDBdIHRhc2s6 IGZmZmY4ODA0MDllM2E3NDAgdGFzay5zdGFjazogZmZmZmM5MDAwODRkYzAwMAo+IFsgMjYxMy40 MDE4NjFdIFJJUDogMDAxMDpnZW42X3JlYWQzMisweDIxZi8weDJiMCBbaTkxNV0KPiBbIDI2MTMu NDAxODYzXSBSU1A6IDAwMTg6ZmZmZmM5MDAwODRkZmNlOCBFRkxBR1M6IDAwMDEwMjkyCj4gWyAy NjEzLjQwMTg2OV0gUkFYOiAwMDAwMDAwMDAwMDAwMDJhIFJCWDogZmZmZjg4MDQwMTZhODAwMCBS Q1g6IDAwMDAwMDAwMDAwMDAwMDYKPiBbIDI2MTMuNDAxODcxXSBSRFg6IDAwMDAwMDAwMDAwMDAw MDYgUlNJOiBmZmZmZmZmZjgxY2JmMmQ5IFJESTogZmZmZmZmZmY4MWM5ZTNhNwo+IFsgMjYxMy40 MDE4NzRdIFJCUDogZmZmZmM5MDAwODRkZmQxOCBSMDg6IGZmZmY4ODA0MDllM2FmYzggUjA5OiAw MDAwMDAwMDAwMDAwMDAwCj4gWyAyNjEzLjQwMTg3N10gUjEwOiAwMDAwMDAwMDhhMWM0ODNmIFIx MTogMDAwMDAwMDAwMDAwMDAwMCBSMTI6IDAwMDAwMDAwMDAwMDIwOWMKPiBbIDI2MTMuNDAxODc5 XSBSMTM6IDAwMDAwMDAwMDAwMDAwMDEgUjE0OiBmZmZmODgwNDAxNmE4MDAwIFIxNTogZmZmZjg4 MDQwMTZhYzE1MAo+IFsgMjYxMy40MDE4ODJdIEZTOiAgMDAwMDdmMzllZjNkZDhjMCgwMDAwKSBH UzpmZmZmODgwNDFmYjQwMDAwKDAwMDApIGtubEdTOjAwMDAwMDAwMDAwMDAwMDAKPiBbIDI2MTMu NDAxODg1XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMz Cj4gWyAyNjEzLjQwMTg4N10gQ1IyOiAwMDAwMDAwMDAyMzcxN2M4IENSMzogMDAwMDAwMDJlN2Iz NDAwMCBDUjQ6IDAwMDAwMDAwMDAxNDA2ZTAKPiBbIDI2MTMuNDAxODg5XSBDYWxsIFRyYWNlOgo+ IFsgMjYxMy40MDE5MTJdICBpbnRlbF9lbmdpbmVfaXNfaWRsZSsweDc2LzB4OTAgW2k5MTVdCj4g WyAyNjEzLjQwMTkzMV0gIGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUrMHhlNi8weDFlMCBbaTkxNV0K PiBbIDI2MTMuNDAxOTUxXSAgZmF1bHRfaXJxX3NldCsweDQwLzB4OTAgW2k5MTVdCj4gWyAyNjEz LjQwMTk3MF0gIGk5MTVfcmluZ190ZXN0X2lycV9zZXQrMHg0Mi8weDUwIFtpOTE1XQo+IFsgMjYx My40MDE5NzZdICBzaW1wbGVfYXR0cl93cml0ZSsweGM3LzB4ZTAKPiBbIDI2MTMuNDAxOTgxXSAg ZnVsbF9wcm94eV93cml0ZSsweDRmLzB4NzAKPiBbIDI2MTMuNDAxOTg3XSAgX192ZnNfd3JpdGUr MHgyMy8weDEyMAo+IFsgMjYxMy40MDE5OTJdICA/IHJjdV9yZWFkX2xvY2tfc2NoZWRfaGVsZCsw eDc1LzB4ODAKPiBbIDI2MTMuNDAxOTk2XSAgPyByY3Vfc3luY19sb2NrZGVwX2Fzc2VydCsweDJh LzB4NTAKPiBbIDI2MTMuNDAxOTk5XSAgPyBfX3NiX3N0YXJ0X3dyaXRlKzB4ZmEvMHgxZjAKPiBb IDI2MTMuNDAyMDA0XSAgdmZzX3dyaXRlKzB4YzUvMHgxZDAKPiBbIDI2MTMuNDAyMDA4XSAgPyB0 cmFjZV9oYXJkaXJxc19vbl9jYWxsZXIrMHhlNy8weDFjMAo+IFsgMjYxMy40MDIwMTNdICBTeVNf d3JpdGUrMHg0NC8weGIwCj4gWyAyNjEzLjQwMjAyMF0gIGVudHJ5X1NZU0NBTExfNjRfZmFzdHBh dGgrMHgxYy8weGIxCj4gWyAyNjEzLjQwMjAyMl0gUklQOiAwMDMzOjB4N2YzOWVkZWQ2NjcwCj4g WyAyNjEzLjQwMjAyNV0gUlNQOiAwMDJiOjAwMDA3ZmZmZGNkY2IxYTggRUZMQUdTOiAwMDAwMDI0 NiBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDAwMQo+IFsgMjYxMy40MDIwMzBdIFJBWDogZmZmZmZm ZmZmZmZmZmZkYSBSQlg6IGZmZmZmZmZmODE0NzAyMDMgUkNYOiAwMDAwN2YzOWVkZWQ2NjcwCj4g WyAyNjEzLjQwMjAzM10gUkRYOiAwMDAwMDAwMDAwMDAwMDAxIFJTSTogMDAwMDAwMDAwMDQxYmMz MyBSREk6IDAwMDAwMDAwMDAwMDAwMDYKPiBbIDI2MTMuNDAyMDM2XSBSQlA6IGZmZmZjOTAwMDg0 ZGZmODggUjA4OiAwMDAwN2YzOWVmM2RkOGMwIFIwOTogMDAwMDAwMDAwMDAwMDAwMQo+IFsgMjYx My40MDIwMzhdIFIxMDogMDAwMDAwMDAwMDAwMDAwMCBSMTE6IDAwMDAwMDAwMDAwMDAyNDYgUjEy OiAwMDAwMDAwMDAwNDFiYzMzCj4gWyAyNjEzLjQwMjA0MV0gUjEzOiAwMDAwMDAwMDAwMDAwMDA2 IFIxNDogMDAwMDAwMDAwMDAwMDAwMCBSMTU6IDAwMDAwMDAwMDAwMDAwMDAKPiBbIDI2MTMuNDAy MDQ2XSAgPyBfX3RoaXNfY3B1X3ByZWVtcHRfY2hlY2srMHgxMy8weDIwCj4gWyAyNjEzLjQwMjA1 Ml0gQ29kZTogMDEgOWIgZmEgZTAgMGYgZmYgZTkgMjggZmUgZmYgZmYgODAgM2QgNmEgZGQgMGUg MDAgMDAgMGYgODUgMjkgZmUgZmYgZmYgNDggYzcgYzcgNDggMTkgMjkgYTAgYzYgMDUgNTYgZGQg MGUgMDAgMDEgZTggZGEgOWEgZmEgZTAgPDBmPiBmZiBlOSAwZiBmZSBmZiBmZiBiOSAwMSAwMCAw MCAwMCBiYSAwMSAwMCAwMCAwMCA0NCA4OSBlNiA0OAo+IFsgMjYxMy40MDIxOTldIC0tLVsgZW5k IHRyYWNlIDMxZjBjZmE5M2FiNjMyYmYgXS0tLQo+IAo+IEZpeGVzOiA1NDAwMzY3YTg2NGQgKCJk cm0vaTkxNTogRW5zdXJlIHRoZSBlbmdpbmUgaXMgaWRsZSBiZWZvcmUgbWFudWFsbHkgY2hhbmdp bmcgSFdTIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4g Q2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBD YzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgMTggKysrKysrKysrKysrKysr KystCj4gICAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggNDEzYmZkOGQ0 YmY0Li42OTlmMmQzODYxYzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVf Y3MuYwo+IEBAIC0xMjA1LDYgKzEyMDUsMjIgQEAgaW50IGludGVsX3Jpbmdfd29ya2Fyb3VuZHNf ZW1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSkKPiAgIAlyZXR1cm4gMDsKPiAg IH0KPiAgIAo+ICtzdGF0aWMgYm9vbCByaW5nX2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBl bmdpbmUtPmk5MTU7Cj4gKwlib29sIGlkbGUgPSB0cnVlOwo+ICsKPiArCWludGVsX3J1bnRpbWVf cG1fZ2V0KGRldl9wcml2KTsKCkkgZGlkbid0IGZpbmQgYSBwYXRoIHdoZXJlIHRoaXMgd291bGQg YmUgbmVlZGVkIG9uIHRvcCBvZiB0aGUgcHJldmlvdXMgCnBhdGNoLiBJIGFtIG5vdCBvYmplY3Rp bmcgdG8gbWFraW5nIGl0IG1vcmUgcm9idXN0LCBqdXN0IGNoZWNraW5nIGlmIEkgCmhhdmUgbWlz c2VkIHNvbWV0aGluZz8KCj4gKwo+ICsJLyogTm8gYml0IGZvciBnZW4yLCBzbyBhc3N1bWUgdGhl IENTIHBhcnNlciBpcyBpZGxlICovCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+IDIgJiYg IShJOTE1X1JFQURfTU9ERShlbmdpbmUpICYgTU9ERV9JRExFKSkKPiArCQlpZGxlID0gZmFsc2U7 CgpDb3VsZCBhc3NpZ24gYSBsb2dpYyBldmFsdWF0aW9uIHRvIGlkbGUgZGlyZWN0bHkgaGVyZSBi dXQgZG9lc24ndCBtYXR0ZXIuCgo+ICsKPiArCWludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2 KTsKPiArCj4gKwlyZXR1cm4gaWRsZTsKPiArfQo+ICsKPiAgIC8qKgo+ICAgICogaW50ZWxfZW5n aW5lX2lzX2lkbGUoKSAtIFJlcG9ydCBpZiB0aGUgZW5naW5lIGhhcyBmaW5pc2hlZCBwcm9jZXNz IGFsbCB3b3JrCj4gICAgKiBAZW5naW5lOiB0aGUgaW50ZWxfZW5naW5lX2NzCj4gQEAgLTEyMzcs NyArMTI1Myw3IEBAIGJvb2wgaW50ZWxfZW5naW5lX2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+ICAgCQlyZXR1cm4gZmFsc2U7Cj4gICAKPiAgIAkvKiBSaW5nIHN0b3Bw ZWQ/ICovCj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+IDIgJiYgIShJOTE1X1JFQURfTU9E RShlbmdpbmUpICYgTU9ERV9JRExFKSkKPiArCWlmICghcmluZ19pc19pZGxlKGVuZ2luZSkpCj4g ICAJCXJldHVybiBmYWxzZTsKPiAgIAo+ICAgCXJldHVybiB0cnVlOwo+IAoKUmVnYXJkcywKClR2 cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK