Re: [igt-dev] [PATCH i-g-t v2 4/4] tests/kms_psr: Add drmModeDirtyFB() calls to handle frontbuffer rendering tests

[Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>]

Looks good to me. but in kms_frontbuffer_tracking.c, there is a function 
with the same role called fb_dirty_ioctl(), so it seems good to use it 
as a common igt function in the future.
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>

On 8/19/21 1:24 AM, José Roberto de Souza wrote:
> Without this i915 don't know that frontbuffer was updated.
> This will be a problem when frontbuffer rendering is dropped from i915
> in modern platforms.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>   tests/kms_psr.c | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> index 8f2fbb8a3..f85626d21 100644
> --- a/tests/kms_psr.c
> +++ b/tests/kms_psr.c
> @@ -259,6 +259,20 @@ static bool drrs_disabled(data_t *data)
>   	return !strstr(buf, "DRRS Enabled : Yes\n");
>   }
>   
> +static void fb_dirty_fb_ioctl(data_t *data, struct igt_fb *fb)
> +{
> +	int ret;
> +	drmModeClip clip = {
> +		.x1 = 0,
> +		.x2 = fb->width,
> +		.y1 = 0,
> +		.y2 = fb->height
> +	};
> +
> +	ret = drmModeDirtyFB(data->drm_fd, fb->fb_id, &clip, 1);
> +	igt_assert(ret == 0 || ret == -ENOSYS);
> +}
> +
>   static void run_test(data_t *data)
>   {
>   	uint32_t handle = data->fb_white.gem_handle;
> @@ -299,6 +313,7 @@ static void run_test(data_t *data)
>   			       I915_GEM_DOMAIN_GTT, I915_GEM_DOMAIN_GTT);
>   		memset(ptr, 0xcc, data->mod_size);
>   		munmap(ptr, data->mod_size);
> +		fb_dirty_fb_ioctl(data, &data->fb_white);
>   		expected = "BLACK or TRANSPARENT mark on top of plane in test";
>   		break;
>   	case MMAP_CPU:
> @@ -309,14 +324,17 @@ static void run_test(data_t *data)
>   		memset(ptr, 0, data->mod_size);
>   		munmap(ptr, data->mod_size);
>   		gem_sw_finish(data->drm_fd, handle);
> +		fb_dirty_fb_ioctl(data, &data->fb_white);
>   		expected = "BLACK or TRANSPARENT mark on top of plane in test";
>   		break;
>   	case BLT:
>   		fill_blt(data, &data->fb_white, 0);
> +		fb_dirty_fb_ioctl(data, &data->fb_white);
>   		expected = "BLACK or TRANSPARENT mark on top of plane in test";
>   		break;
>   	case RENDER:
>   		fill_render(data, &data->fb_white, 0);
> +		fb_dirty_fb_ioctl(data, &data->fb_white);
>   		expected = "BLACK or TRANSPARENT mark on top of plane in test";
>   		break;
>   	case PLANE_MOVE:
>