From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level
Date: Tue, 10 Dec 2019 09:09:36 +0100 [thread overview]
Message-ID: <70dbdbd2-ce7a-bbe1-8c85-ff7bea4bc712@suse.com> (raw)
In-Reply-To: <e9672b4e-ef46-d52f-8044-4eb6069175ef@citrix.com>
On 09.12.2019 18:29, Andrew Cooper wrote:
> On 09/12/2019 16:19, Jan Beulich wrote:
>> On 05.12.2019 23:30, Andrew Cooper wrote:
>>> @@ -1080,6 +1068,9 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>>> if ( copyback && __copy_to_guest(u_domctl, op, 1) )
>>> ret = -EFAULT;
>>>
>>> + if ( ret == -ERESTART )
>>> + ret = hypercall_create_continuation(__HYPERVISOR_domctl,
>>> + "h", u_domctl);
>> You may want to mention in the description the bug you fix here:
>> Previously the -EFAULT returning visible in context should have
>> canceled any active continuation.
>
> That would be presuming I'd even spotted it...
>
> Having looked though the paths once again, I don't think there was a
> path which continued and had copyback set, so this is at most a latent
> bug.
Ah, good. I actually first meant to check, but then forgot before
sending the earlier reply.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-10 8:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 22:30 [Xen-devel] [PATCH 0/6] xen: Support continuations from tasklets Andrew Cooper
2019-12-05 22:30 ` [Xen-devel] [PATCH 1/6] xen/tasklet: Fix return value truncation on arm64 Andrew Cooper
2019-12-08 11:57 ` Julien Grall
2019-12-05 22:30 ` [Xen-devel] [PATCH 2/6] xen/tasklet: Switch data parameter from unsigned long to void * Andrew Cooper
2019-12-08 12:02 ` Julien Grall
2019-12-09 15:28 ` Jan Beulich
2019-12-05 22:30 ` [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level Andrew Cooper
2019-12-08 12:18 ` Julien Grall
2019-12-09 17:20 ` Andrew Cooper
2019-12-09 16:19 ` Jan Beulich
2019-12-09 17:29 ` Andrew Cooper
2019-12-10 8:09 ` Jan Beulich [this message]
2019-12-05 22:30 ` [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths Andrew Cooper
2019-12-08 12:57 ` Julien Grall
2019-12-09 17:37 ` Andrew Cooper
2019-12-11 12:01 ` Julien Grall
2019-12-09 16:25 ` Jan Beulich
2019-12-09 16:29 ` Jan Beulich
2019-12-09 17:43 ` Andrew Cooper
2019-12-10 8:27 ` Jan Beulich
2019-12-05 22:30 ` [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu() Andrew Cooper
2019-12-09 16:52 ` Jan Beulich
2019-12-09 17:49 ` Andrew Cooper
2019-12-10 8:55 ` Jan Beulich
2019-12-10 17:55 ` Andrew Cooper
2019-12-11 7:41 ` Jan Beulich
2019-12-11 9:00 ` Andrew Cooper
2019-12-05 22:30 ` [Xen-devel] [PATCH 6/6] x86/smt: Don't use -EBUSY for smt_up_down_helper() continuations Andrew Cooper
2019-12-10 10:29 ` Jan Beulich
2019-12-06 9:58 ` [Xen-devel] [PATCH 0/6] xen: Support continuations from tasklets Jan Beulich
2019-12-06 10:14 ` Andrew Cooper
2019-12-06 10:18 ` Jan Beulich
2019-12-06 10:22 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70dbdbd2-ce7a-bbe1-8c85-ff7bea4bc712@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.