From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28898C433EF for ; Sat, 18 Dec 2021 10:55:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A83782DB7; Sat, 18 Dec 2021 11:55:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="i4TTThWG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B83882F5A; Sat, 18 Dec 2021 11:55:49 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 54FD8811BB for ; Sat, 18 Dec 2021 11:55:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639824942; bh=/ZSw/q4X6+14gO1CFmUN8gu/GAH92nsRmClFmlMVuGw=; h=X-UI-Sender-Class:Date:Subject:To:References:Cc:From:In-Reply-To; b=i4TTThWGLtt1mhcoAJ0EYWQ+E9VgEDLPmRXpPn5lA1ezONaM6HtpgABYv7FRxAwn9 uvgU7FKtpMNyaDiqbJ3jw8IbAXgT7TagbLbzKS47d/TX55PnFFY2y3XXt+tzXOPXt0 N3Wq2+sao5WMz3LGPr02YkWbQTByUbtIwJiB2+Vg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MUosN-1n766B1wtl-00QkZv; Sat, 18 Dec 2021 11:55:42 +0100 Message-ID: <70e958c5-5e82-9266-0f59-2bdb68c80949@gmx.de> Date: Sat, 18 Dec 2021 11:55:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC v2 02/20] blk: add a helper function, blk_probe_or_unbind() Content-Language: en-US To: AKASHI Takahiro References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-3-takahiro.akashi@linaro.org> <20211214070103.GA49357@laputa> Cc: Simon Glass , agraf@csgraf.de, masami.hiramatsu@linaro.org, ilias.apalodimas@linaro.org, u-boot@lists.denx.de From: Heinrich Schuchardt In-Reply-To: <20211214070103.GA49357@laputa> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VJnobcKwsqXkOF9eOb/8el1oRuKrgsddlAKWEpZZzCQoCrPJFI+ flbptptuqWy6yMhPUnxmwq87bWCMMTA1//xsQIwBEReHnZUmUFwzVJNAhjot08pXp5MNRec ZXDB5TqbbgN3AL6tzrqs7/PQ52kynyqAJUEOHxebwV8bGWyndHDfdgmovUODb9wevTssvhr pGQzNidQ/ch+3VCEPUX2Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:QtqMN/aY0NM=:RPp9aDK9Au5CsvElRANf3V +SkMeRt0x8+mdG2WV6x9V0h8INDP+TNT78lZVw1FHntCVx6Wnjki3SWu9V+npLFruNxvHLgGm A3ytvBKEnKPgNiaBYKNBjkmo8GSTceSMHz/dGg4VHdXoR1Yh5NmwAyihGOxwnjWdEUqaaY5Re uH1WWIR4pNJz0XFv4Fkt3TccDdLlQ1Hp2O7hmQ0YF1FtP2je3clnJGIFPRVmSFSisUaZUOmLs RL3nvVVldc8JDSpRG8A3V75LXyovN68cIhgNIb/V9XJEdnLloFa+Y9nX2+XypJks/YEjPlWPi Uhak380cE+usWjSVC7E+o7TK4hk98QGpwX7ALsKgbHzQxWlLIsVIJuvS/YpVvyrhmi1G3HcMu mi3ZjWubFdNlLGRLXrUmQ8v4P7U+yNfwe4wc0dIZLRIOB+MSngmvnJSIaSzF+pHscgSaQMqey B6mZ5XhbLhU28PEvedeUphuF/XFkEyqQ0UbSe4P5nwUvLGRfgdRYdtsMyWfV8MyVsAUCo12r9 HWOEdD+F76bOITClqr3pIdLoGkcrr9dBqrmoIFS49JMkwCFfqs84YA4FZ1IjFbi84vsFw60hw yu2DOmfYGaBZtk/6VTlAt5hP16KFdCsg1+F55NHEDaB1SxLZlY4wkA/zNzvmRebYZlujSI9BZ pHIN7t1LOAPhaio2B+frc+58e/5RO4BGNxHkxFXOJvl0eD4rE4EdDgR1TVX+UTROFMNeD8h8v 2XPHOTJlAUvJ5LpQRSwlJTEZgrn3Xzc2jyI1vpnJ17e67PTFNjU+KpM0CopLa4eTJmuDywnbm BefiPX+CPG1G2WYN8HCKjZqGy16X5XSOu+tuz2zJWrR0Wb4ShoCRWVLRxZ8BpFO+P4Aqop7PZ mB/vvYCUmbOK7B6xb71x7Zdr5VTfVPnVBS+s19/3+yGj3ejjQIEd8YqdHPMsIWQkfcd3cZI/p 8USRvQKI+TGyprjfHOPJ6C0xmZzgEeIE5T7UuhfQialHDyNEQR/NElkUTi/D6gsa0V6gyozXq FUr9vS78k90b6DCXeWv94DvDW7OIf73QtxfSrLbocKNT9A9YMl2VI3+uLH2dCHucdbZUv18v3 1jyFoo9p8KAtpM= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/14/21 08:01, AKASHI Takahiro wrote: > Hi Simon, > > Thank you for your review on this series. > > On Mon, Dec 13, 2021 at 05:51:40AM -0700, Simon Glass wrote: >> Hi Takahiro, >> >> On Thu, 9 Dec 2021 at 23:59, AKASHI Takahiro wrote: >>> >>> This function will be commonly used in block device drivers >>> in the succeeding patches. >>> >>> Signed-off-by: AKASHI Takahiro >>> --- >>> drivers/block/blk-uclass.c | 13 +++++++++++++ >>> include/blk.h | 12 ++++++++++++ >>> 2 files changed, 25 insertions(+) >> >> Reviewed-by: Simon Glass >> >> But please add a test for this. > > Well, how can we test this simple function? > I can't simply imagine what the meaningful test scenario is. > >>> >>> diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c >>> index 83682dcc181a..f7ad90e8890f 100644 >>> --- a/drivers/block/blk-uclass.c >>> +++ b/drivers/block/blk-uclass.c >>> @@ -670,6 +670,19 @@ int blk_create_devicef(struct udevice *parent, co= nst char *drv_name, >>> return 0; >>> } >>> >>> +int blk_probe_or_unbind(struct udevice *dev) >>> +{ >>> + int ret; >>> + >>> + ret =3D device_probe(dev); >>> + if (ret) { >>> + debug("probing %s failed\n", dev->name); %s/debug(/log_debug(/ >>> + device_unbind(dev); >>> + } >>> + >>> + return ret; >>> +} >>> + >>> int blk_unbind_all(int if_type) >>> { >>> struct uclass *uc; >>> diff --git a/include/blk.h b/include/blk.h >>> index f0cc7ca1a28c..ef79e7b27b0a 100644 >>> --- a/include/blk.h >>> +++ b/include/blk.h >>> @@ -369,6 +369,18 @@ int blk_create_devicef(struct udevice *parent, co= nst char *drv_name, >>> const char *name, int if_type, int devnum, int= blksz, >>> lbaint_t lba, struct udevice **devp); >>> >>> +/** >>> + * blk_probe_or_unbind() - Try to probe >>> + * >>> + * Try to probe the device, primarily for enumelating partitions. >> >> enumerating > > Ah, OK. > > -Takahiro Akashi > >> >> >>> + * If it fails, the device itself is unbound since it means that it w= on't >>> + * work any more. >>> + * >>> + * @dev: The device to probe >>> + * @return 0 if OK, -ve on error %s/@return/Return:/ Please, stick to Spinx style comments as documented in https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-= documentation Otherwise 'make htmldocs' will fail. I will fix the remaining issues when merging. Best regards Heinrich >>> + */ >>> +int blk_probe_or_unbind(struct udevice *dev); >>> + >>> /** >>> * blk_unbind_all() - Unbind all device of the given interface type >>> * >>> -- >>> 2.33.0 >>>