All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] classes: decode output data to text
Date: Mon, 16 Jan 2023 10:58:54 +0000	[thread overview]
Message-ID: <70f5061236a1283cd18a89ce28938cb21df2072c.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj_aHCPmBH=Kzr6kvzdnPiDMxauC_q72Zv58zbPwWNrcbQ@mail.gmail.com>

On Fri, 2023-01-06 at 14:32 +0100, Alexander Kanavin wrote:
> Now I see what's going on. The fs-uuid class contains two functions:
> get_rootfs_uuid, and replace_rootfs_uuid. The former is not used
> anywhere, but the latter is. Can you introduce get_rootfs_uuid() into
> something in oe-core, perhaps it could enhance existing code somewhere
> (maybe complement replace_rootfs_uuid usage?), or a test could be made
> better?
> 
> Otherwise, it's still not tested, and will regress without notice.

I still didn't quite understand this explanation since 
replace_rootfs_uuid() calls get_rootfs_uuid().

The issue is that UUID_PLACEHOLDER isn't used anywhere in core:

UUID_PLACEHOLDER = '<<uuid-of-rootfs>>'

which means that get_rootfs_uuid() is never called.

There are some hints about how this should be used here:

https://git.yoctoproject.org/poky/commit/meta/?id=6d7bcd4df5722f3ccebbbf73361838cb0a5dc0ee

The fix is therefore probably ok but a test of UUID_PLACEHOLDER is
missing.

Looking at the class code, these two functions should be moved to
lib/oe/ as well, we don't need a bbclass for this.

Cheers,

Richard




  reply	other threads:[~2023-01-16 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 10:38 [PATCH] classes: decode output data to text Pawel Zalewski
2023-01-06 12:06 ` [OE-core] " Richard Purdie
2023-01-06 12:40   ` Pawel Zalewski
2023-01-06 12:43     ` Alexander Kanavin
2023-01-06 13:10       ` Pawel Zalewski
2023-01-06 13:32         ` Alexander Kanavin
2023-01-16 10:58           ` Richard Purdie [this message]
2023-01-16 11:01 ` Richard Purdie
2023-01-16 11:14   ` Pawel Zalewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70f5061236a1283cd18a89ce28938cb21df2072c.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pzalewski@thegoodpenguin.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.