From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4682FC433DB for ; Tue, 5 Jan 2021 08:40:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E5522525 for ; Tue, 5 Jan 2021 08:40:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4E5522525 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.61766.108776 (Exim 4.92) (envelope-from ) id 1kwhtM-0005tY-ES; Tue, 05 Jan 2021 08:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 61766.108776; Tue, 05 Jan 2021 08:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwhtM-0005tR-As; Tue, 05 Jan 2021 08:40:36 +0000 Received: by outflank-mailman (input) for mailman id 61766; Tue, 05 Jan 2021 08:40:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwhtK-0005tM-Tm for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 08:40:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c1116efc-03ce-43d3-92cc-06bb98261c87; Tue, 05 Jan 2021 08:40:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CCC82AA35; Tue, 5 Jan 2021 08:40:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1116efc-03ce-43d3-92cc-06bb98261c87 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1609836032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5HvMHz5XbVTM6BKr0BZUSclCy7DwTB4CCgkXeFufdqI=; b=gOWNyCdwpAy1CtrX+2yBEw5ZZSJXPda9NEOXlg5wq+4x9Q7zlmDAvJeg7I00K7MdDHmTBR M5+qCyA97wgv+UtzNMS11/Jd170Vb+R577xkNoAgfhdKZrDP8BPfIFh3/viroxagHYPPVc r3QI8sUS5Xs9D/gr/S6Y5r5AiGt+84A= Subject: Re: [PATCH 1/2] x86/mem_sharing: copy cpuid during vm forking To: Tamas K Lengyel Cc: Tamas K Lengyel , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <6d5ca8a57a2745e933f00706bff306844611f64d.1609781242.git.tamas.lengyel@intel.com> From: Jan Beulich Message-ID: <7106d2d6-507e-b94a-fb60-0d80e991b8af@suse.com> Date: Tue, 5 Jan 2021 09:40:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <6d5ca8a57a2745e933f00706bff306844611f64d.1609781242.git.tamas.lengyel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04.01.2021 18:41, Tamas K Lengyel wrote: > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -1764,6 +1764,7 @@ static int fork(struct domain *cd, struct domain *d) > > domain_pause(d); > cd->max_pages = d->max_pages; > + memcpy(cd->arch.cpuid, d->arch.cpuid, sizeof(*d->arch.cpuid)); Can such copying please be done using assignment rather than memcpy(), for the added type safety? (I wouldn't mind doing this while committing, so long as you don't mind.) Jan