From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/cmdline: Fix buggy strncmp(s, LITERAL,
 ss - s) construct
Date: Wed, 2 Jan 2019 12:28:28 +0000
Message-ID: <7108f31f-07bc-0179-d1cd-531c201cdcfc@citrix.com>
References: <1546277721-20234-1-git-send-email-andrew.cooper3@citrix.com>
 <20190102101345.oqezg5mamqjikpb3@mac>
 <513e77bf-619d-a05c-86c7-70d87e6cba35@citrix.com>
 <20190102122541.u5cssvuub3oaxfmg@mac>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
In-Reply-To: <20190102122541.u5cssvuub3oaxfmg@mac>
Content-Language: en-GB
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

T24gMDIvMDEvMjAxOSAxMjoyNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToKPiBPbiBXZWQsIEph
biAwMiwgMjAxOSBhdCAxMjoxODoyN1BNICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOgo+PiBP
biAwMi8wMS8yMDE5IDEwOjEzLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOgo+Pj4gT24gTW9uLCBE
ZWMgMzEsIDIwMTggYXQgMDU6MzU6MjFQTSArMDAwMCwgQW5kcmV3IENvb3BlciB3cm90ZToKPj4+
PiBXaGVuIHRoZSBjb21tYW5kIGxpbmUgcGFyc2luZyB3YXMgdXBkYXRlZCB0byB1c2UgY29uc3Qg
c3RyaW5ncyBhbmQgbm8gbG9uZ2VyCj4+Pj4gdG9rZW5pc2Ugd2l0aCBOVUwgY2hhcmFjdGVycywg
c3RyaW5nIG1hdGNoZXMgY291bGQgbm8gbG9uZ2VyIGJlIG1hZGUgd2l0aAo+Pj4+IHN0cmNtcCgp
Lgo+Pj4+Cj4+Pj4gVW5mb3J0dW5hdGVseSwgdGhlIHJlcGxhY2VtZW50IHdhcyBidWdneS4gIHN0
cm5jbXAocywgIm9wdCIsIHNzIC0gcykgbWF0Y2hlcwo+Pj4+ICJvIiwgIm9wIiBhbmQgIm9wdCIg
b24gdGhlIGNvbW1hbmQgbGluZSwgYXMgc3MgLSBzIG1heSBiZSBzaG9ydGVyIHRoYW4gdGhlCj4+
Pj4gcGFzc2VkIGxpdGVyYWwuICBGdXJ0aGVybW9yZSwgcGFyc2VfYm9vbCgpIGlzIGFmZmVjdGVk
IGJ5IHRoaXMsIHNvIHN1YnN0cmluZ3MKPj4+PiBzdWNoIGFzICJkIiwgImUiIGFuZCAibyIgYXJl
IGNvbnNpZGVyZWQgdmFsaWQsIHdpdGggdGhlIGxhdHRlciBiZWluZyBhbWJpZ3VvdXMKPj4+PiBi
ZXR3ZWVuICJvbiIgYW5kICJvZmYiLgo+Pj4+Cj4+Pj4gSW50cm9kdWNlIGEgbmV3IHN0cmNtcC1s
aWtlIGZ1bmN0aW9uIGZvciB0aGUgdGFzaywgd2hpY2ggbG9va3MgZm9yIGV4YWN0Cj4+Pj4gc3Ry
aW5nIG1hdGNoZXMsIGJ1dCBkZWNsYXJlcyBzdWNjZXNzIHdoZW4gdGhlIE5VTCBvZiB0aGUgbGl0
ZXJhbCBtYXRjaGVzIGEKPj4+PiBjb21tYSBvciBjb2xvbiBpbiB0aGUgY29tbWFuZCBsaW5lIGZy
YWdtZW50Lgo+Pj4+Cj4+Pj4gTm8gY2hhbmdlIHRvIHRoZSBpbnRlbmRlZCBwYXJzaW5nIGZ1bmN0
aW9uYWxpdHksIGJ1dCBmaXhlcyBjYXNlcyB3aGVyZSBhCj4+Pj4gcGFydGlhbCBzdHJpbmcgb24g
dGhlIGNvbW1hbmQgbGluZSB3aWxsIGluYWR2ZXJ0ZW50bHkgdHJpZ2dlciBvcHRpb25zLgo+Pj4+
Cj4+Pj4gQSBmZXcgYXJlYXMgd2VyZSBtb3JlIHRoYW4ganVzdCBhIHRyaXZpYWwgY2hhbmdlOgo+
Pj4+Cj4+Pj4gICogZmR0X2FkZF91ZWZpX25vZGVzKCksIHdoaWxlIG5vdCBjb21tYW5kIGxpbmUg
cGFyc2luZywgaGFkIHRoZSBzYW1lIGJyb2tlbgo+Pj4+ICAgIHN0cm5jbXAoKSBwYXR0ZXJuLiAg
QXMgYSBmaXgsIHBlcmZvcm0gYW4gZXhwbGljaXQgbGVuZ3RoIGNoZWNrIGZpcnN0Lgo+Pj4+ICAq
IHBhcnNlX2lycV92ZWN0b3JfbWFwX3BhcmFtKCkgZ2FpbmVkIHNvbWUgc3R5bGUgY29ycmVjdGlv
bnMuCj4+Pj4gICogcGFyc2VfdnBtdV9wYXJhbXMoKSB3YXMgcmV3cml0dGVuIHRvIHVzZSB0aGUg
bm9ybWFsIGxpc3Qtb2Ytb3B0aW9ucyBmb3JtLAo+Pj4+ICAgIHJhdGhlciB0aGFuIGp1c3QgZml4
aW5nIHVwIHBhcnNlX3ZwbXVfcGFyYW0oKSBhbmQgbGVhdmluZyB0aGUgcGFyc2luZyBiZWluZwo+
Pj4+ICAgIGhhcmQgdG8gZm9sbG93Lgo+Pj4+ICAqIEluc3RlYWQgb2YgbWFraW5nIHRoZSB0cml2
aWFsIGZpeCBvZiBhZGRpbmcgYW4gZXhwbGljaXQgbGVuZ3RoIGNoZWNrIGluCj4+Pj4gICAgcGFy
c2VfYm9vbCgpLCB1c2UgdGhlIGxlbmd0aCB0byBzZWxlY3Qgd2hpY2ggdG9rZW4gdG8gd2Ugc2Vh
cmNoIGZvciwgd2hpY2gKPj4+PiAgICBpcyBtb3JlIGVmZmljaWVudCB0aGFuIHRoZSBwcmV2aW91
cyBsaW5lYXIgc2VhcmNoIG92ZXIgYWxsIHBvc3NpYmxlIHRva2Vucy4KPj4+Pgo+Pj4+IFNpZ25l
ZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4+Pj4g
LS0tCj4+Pj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPj4+PiBDQzogV2Vp
IExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT4KPj4+PiBDQzogUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+Cj4+Pj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxp
bmlAa2VybmVsLm9yZz4KPj4+PiBDQzogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNv
bT4KPj4+Pgo+Pj4+IFNwbGl0IG91dCBvZiB0aGUgZG9tMCBmaXggc2VyaWVzLiAgVGhpcyBuZWVk
cyBiYWNrcG9ydGluZyB0byA0LjkgYW5kIGxhdGVyLAo+Pj4+IGFuZCB0byB0aGUgc2VjdXJpdHkg
dHJlZXMsIGFzIHRoaXMgYnVnIGhhcyBiZWVuIGJhY2twb3J0ZWQgaW4gc2VjdXJpdHkgZml4ZXMu
Cj4+Pj4KPj4+PiBUaGlzIHBhdGNoIGlzIG1vcmUgZWFzaWx5IHJldmlld2VkIHdpdGggYGdpdCBk
aWZmIC0tY29sb3Itd29yZHNgIHdoaWNoCj4+Pj4gaGlnaGxpZ2h0cyB0aGF0IGl0IGlzIGEgc3Ry
YWlnaHQgZnVuY3Rpb24gdHJhbnNmb3JtYXRpb24gaW4gbW9zdCBjYXNlcy4KPj4+Pgo+Pj4+IFRo
ZSBwc3I9IG9wdGlvbiBpcyBhIGNvbXBsZXRlIHBhaW4sIGFuZCB1bmxpa2UgYWxsIHNpbWlsYXIg
b3B0aW9ucyBpbiBYZW4uCj4+Pj4gSSd2ZSBoYWxmIGEgbWluZCB0byByZXdyaXRlIGl0IGZyb20g
c2NyYXRjaCwgc2VlaW5nIGFzIHRoZSBvcHRpb24gaXNuJ3QKPj4+PiBlbmFibGVkIGJ5IGRlZmF1
bHQuCj4+Pj4gLS0tCj4+Pj4gK2ludCBjbWRsaW5lX3N0cmNtcChjb25zdCBjaGFyICpmcmFnLCBj
b25zdCBjaGFyICpuYW1lKQo+Pj4+ICt7Cj4+Pj4gKyAgICB3aGlsZSAoIDEgKQo+Pj4+ICsgICAg
ewo+Pj4+ICsgICAgICAgIGludCByZXMgPSAoKmZyYWcgLSAqbmFtZSk7Cj4+Pj4gKwo+Pj4+ICsg
ICAgICAgIGlmICggcmVzIHx8ICpuYW1lID09ICdcMCcgKQo+Pj4+ICsgICAgICAgIHsKPj4+PiAr
ICAgICAgICAgICAgLyoKPj4+PiArICAgICAgICAgICAgICogTlVMIGluICduYW1lJyBtYXRjaGlu
ZyBhIGNvbW1hIG9yIGNvbG9uIGluICdmcmFnJyBpbXBsaWVzCj4+Pj4gKyAgICAgICAgICAgICAq
IHN1Y2Nlc3MuCj4+Pj4gKyAgICAgICAgICAgICAqLwo+Pj4+ICsgICAgICAgICAgICBpZiAoICpu
YW1lID09ICdcMCcgJiYgKCpmcmFnID09ICcsJyB8fCAqZnJhZyA9PSAnOicpICkKPj4+PiArICAg
ICAgICAgICAgICAgIHJlcyA9IDA7Cj4+Pj4gKwo+Pj4+ICsgICAgICAgICAgICByZXR1cm4gcmVz
Owo+Pj4+ICsgICAgICAgIH0KPj4+PiArCj4+Pj4gKyAgICAgICAgZnJhZysrOwo+Pj4+ICsgICAg
ICAgIG5hbWUrKzsKPj4+PiArICAgIH0KPj4+PiArfQo+Pj4gVGhlIHByZXZpb3VzIGZ1bmN0aW9u
IHdvdWxkIGdldCB0aGUgbWF4IGxlbmd0aCBvZiB0aGUgZnJhZyBhcmd1bWVudCwKPj4+IHdoaWNo
IEkgdGhpbmsgd2FzIHVzZWZ1bC4gSWYgdGhlIGxlbmd0aCBvZiBuYW1lID4gZnJhZyB5b3UgY291
bGQgZW5kCj4+PiB1cCBhY2Nlc3NpbmcgYW4gdW5tYXBwZWQgYWRkcmVzcyBBRkFJQ1QuIE9yIGF0
IGxlYXN0ICpmcmFnID09ICdcMCcKPj4+IHNob3VsZCBhbHNvIGJlIHRha2VuIGludG8gYWNjb3Vu
dCBpZiBpdCdzIGd1YXJhbnRlZWQgdGhhdCBmcmFnIG11c3QKPj4+IGFsd2F5cyBoYXZlIGFuIGVu
ZGluZyBOVUwuCj4+IEl0IGlzIGNvbXBsZXRlbHkgdW5yZWFzb25hYmxlIHRvIHBhc3MgYSBub24t
dGVybWluYXRlZCBzdHJpbmcgaW50bwo+PiBzdHJpbmcgcGFyc2luZyBmdW5jdGlvbnMsIGFuZCBh
IGxvdCBvZiB0aGUgcGFyc2luZyBjb2RlIHdpbGwgZXhwbG9kZSBpZgo+PiB0aGlzIGV4cGVjdGF0
aW9uIGlzIHZpb2xhdGVkLgo+Pgo+PiBSZW1lbWJlciB0aGF0IGJlZm9yZSB0aGUgY29uc3QgcGFy
c2luZyB3YXMgaW50cm9kdWNlZCAoNC45IGlpcmMpLCBhbGwKPj4gcGFyc2luZyB3ZW50IHdpdGhv
dXQgYSBtYXggbGVuZ3RoLCBhbmQgcmVzb2x2aW5nIHRoYXQgaXMgcGFydCBvZiB0aGUgYnVnZml4
Lgo+IEJ1dCBzaG91bGRuJ3QgeW91IGNoZWNrIGZvciAqZnJhZyA9PSBOVUwgaW4gb3JkZXIgdG8g
YXZvaWQgb3ZlcnJ1bnM/CgpUaGF0IGNoZWNrIGlzIHByZXNlbnQsIGJ1dCBJJ2xsIGFkbWl0IHRo
YXQgaXQgaXMgYSBzdWJ0bGV0eSBvZiBob3cKc3RyY21wKCkgd29ya3MuwqAgQSBOVUwgaW4gZnJh
ZyBtYXRjaGluZyBhbnl0aGluZyBvdGhlciB0aGFuIGEgTlVMIGluCm5hbWUgd2lsbCBjYXVzZSBy
ZXMgdG8gYmUgbm9uemVybyBhbmQgZXhpdCB2aWEgdGhhdCBwYXRoLsKgIFRoaXMKcGFydGljdWxh
ciBhcnJhbmdlbWVudCBvZiB0aGUgZnVuY3Rpb24gZGVsaWJlcmF0ZWx5IGRvZXNuJ3QgaW5jcmVt
ZW50CnRoZSBmcmFnIHBvaW50ZXIgdW50aWwgbGF0ZXIgaW4gdGhlIGxvb3AuCgp+QW5kcmV3Cgpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg
bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3Rz
LnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs