All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: David Laight <David.Laight@ACULAB.COM>,
	"davem@davemloft.net" <davem@davemloft.net>
Cc: "dsahern@gmail.com" <dsahern@gmail.com>,
	"jiri@mellanox.com" <jiri@mellanox.com>,
	"allison@lohutok.net" <allison@lohutok.net>,
	"mmanning@vyatta.att-mail.com" <mmanning@vyatta.att-mail.com>,
	"petrm@mellanox.com" <petrm@mellanox.com>,
	"dcaratti@redhat.com" <dcaratti@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU
Date: Tue, 22 Oct 2019 09:28:40 +0800	[thread overview]
Message-ID: <710cc020-f411-38ad-a9c4-3f44957645f5@huawei.com> (raw)
In-Reply-To: <8f07f4aad98e44358b92e1e340df131f@AcuMS.aculab.com>

On 2019/10/21 22:46, David Laight wrote:
> From: Yunsheng Lin
>> Sent: 21 October 2019 13:26
>> Currently the MTU of vlan netdevice is set to the same MTU
>> of the lower device, which requires the underlying device
>> to handle it as the comment has indicated:
>>
>> 	/* need 4 bytes for extra VLAN header info,
>> 	 * hope the underlying device can handle it.
>> 	 */
>> 	new_dev->mtu = real_dev->mtu;
>>
>> Currently most of the physical netdevs seems to handle above
>> by reversing 2 * VLAN_HLEN for L2 packet len.
> 
> s/reverse/reserve/g

Thanks.

> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 
> 
> .
> 


  reply	other threads:[~2019-10-22  1:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 12:26 [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU Yunsheng Lin
2019-10-21 14:46 ` David Laight
2019-10-22  1:28   ` Yunsheng Lin [this message]
2019-10-21 23:27 ` Stephen Hemminger
2019-10-22  1:31   ` Yunsheng Lin
2019-10-22  2:47     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=710cc020-f411-38ad-a9c4-3f44957645f5@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=allison@lohutok.net \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmanning@vyatta.att-mail.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.