From mboxrd@z Thu Jan 1 00:00:00 1970 From: Franklin S Cooper Jr Date: Wed, 8 Mar 2017 15:30:52 -0600 Subject: [U-Boot] [PATCH 02/31] spl: fit: Break out some functions into a common file In-Reply-To: References: <20170302190435.23212-1-fcooper@ti.com> <20170302190435.23212-3-fcooper@ti.com> Message-ID: <711763a2-a020-f420-a84e-ea45cca34560@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de +Andre On 03/08/2017 03:01 PM, Simon Glass wrote: > Hi Franklin, > > On 2 March 2017 at 12:04, Franklin S Cooper Jr wrote: >> Some of the functions within spl_fit will be used for non spl purposes. >> Instead of duplicating functions simply break the functions to be reused >> into its own file. >> >> Signed-off-by: Franklin S Cooper Jr >> Reviewed-by: Tom Rini >> --- >> common/Makefile | 1 + >> common/common_fit.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> common/spl/spl_fit.c | 76 +--------------------------------------------- >> include/image.h | 8 +++++ >> 4 files changed, 96 insertions(+), 75 deletions(-) >> create mode 100644 common/common_fit.c > > This seems to conflict with Andre's series. What is the plan here? I'll have to look at it closely again but from what I remember Andre's series was adding additional functionality to functions within spl_fit while I only care about making those same functions accessible beyond SPL. So it depends on whose code is merged first but I don't think it is a big problem to manage. > > - Simon >