From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932347AbdJJPTo convert rfc822-to-8bit (ORCPT ); Tue, 10 Oct 2017 11:19:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932271AbdJJPTm (ORCPT ); Tue, 10 Oct 2017 11:19:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63996800AF Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1507383097082-123648613-2-diffsplit-thomas@m3y3r.de> References: <1507383097082-123648613-2-diffsplit-thomas@m3y3r.de> <1507383097081-778026979-0-diffsplit-thomas@m3y3r.de> To: Thomas Meyer Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Fix bool initialization/comparison MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7118.1507648780.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Tue, 10 Oct 2017 16:19:40 +0100 Message-ID: <7119.1507648780@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 10 Oct 2017 15:19:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer Please rebase on top of: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-2-experimental Some of the code you're changing has been deleted. David