From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA8AC352A3 for ; Thu, 13 Feb 2020 03:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59F1920724 for ; Thu, 13 Feb 2020 03:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f56hXAbV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729515AbgBMDbx (ORCPT ); Wed, 12 Feb 2020 22:31:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:20223 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729432AbgBMDbx (ORCPT ); Wed, 12 Feb 2020 22:31:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581564712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x48Xkc/52KhxaaQHOFtPu2ZMXbY1JrtqvmLAgLZ6e18=; b=f56hXAbVG0xt+fOpk8wdrJnSIHfHglYwz11krUjAqqOalFatHln3FhDWd0dStisvRcn99C nM53whYrb5kWx6hCjGZhf/Nn4MmH+8alrdLFqrXaDGUvNBDI/TnHOdfv3QAlULv2Rw7/GW MGvUT5EX1bDsPQPlk+bMeKe945jFCuw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-qgUXa6ttM3qy-xfPilOMbw-1; Wed, 12 Feb 2020 22:31:45 -0500 X-MC-Unique: qgUXa6ttM3qy-xfPilOMbw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6555D1005502; Thu, 13 Feb 2020 03:31:44 +0000 (UTC) Received: from [10.72.13.212] (ovpn-13-212.pek2.redhat.com [10.72.13.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3CA35C1B2; Thu, 13 Feb 2020 03:31:39 +0000 (UTC) Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso To: Anton Ivanov , "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> From: Jason Wang Message-ID: <71193f51-9606-58ba-39d7-904bc9fbd29a@redhat.com> Date: Thu, 13 Feb 2020 11:31:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/2/13 =E4=B8=8A=E5=8D=881:38, Anton Ivanov wrote: > > > On 11/02/2020 10:37, Michael S. Tsirkin wrote: >> On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: >>> On 11/02/2020 02:51, Jason Wang wrote: >>>> >>>> On 2020/2/11 =E4=B8=8A=E5=8D=8812:55, Anton Ivanov wrote: >>>>> >>>>> >>>>> On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: >>>>>> From: Anton Ivanov >>>>>> >>>>>> Some of the frames marked as GSO which arrive at >>>>>> virtio_net_hdr_from_skb() have no GSO_TYPE, no >>>>>> fragments (data_len =3D 0) and length significantly shorter >>>>>> than the MTU (752 in my experiments). >>>>>> >>>>>> This is observed on raw sockets reading off vEth interfaces >>>>>> in all 4.x and 5.x kernels I tested. >>>>>> >>>>>> These frames are reported as invalid while they are in fact >>>>>> gso-less frames. >>>>>> >>>>>> This patch marks the vnet header as no-GSO for them instead >>>>>> of reporting it as invalid. >>>>>> >>>>>> Signed-off-by: Anton Ivanov >>>>>> --- >>>>>> =C2=A0=C2=A0 include/linux/virtio_net.h | 8 ++++++-- >>>>>> =C2=A0=C2=A0 1 file changed, 6 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net= .h >>>>>> index 0d1fe9297ac6..d90d5cff1b9a 100644 >>>>>> --- a/include/linux/virtio_net.h >>>>>> +++ b/include/linux/virtio_net.h >>>>>> @@ -112,8 +112,12 @@ static inline int >>>>>> virtio_net_hdr_from_skb(const struct sk_buff *skb, >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_TCPV4; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else = if (sinfo->gso_type & SKB_GSO_TCPV6) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_TCPV6; >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= return -EINVAL; >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else { >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= if (skb->data_len =3D=3D 0) >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 hdr->gso_type =3D VIRTIO_NET_HDR_GSO_NONE; >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= else >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 return -EINVAL; >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (s= info->gso_type & SKB_GSO_TCP_ECN) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 hdr->gso_type |=3D VIRTIO_NET_HDR_GSO_ECN; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else >>>>>> >>>>> >>>>> ping. >>>>> >>>> >>>> Do you mean gso_size is set but gso_type is not? Looks like a bug >>>> elsewhere. >>>> >>>> Thanks >>>> >>>> >>> Yes. >>> >>> I could not trace it where it is coming from. >>> >>> I see it when doing recvmmsg on raw sockets in the UML vector network >>> drivers. >>> >> >> I think we need to find the culprit and fix it there, lots of other=20 >> things >> can break otherwise. >> Just printing out skb->dev->name should do the trick, no? > > The printk in virtio_net_hdr_from_skb says NULL. > > That is probably normal for a locally originated frame. > > I cannot reproduce this with network traffic by the way - it happens=20 > only if the traffic is locally originated on the host. > > A, Or maybe you can try add dump_stack() there. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-2.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j25Ef-0000ag-F8 for linux-um@lists.infradead.org; Thu, 13 Feb 2020 03:32:18 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> From: Jason Wang Message-ID: <71193f51-9606-58ba-39d7-904bc9fbd29a@redhat.com> Date: Thu, 13 Feb 2020 11:31:38 +0800 MIME-Version: 1.0 In-Reply-To: <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Anton Ivanov , "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org Ck9uIDIwMjAvMi8xMyDkuIrljYgxOjM4LCBBbnRvbiBJdmFub3Ygd3JvdGU6Cj4KPgo+IE9uIDEx LzAyLzIwMjAgMTA6MzcsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPj4gT24gVHVlLCBGZWIg MTEsIDIwMjAgYXQgMDc6NDI6MzdBTSArMDAwMCwgQW50b24gSXZhbm92IHdyb3RlOgo+Pj4gT24g MTEvMDIvMjAyMCAwMjo1MSwgSmFzb24gV2FuZyB3cm90ZToKPj4+Pgo+Pj4+IE9uIDIwMjAvMi8x MSDkuIrljYgxMjo1NSwgQW50b24gSXZhbm92IHdyb3RlOgo+Pj4+Pgo+Pj4+Pgo+Pj4+PiBPbiAw OS8xMi8yMDE5IDEwOjQ4LCBhbnRvbi5pdmFub3ZAY2FtYnJpZGdlZ3JleXMuY29tIHdyb3RlOgo+ Pj4+Pj4gRnJvbTogQW50b24gSXZhbm92IDxhbnRvbi5pdmFub3ZAY2FtYnJpZGdlZ3JleXMuY29t Pgo+Pj4+Pj4KPj4+Pj4+IFNvbWUgb2YgdGhlIGZyYW1lcyBtYXJrZWQgYXMgR1NPIHdoaWNoIGFy cml2ZSBhdAo+Pj4+Pj4gdmlydGlvX25ldF9oZHJfZnJvbV9za2IoKSBoYXZlIG5vIEdTT19UWVBF LCBubwo+Pj4+Pj4gZnJhZ21lbnRzIChkYXRhX2xlbiA9IDApIGFuZCBsZW5ndGggc2lnbmlmaWNh bnRseSBzaG9ydGVyCj4+Pj4+PiB0aGFuIHRoZSBNVFUgKDc1MiBpbiBteSBleHBlcmltZW50cyku Cj4+Pj4+Pgo+Pj4+Pj4gVGhpcyBpcyBvYnNlcnZlZCBvbiByYXcgc29ja2V0cyByZWFkaW5nIG9m ZiB2RXRoIGludGVyZmFjZXMKPj4+Pj4+IGluIGFsbCA0LnggYW5kIDUueCBrZXJuZWxzIEkgdGVz dGVkLgo+Pj4+Pj4KPj4+Pj4+IFRoZXNlIGZyYW1lcyBhcmUgcmVwb3J0ZWQgYXMgaW52YWxpZCB3 aGlsZSB0aGV5IGFyZSBpbiBmYWN0Cj4+Pj4+PiBnc28tbGVzcyBmcmFtZXMuCj4+Pj4+Pgo+Pj4+ Pj4gVGhpcyBwYXRjaCBtYXJrcyB0aGUgdm5ldCBoZWFkZXIgYXMgbm8tR1NPIGZvciB0aGVtIGlu c3RlYWQKPj4+Pj4+IG9mIHJlcG9ydGluZyBpdCBhcyBpbnZhbGlkLgo+Pj4+Pj4KPj4+Pj4+IFNp Z25lZC1vZmYtYnk6IEFudG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNv bT4KPj4+Pj4+IC0tLQo+Pj4+Pj4gwqDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDgg KysrKysrLS0KPj4+Pj4+IMKgwqAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBk ZWxldGlvbnMoLSkKPj4+Pj4+Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0 aW9fbmV0LmggYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+Pj4+Pj4gaW5kZXggMGQxZmU5 Mjk3YWM2Li5kOTBkNWNmZjFiOWEgMTAwNjQ0Cj4+Pj4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L3Zp cnRpb19uZXQuaAo+Pj4+Pj4gKysrIGIvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmgKPj4+Pj4+ IEBAIC0xMTIsOCArMTEyLDEyIEBAIHN0YXRpYyBpbmxpbmUgaW50Cj4+Pj4+PiB2aXJ0aW9fbmV0 X2hkcl9mcm9tX3NrYihjb25zdCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiLAo+Pj4+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RD UFY0Owo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZSBpZiAoc2luZm8tPmdzb190eXBl ICYgU0tCX0dTT19UQ1BWNikKPj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRy LT5nc29fdHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19UQ1BWNjsKPj4+Pj4+IC3CoMKgwqDCoMKg wqDCoCBlbHNlCj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsK Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBlbHNlIHsKPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGlmIChza2ItPmRhdGFfbGVuID09IDApCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9fTkVUX0hEUl9HU09fTk9ORTsKPj4+Pj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVsc2UKPj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgfQo+Pj4+ Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHNpbmZvLT5nc29fdHlwZSAmIFNLQl9HU09fVENQ X0VDTikKPj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8 PSBWSVJUSU9fTkVUX0hEUl9HU09fRUNOOwo+Pj4+Pj4gwqDCoMKgwqDCoMKgIH0gZWxzZQo+Pj4+ Pj4KPj4+Pj4KPj4+Pj4gcGluZy4KPj4+Pj4KPj4+Pgo+Pj4+IERvIHlvdSBtZWFuIGdzb19zaXpl IGlzIHNldCBidXQgZ3NvX3R5cGUgaXMgbm90PyBMb29rcyBsaWtlIGEgYnVnCj4+Pj4gZWxzZXdo ZXJlLgo+Pj4+Cj4+Pj4gVGhhbmtzCj4+Pj4KPj4+Pgo+Pj4gWWVzLgo+Pj4KPj4+IEkgY291bGQg bm90IHRyYWNlIGl0IHdoZXJlIGl0IGlzIGNvbWluZyBmcm9tLgo+Pj4KPj4+IEkgc2VlIGl0IHdo ZW4gZG9pbmcgcmVjdm1tc2cgb24gcmF3IHNvY2tldHMgaW4gdGhlIFVNTCB2ZWN0b3IgbmV0d29y awo+Pj4gZHJpdmVycy4KPj4+Cj4+Cj4+IEkgdGhpbmsgd2UgbmVlZCB0byBmaW5kIHRoZSBjdWxw cml0IGFuZCBmaXggaXQgdGhlcmUsIGxvdHMgb2Ygb3RoZXIgCj4+IHRoaW5ncwo+PiBjYW4gYnJl YWsgb3RoZXJ3aXNlLgo+PiBKdXN0IHByaW50aW5nIG91dCBza2ItPmRldi0+bmFtZSBzaG91bGQg ZG8gdGhlIHRyaWNrLCBubz8KPgo+IFRoZSBwcmludGsgaW4gdmlydGlvX25ldF9oZHJfZnJvbV9z a2Igc2F5cyBOVUxMLgo+Cj4gVGhhdCBpcyBwcm9iYWJseSBub3JtYWwgZm9yIGEgbG9jYWxseSBv cmlnaW5hdGVkIGZyYW1lLgo+Cj4gSSBjYW5ub3QgcmVwcm9kdWNlIHRoaXMgd2l0aCBuZXR3b3Jr IHRyYWZmaWMgYnkgdGhlIHdheSAtIGl0IGhhcHBlbnMgCj4gb25seSBpZiB0aGUgdHJhZmZpYyBp cyBsb2NhbGx5IG9yaWdpbmF0ZWQgb24gdGhlIGhvc3QuCj4KPiBBLAoKCk9yIG1heWJlIHlvdSBj YW4gdHJ5IGFkZCBkdW1wX3N0YWNrKCkgdGhlcmUuCgpUaGFua3MKCgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1haWxpbmcgbGlzdAps aW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtdW0K