Re: [PATCH] drm/mgag200: Debug-print unique revisions id on G200 SE

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: airlied@redhat.com, sam@ravnborg.org,
	dri-devel@lists.freedesktop.org, john.p.donnelly@oracle.com
Subject: Re: [PATCH] drm/mgag200: Debug-print unique revisions id on G200 SE
Date: Thu, 5 Dec 2019 09:05:29 +0100	[thread overview]
Message-ID: <711e8df6-f10e-209e-fd07-f6a8d90e6824@suse.de> (raw)
In-Reply-To: <20191205080302.4oswszd3znca3xh7@sirius.home.kraxel.org>

[-- Attachment #1.1.1: Type: text/plain, Size: 1583 bytes --]

Hi

Am 05.12.19 um 09:03 schrieb Gerd Hoffmann:
> On Wed, Dec 04, 2019 at 02:34:35PM +0100, Thomas Zimmermann wrote:
>> The behavior of MGA G200 SE depends on the rev id. Print the id when
>> debugging is enabled.
> 
> That is the one where some need a workaround, right?

Yes. Hopefully this ID helps with figuring out the broken ones.

> 
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>  drivers/gpu/drm/mgag200/mgag200_main.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
>> index e1bc5b0aa774..aeb7c10ded0d 100644
>> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
>> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
>> @@ -118,8 +118,11 @@ static int mgag200_device_init(struct drm_device *dev,
>>  		return -ENOMEM;
>>  
>>  	/* stash G200 SE model number for later use */
>> -	if (IS_G200_SE(mdev))
>> +	if (IS_G200_SE(mdev)) {
>>  		mdev->unique_rev_id = RREG32(0x1e24);
>> +		DRM_DEBUG("G200 SE unique revision id is 0x%x\n",
>> +			  mdev->unique_rev_id);
> 
> Maybe use DRM_INFO here?  Temporarily for a few kernel revisions, until
> things are settled?
> 
> (just a suggestion, your choice).
> 
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Thanks.

Best regards
Thomas

> 
> cheers,
>   Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel