All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yi Liu <yi.l.liu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <alex.williamson@redhat.com>, <kevin.tian@intel.com>,
	<kvm@vger.kernel.org>, Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [Patch 1/1] vfio: Move "device->open_count--" out of group_rwsem in vfio_device_open()
Date: Mon, 27 Jun 2022 15:45:18 +0800	[thread overview]
Message-ID: <713d2cb4-caad-66f5-246d-9243972cf969@intel.com> (raw)
In-Reply-To: <20220624140556.GP4147@nvidia.com>

On 2022/6/24 22:05, Jason Gunthorpe wrote:
> On Mon, Jun 20, 2022 at 01:54:59AM -0700, Yi Liu wrote:
>> No need to protect open_count with group_rwsem
> 
> You should explain why this is a good change as you did in the emails
> here, and no cover letter required for single patches
>   
>> Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM")
>>
> 
> Extra space after fixes line.
> No Fixes line for things that are not bugs.
> 
>> cc: Matthew Rosato <mjrosato@linux.ibm.com>
>> cc: Jason Gunthorpe <jgg@nvidia.com>
> 
> Cc:
> 
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>>   drivers/vfio/vfio.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> It seems OK but a bit unnecessary.
> 

thanks, Jason. all good suggestions.I'd just want to see the
device->dev_set->lock and the group_rwsem hold/release is
symmetric in the case of err_undo_count is hit in the vfio_device_open().
Just like the order in vfio_device_fops_release().

-- 
Regards,
Yi Liu

      reply	other threads:[~2022-06-27  7:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  8:54 [Patch 0/1] A bug fix to the error handling path in vfio_device_open() Yi Liu
2022-06-20  8:54 ` [Patch 1/1] vfio: Move "device->open_count--" out of group_rwsem " Yi Liu
2022-06-20 20:13   ` Matthew Rosato
2022-06-21  1:31     ` Yi Liu
2022-06-21  2:49       ` Tian, Kevin
2022-06-21  2:59         ` Yi Liu
2022-06-21  3:26           ` Tian, Kevin
2022-06-21  3:35             ` Yi Liu
2022-06-24 14:05   ` Jason Gunthorpe
2022-06-27  7:45     ` Yi Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=713d2cb4-caad-66f5-246d-9243972cf969@intel.com \
    --to=yi.l.liu@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.