All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Cutler <ncutler@suse.cz>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Untested PRs merged to jewel before 10.2.6 release?
Date: Tue, 7 Mar 2017 22:38:52 +0100	[thread overview]
Message-ID: <713de223-60a8-7def-5e59-c6c09b52dc06@suse.cz> (raw)

I noticed that the v10.2.6 tag was added today and, as far as I can 
tell, it was added to the tip of the jewel branch. That would be fine, 
except that the tip of the jewel branch at the time the tag was added 
(420a9a0796e327676cb704bc18b2020f9941d7b6) is several PRs ahead of the 
jewel SHA1 that underwent integration testing 
(d9eaab456ff45ae88e83bd633f0c4efb5902bf07).

$ git log --oneline --no-merges 
d9eaab456ff45ae88e83bd633f0c4efb5902bf07..420a9a0796e327676cb704bc18b2020f9941d7b6
88f4895 qa/suites/upgrade/hammer-x: Add some volumes
0c242d1 qa/suites/ceph-deploy: Drop OpenStack volume count
ccd0265 qa: replace centos 7.2 with centos 7.3
2cbec5b Removed dumplin test 13234.yaml as not needed anymore
771e1d9 qa/suites/rest: Openstack volumes
a18640f qa/suites/ceph-ansible: Openstack volumes
841688b qa/suites/fs: Add openstack volume configuration
9778743 qa/suites/samba: Openstack volume configuration
cd1e8ef qa/suites/hadoop: Openstack volume configuration
ac7add1 qa/suites/knfs: Add openstack volume configuration
ba35859 qa/suites/kcephfs: Openstack volume configuration
aced718 qa/suites/krbd: Add openstack volume configuration
94d5888 qa/suites/rgw: Add openstack volume configuration

Am I seeing that right? If so, that appears to potentially defeat the 
purpose of the integration testing we do. Maybe I'm overstating the 
danger here -- the commits look innocuous enough -- but it seems to set 
a rather dangerous precedent.

Nathan

             reply	other threads:[~2017-03-08  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 21:38 Nathan Cutler [this message]
2017-03-08  1:50 ` Untested PRs merged to jewel before 10.2.6 release? Robin H. Johnson
2017-03-14  0:30   ` Nathan Cutler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=713de223-60a8-7def-5e59-c6c09b52dc06@suse.cz \
    --to=ncutler@suse.cz \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.