All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage
Date: Mon, 21 Nov 2016 11:34:08 +0100	[thread overview]
Message-ID: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> (raw)
In-Reply-To: <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com>

On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote:
> On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote:
>> MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported
>> so we can drop the dead code.  After this the driver no longer
>> differentiates between machines (S3C24xx machines are not supported by
>> it) so there is no need to override I2S device id in cpu_dai_name and
>> SEC_PLAYBACK dai_link can be removed as well.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>
>> Not tested. The driver did not override .platform_name which looks
>> suspicious to me. However I did not want to add changes which could have
>> some visible impact on output code.
> 
> The patch looks good to me. However the existing smdk64xx sound support
> less so. I don't have smdk6410 set up for testing yet, possibly I get
> around that next week.
> Indeed it's strange .platform_name is not also "samsung-i2s.2".

I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not
register samsung audio dma device as pdev"). Given nobody noticed this in
the last 4 years maybe its time to drop this machine driver as well.

WARNING: multiple messages have this Message-ID
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage
Date: Mon, 21 Nov 2016 11:34:08 +0100	[thread overview]
Message-ID: <713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de> (raw)
In-Reply-To: <8b81b058-0ba9-f1bc-a0ed-d30604853110@samsung.com>

On 11/21/2016 11:30 AM, Sylwester Nawrocki wrote:
> On 11/20/2016 08:24 PM, Krzysztof Kozlowski wrote:
>> MACH_SMDKC100, MACH_SMDKV210 and MACH_SMDKC110 are no longer supported
>> so we can drop the dead code.  After this the driver no longer
>> differentiates between machines (S3C24xx machines are not supported by
>> it) so there is no need to override I2S device id in cpu_dai_name and
>> SEC_PLAYBACK dai_link can be removed as well.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>>
>> Not tested. The driver did not override .platform_name which looks
>> suspicious to me. However I did not want to add changes which could have
>> some visible impact on output code.
> 
> The patch looks good to me. However the existing smdk64xx sound support
> less so. I don't have smdk6410 set up for testing yet, possibly I get
> around that next week.
> Indeed it's strange .platform_name is not also "samsung-i2s.2".

I think that is a fallout from commit a08485d8fdf6f ("ASoC: Samsung: Do not
register samsung audio dma device as pdev"). Given nobody noticed this in
the last 4 years maybe its time to drop this machine driver as well.

  reply	other threads:[~2016-11-21 10:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20 19:24 [RFT v2 0/5] ASoC: samsung: Minor cleanup for old machines Krzysztof Kozlowski
2016-11-20 19:24 ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 1/5] ASoC: samsung: Remove non-existing MACH dependencies Krzysztof Kozlowski
2016-11-20 19:24   ` Krzysztof Kozlowski
2016-11-20 19:24 ` [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage Krzysztof Kozlowski
2016-11-20 19:24   ` Krzysztof Kozlowski
2016-11-21 10:30   ` Sylwester Nawrocki
2016-11-21 10:30     ` Sylwester Nawrocki
2016-11-21 10:34     ` Lars-Peter Clausen [this message]
2016-11-21 10:34       ` Lars-Peter Clausen
2016-11-21 11:21       ` Sylwester Nawrocki
2016-11-21 11:21         ` Sylwester Nawrocki
2016-11-22 17:26   ` Applied "ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage" to the asoc tree Mark Brown
2016-11-22 17:26     ` Mark Brown
2016-11-22 17:26     ` Mark Brown
2016-11-20 19:24 ` [PATCH v2 3/5] ASoC: samsung: Enable COMPILE_TEST for SmartQ and WM8580 Krzysztof Kozlowski
2016-11-20 19:24   ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 4/5] ASoC: samsung: Enable COMPILE_TEST for entire Samsung ASoc Krzysztof Kozlowski
2016-11-20 19:24   ` Krzysztof Kozlowski
2016-11-20 19:24 ` [PATCH v2 5/5] ARM: s5pv210_defconfig: Remove old MACHs Krzysztof Kozlowski
2016-11-20 19:24   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=713e7f53-16b2-a510-e99e-77e785f8a7c1@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.com \
    --subject='Re: [RFT v2 2/5] ASoC: samsung: smdk_wm8580: Remove old platforms and drop mach-types usage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.