From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2A2C4320A for ; Wed, 1 Sep 2021 11:52:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48AD06023E for ; Wed, 1 Sep 2021 11:52:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 48AD06023E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C01682E0A; Wed, 1 Sep 2021 13:52:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="X7mtB2ud"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 637078329D; Wed, 1 Sep 2021 13:51:58 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F172682DB1 for ; Wed, 1 Sep 2021 13:51:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 15A3E22221; Wed, 1 Sep 2021 13:51:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1630497113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fsuN8GmQyppTbE3ISn/Tsw6mUI3WTqGdUQa2vF1580=; b=X7mtB2udo7Gulsf5VNEN0PJcOP1VjfPK36NNxcAOSBCMZmCIgj27qHJ7Yl0fq8eObYKkrJ 3tZI2EmtopIreGbQ/NB3tqy7JJILihIUp1ppJp5C58f6joVSOYWmr3GITFtjfZtHP1ymDd RCEgVb4oxSNvdTDiSAD+DtYg4R/ni+o= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 01 Sep 2021 13:51:53 +0200 From: Michael Walle To: Vladimir Oltean Cc: u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux In-Reply-To: <20210901112414.u3dbcbtlbyanwhjn@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> <20210901112414.u3dbcbtlbyanwhjn@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <713ec89615bb7fbe461b909390cc09c7@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-09-01 13:24, schrieb Vladimir Oltean: > On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote: >> - usb0: usb3@3100000 { >> - compatible = "fsl,layerscape-dwc3"; >> - reg = <0x0 0x3100000 0x0 0x10000>; >> - interrupts = ; >> - dr_mode = "host"; >> - status = "disabled"; >> - }; >> - >> - usb1: usb3@3110000 { >> - compatible = "fsl,layerscape-dwc3"; >> - reg = <0x0 0x3110000 0x0 0x10000>; >> - interrupts = ; >> - dr_mode = "host"; >> + usb0: usb@3100000 { >> + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; >> + reg = <0x0 0x3100000 0x0 0x10000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_rxdet_inp3_quirk; >> + snps,quirk-frame-length-adjustment = <0x20>; >> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; >> + }; >> + >> + usb1: usb@3110000 { >> + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; >> + reg = <0x0 0x3110000 0x0 0x10000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_rxdet_inp3_quirk; >> + snps,quirk-frame-length-adjustment = <0x20>; >> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; >> + }; > > I see the status = 'disabled' was lost in the new bindings? This is > strange considering that it is you who sent the patch to disable them > in > Linux, just yesterday: > https://lkml.org/lkml/2021/8/31/426 Yes but that is on purpose. In the current u-boot device tree, it was disabled, but the boards reenabled them again. So it didn't matter. I want to have a specific sync point (that is the v5.14 tag) for the .dtsi. At least where possible; for phy-mode and so on I needed to to take additional patches which weren't picked up in linux yet, but these just affect the sl28 board device trees. -michael