From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A737C07E99 for ; Mon, 5 Jul 2021 19:47:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6AF61961 for ; Mon, 5 Jul 2021 19:47:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6AF61961 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1532082991; Mon, 5 Jul 2021 21:47:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jWNa9zdR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F357782BB4; Mon, 5 Jul 2021 21:46:57 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07E70800B2 for ; Mon, 5 Jul 2021 21:46:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x72e.google.com with SMTP id g4so17987452qkl.1 for ; Mon, 05 Jul 2021 12:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3uBncI1v41Zku9ZrEyqumxX8V87JqkkdJpJ2yhWwk6Q=; b=jWNa9zdRvmUHqbQz/+fxbbsEuacRKBQTNpjD7ssorWlK7KEnRRpz7D+jeztEqtSRrt 14ukbt3/Xu7505wU3QsBvfA5jLMTAuY5en1TmC1w9bP97PSLcGCmX58TOtRM4LzRK7he Zeii5VYywy9elKPfIsu98owfOdwfi2n0Lx2QI3COpKvDSQvR0iwWZM5mrjTsYgB4q0s5 QqcNs3NRd1/pZxjh3RzPU6ZcrnGO1KpyGes8E3jbp60ZEIsCKYLBQkoQ4NijdwbMywGl JjmcIbtZXAHd/4DT52IE0YmBTAUjI2qAjT722K+uzro04PYf/EhwClBcaMoNOtjJhI5K Y6sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3uBncI1v41Zku9ZrEyqumxX8V87JqkkdJpJ2yhWwk6Q=; b=Mml4ljDs/wo8D68a+RseKQ8dtfHe/U73rrAjA4JSGMhnKjQDuDMeIZrTpdROjzMjj4 nz7+WJPBxMZsJXFG3D1M5LEyXv9iPUQAOkeghPonDxTn05ypHSnyr+a1uyGSrp5hAZwo /++WA5cb98mRxovDUvZul+tITk3gpc0y/hkoNRgaJCNIap3gBARPuuJO5Kvq6Rn6seWC rmjBKfKSgzygiax1IGtJXP/9NFHw4HixuRdpwQSrmHtDfPVZSEzib4MhwRFYw2mdtWEG b1SM++HyFn45wEpdFBMaA3kU2jEdUwg719MLwTpHbaBRM5XDT2bkCi7pRp2PkMGY+5mg RYFg== X-Gm-Message-State: AOAM530mOa0PsKuAiWRz0K15WAO7D1DJFQ90j/vPLRSj1tJF7DDhlx0O kJXVt/IdxAiRvpNbySaffuA= X-Google-Smtp-Source: ABdhPJxFjKdWCe/ikQV9PzeZ5j52DkGnqZ+xp34neyVLXz6BkrMPhUvvPjwzx1jXem0S99yvDWzYMg== X-Received: by 2002:a37:64c9:: with SMTP id y192mr8188060qkb.190.1625514412853; Mon, 05 Jul 2021 12:46:52 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id p187sm5756235qkd.57.2021.07.05.12.46.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jul 2021 12:46:52 -0700 (PDT) Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL To: Wolfgang Denk Cc: Simon Glass , U-Boot Mailing List , Tom Rini , =?UTF-8?Q?Marek_Beh=c3=ban?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> From: Sean Anderson Message-ID: <7143cb1e-4061-3034-57b9-1a12753fa642@gmail.com> Date: Mon, 5 Jul 2021 15:46:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <163753.1625507898@gemini.denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/5/21 1:58 PM, Wolfgang Denk wrote: > Dear Sean, > > In message you wrote: >> >>> Is your intent to create a fork of this in U-Boot? >> >> Yes. I believe some of the major additions I have made (especially "[RFC >> PATCH 21/28] cli: lil: Add a distinct parsing step") would not be >> accepted by upstream. > > Ouch... I don't particularly mind if Kostas doesn't view these patches as good additions to upstream. We have different goals and requirements, and so not all changes will be compatible. >>> Could we not update things upstream, at least as an option, to avoid >>> carrying these patches? >> >> For some of the smaller patches, that may be possible. However, I am not >> a fan of the major amount of ifdefs that Hush has. For something as core >> as a shell, I think we should be free to make changes as we see fit >> without worrying about how it will affect a hypothetical backport. > > I'm afraind I cannot understand your thinking. > > You complain that the existing port of hus has a number of severe > limitations or bugs which have long been fixed upstream, The bugs are fairly minor. The particular characteristics of Hush have not changed. These characteristics make Hush difficult to adapt to the limitations of U-Boot. When we cannot support the basic abstractions expected by Hush, the shell will necessarily change for the worse. > but cannot be easily fixed in U-Boot Because they are core to the design of Hush (and other bourne derived shells). > because we essentially created an unmaintained fork I plan to maintain this fork. --Sean > - and as a cure, you recommend to do the same > thing again, but this time intentionally and deliberately? > If you had not apparently already invested a lot of effort into this > thing I would assume you must be joking... > > To me such an approach is unacceptable. > > Best regards, > > Wolfgang Denk >