Re: [PATCH v3] usb: gadget: u_audio.c: Adding Playback Pitch ctl for sync playback

[Pavel Hofman <pavel.hofman@ivitera.com>]

Dne 12. 10. 21 v 9:20 Greg Kroah-Hartman napsal(a):
> On Wed, Oct 06, 2021 at 10:12:58AM +0200, Pavel Hofman wrote:
>> EP IN is hard-coded as ASYNC both in f_uac1 and f_uac2 but u_audio sends
>> steady number of audio frames in each USB packet, without any control.
>>
>> This patch adds 'Playback Pitch 1000000' ctl analogous to the existing
>> 'Capture Pitch 1000000' ctl. The calculation of playback req->length in
>> u_audio_iso_complete respects the Playback Pitch ctl value to 1ppm now.
>>
>> Max. value for Playback Pitch is configured by the existing parameter
>> uac2_opts->fb_max, used also for the Capture Pitch.
>>
>> Since the EP IN packet size can be increased by uac2_opts->fb_max now,
>> maxPacketSize for the playback direction is calculated by the same
>> algorithm as for the async capture direction in
>> f_uac2.c:set_ep_max_packet_size.
>>
>> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
>> ---
>>
>> Notes:
>>      v2 -> v3: only notes added
>>      
>>      For: usb-next
>>      Depends on patch 0560c9c ("usb: gadget: f_uac2: fixed EP-IN
>>      wMaxPacketSize") currently only in branch usb-linus.
> 
> I have dropped this from my usb-testing branch now due to all of the
> issues found by the 0-day bot with it (build failure and warnings.)
> 
> Please fix up and resubmit.
> 

I apologize for the issues, a fixed patch was submitted a while ago 
https://patchwork.kernel.org/project/linux-usb/patch/20211013073934.36476-1-pavel.hofman@ivitera.com/

Thanks a lot,

Pavel.