From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 2/3] ethdev: add optional rxtx callback
	support
Date: Fri, 20 Feb 2015 11:31:03 +0100
Message-ID: <7158573.4LYx2RfyGr@xps13>
References: <1424281343-2994-1-git-send-email-john.mcnamara@intel.com>
 <1424368602-30826-3-git-send-email-john.mcnamara@intel.com>
 <20150220100600.GA17276@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
 John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20150220100600.GA17276@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-02-20 10:06, Bruce Richardson:
> On Thu, Feb 19, 2015 at 05:56:41PM +0000, John McNamara wrote:
> > From: Richardson, Bruce <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Add optional support for inline processing of packets inside the RX
> > or TX call. For an RX callback, what happens is that we get a set of
> > packets from the NIC and then pass them to a callback function, if
> > configured, to allow additional processing to be done on them, e.g.
> > filling in more mbuf fields, before passing back to the application.
> > On TX, the packets are similarly post-processed before being handed
> > to the NIC for transmission.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: John McNamara <john.mcnamara-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> >  config/common_bsdapp                   |    1 +
> >  config/common_linuxapp                 |    1 +
> >  lib/librte_ether/rte_ethdev.c          |  192 +++++++++++++++++++++++++++++-
> >  lib/librte_ether/rte_ethdev.h          |  204 +++++++++++++++++++++++++++++++-
> >  lib/librte_ether/rte_ether_version.map |    4 +
> >  5 files changed, 397 insertions(+), 5 deletions(-)
> > 
> > diff --git a/config/common_bsdapp b/config/common_bsdapp
> > index f11ff39..e9c445e 100644
> > --- a/config/common_bsdapp
> > +++ b/config/common_bsdapp
> > @@ -133,6 +133,7 @@ CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n
> >  CONFIG_RTE_MAX_ETHPORTS=32
> >  CONFIG_RTE_LIBRTE_IEEE1588=n
> >  CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16
> > +CONFIG_RTE_LIBRTE_ETHDEV_RXTX_CALLBACKS=n
> 
> I no reason why this should not be "y" by default. Those who are not using it
> and don't want the tiny performance impact of it, can turn it off. 

If you are going to change it, I think the shorter name CONFIG_RTE_ETHDEV_RXTX_CALLBACKS
would be sufficient.