From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers Date: Thu, 10 Dec 2015 00:29:27 +0100 Message-ID: <7162994.ydt4N8UgZZ@wuerfel> References: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1449703322-17762-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Paul Gortmaker , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Courbot , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , Vinod Koul , Haojian Zhuang , Laxman Dewangan , Thierry Reding , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , Robert Jarzmik , Daniel Mack List-Id: linux-tegra@vger.kernel.org On Wednesday 09 December 2015 18:21:56 Paul Gortmaker wrote: > This series of commits is a slice of a larger project to ensure > people don't have dead code for module removal in non-modular > drivers. Overall there is roughly 5k lines of dead code in the > kernel due to this. > > There is a quasi-separate theme, in that some of the drivers were > allowing an unbind implicitly since it is enabled by default. But > for core DMA infrastructure drivers, this doesn't seem useful -- so > we also disable that here which allows us to delete any ".remove" > functions from the drivers that would otherwise be called during the > (impossible to trigger) module removal. > > Since ARM covers these files the best of all architectures, each > file was build tested for allmodconfig on ARM, which at the same > time confirms that the files are not built with "CC [M]" -- hence > genuinely non-modular. > > My testing and the larger patch series in general has been done > against the latest linux-next tree. > > We are in the process of changing the DMA drivers to a new way of passing the "filter" function around. We can soon build them all as loadable modules again. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbLIXaK (ORCPT ); Wed, 9 Dec 2015 18:30:10 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:54093 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbbLIXaI (ORCPT ); Wed, 9 Dec 2015 18:30:08 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Alexandre Courbot , linux-tegra@vger.kernel.org, Stephen Warren , Vinod Koul , Haojian Zhuang , Laxman Dewangan , Thierry Reding , dmaengine@vger.kernel.org, Dan Williams , Robert Jarzmik , Daniel Mack Subject: Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers Date: Thu, 10 Dec 2015 00:29:27 +0100 Message-ID: <7162994.ydt4N8UgZZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> References: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:CqPgERB2S5oER8AkLpdC99w0TN/89k3MYKY+avqOt6cRvJcD64N hqsPieeHzH3kUNYwlzZ6lzmREHy17GC4krqTyS0Thozfm7eb3k/JoBZSaoHKif1uerzgntL LLb28XF/OjRN6RRxxcT41jDEJfOfIk9Pv9ZVH6LNEcp8kKEJKzuyZ4l2UNy5F7hqkJkbjLj paX9UZ1GjLuhGribtG+OQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mFdA2vTS/AY=:GFsApLxFTkodHkIa+Iy18m 52S1BL60s6uhD93uNiPxw97WyYZ4l1o1Y7145TthrXxBjsd27KvdQr6aUnAWqnNBQuoP/mbp4 UgSkZMXjMFkkFmheEkgjXi1wWdSrD1Xj/Ug2cfQBjjo/zF5Eljb72eW8rGAgwYM+3kiS6GKx1 Oj7axJtdPuo38tfVJrkLkhOTxOnF03waiL5XmlIJdS0iEHQ2+MAMOLAWoe3dD1Q1gUAQFALIB mqyqbcgZotuRUou1AVgqyp30wL8lEfLAxhenF8y6ULw7DpRDPrUvQ/aandh7ucLfE8lem7kpc lFvaDZSv/rHIl7U6HEKRvmwhsZu7oOhbSX/M3N9uRtUJROcoPZshwq5HENwN1ydfhyU7k/XOP 2o+2yZgl+au7wIFNn9/Zg8frdwSLjuG3E3JjlKCB/wcfWxHOARip+F+uloTA2mMiVeG85ulN5 cRkVfD82UzYDi7MrEbUTBmI/Y0R/b1NPRhFZgmZYVYibsT9u3ucaBHR/KPhQV0rWsE2lJkJ7s 4/Gs7pLZEmqikiGrw+MgIQYlL+oo8Ggn7Fj/y1B48HVo5KRdrDFleMS3CMGQEl/Ov9l6NWt25 GLWe1BUHTlczAcrJF09i0ZoeXRUOP0KzSw9zZuLQ15BKa1BtI5lwoMl+ZkppNo1XiXV/Ryh6U nRUv6u6VRkoDmNy4xd2FzBpm6wHtvnUjDCrzeZJskvQYJSVnCBzsd/6kK5MrinDJNHZNcI39o sqbVg92uZJB6Uioj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 09 December 2015 18:21:56 Paul Gortmaker wrote: > This series of commits is a slice of a larger project to ensure > people don't have dead code for module removal in non-modular > drivers. Overall there is roughly 5k lines of dead code in the > kernel due to this. > > There is a quasi-separate theme, in that some of the drivers were > allowing an unbind implicitly since it is enabled by default. But > for core DMA infrastructure drivers, this doesn't seem useful -- so > we also disable that here which allows us to delete any ".remove" > functions from the drivers that would otherwise be called during the > (impossible to trigger) module removal. > > Since ARM covers these files the best of all architectures, each > file was build tested for allmodconfig on ARM, which at the same > time confirms that the files are not built with "CC [M]" -- hence > genuinely non-modular. > > My testing and the larger patch series in general has been done > against the latest linux-next tree. > > We are in the process of changing the DMA drivers to a new way of passing the "filter" function around. We can soon build them all as loadable modules again. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 10 Dec 2015 00:29:27 +0100 Subject: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers In-Reply-To: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> References: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> Message-ID: <7162994.ydt4N8UgZZ@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 09 December 2015 18:21:56 Paul Gortmaker wrote: > This series of commits is a slice of a larger project to ensure > people don't have dead code for module removal in non-modular > drivers. Overall there is roughly 5k lines of dead code in the > kernel due to this. > > There is a quasi-separate theme, in that some of the drivers were > allowing an unbind implicitly since it is enabled by default. But > for core DMA infrastructure drivers, this doesn't seem useful -- so > we also disable that here which allows us to delete any ".remove" > functions from the drivers that would otherwise be called during the > (impossible to trigger) module removal. > > Since ARM covers these files the best of all architectures, each > file was build tested for allmodconfig on ARM, which at the same > time confirms that the files are not built with "CC [M]" -- hence > genuinely non-modular. > > My testing and the larger patch series in general has been done > against the latest linux-next tree. > > We are in the process of changing the DMA drivers to a new way of passing the "filter" function around. We can soon build them all as loadable modules again. Arnd