All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pasha Tatashin <Pavel.Tatashin@microsoft.com>
To: Oscar Salvador <osalvador@techadventures.net>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "mhocko@suse.com" <mhocko@suse.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"david@redhat.com" <david@redhat.com>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
	"yasu.isimatu@gmail.com" <yasu.isimatu@gmail.com>,
	"malat@debian.org" <malat@debian.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 4/5] mm/memory_hotplug: Simplify node_states_check_changes_online
Date: Fri, 21 Sep 2018 00:15:53 +0000	[thread overview]
Message-ID: <71676241-8aa5-2b58-b2fa-706bf21b9cfb@microsoft.com> (raw)
In-Reply-To: <20180919100819.25518-5-osalvador@techadventures.net>



On 9/19/18 6:08 AM, Oscar Salvador wrote:
> From: Oscar Salvador <osalvador@suse.de>
> 
> While looking at node_states_check_changes_online, I stumbled
> upon some confusing things.
> 
> Right after entering the function, we find this:
> 
> if (N_MEMORY == N_NORMAL_MEMORY)
>         zone_last = ZONE_MOVABLE;
> 
> This is wrong.
> N_MEMORY cannot really be equal to N_NORMAL_MEMORY.
> My guess is that this wanted to be something like:
> 
> if (N_NORMAL_MEMORY == N_HIGH_MEMORY)
> 
> to check if we have CONFIG_HIGHMEM.
> 
> Later on, in the CONFIG_HIGHMEM block, we have:
> 
> if (N_MEMORY == N_HIGH_MEMORY)
>         zone_last = ZONE_MOVABLE;
> 
> Again, this is wrong, and will never be evaluated to true.
> 
> Besides removing these wrong if statements, I simplified
> the function a bit.
> 
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
>  mm/memory_hotplug.c | 71 +++++++++++++++++------------------------------------
>  1 file changed, 23 insertions(+), 48 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 131c08106d54..ab3c1de18c5d 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -687,61 +687,36 @@ static void node_states_check_changes_online(unsigned long nr_pages,
>  	struct zone *zone, struct memory_notify *arg)
>  {
>  	int nid = zone_to_nid(zone);
> -	enum zone_type zone_last = ZONE_NORMAL;
>  
>  	/*
> -	 * If we have HIGHMEM or movable node, node_states[N_NORMAL_MEMORY]
> -	 * contains nodes which have zones of 0...ZONE_NORMAL,
> -	 * set zone_last to ZONE_NORMAL.
> -	 *
> -	 * If we don't have HIGHMEM nor movable node,
> -	 * node_states[N_NORMAL_MEMORY] contains nodes which have zones of
> -	 * 0...ZONE_MOVABLE, set zone_last to ZONE_MOVABLE.
> +	 * zone_for_pfn_range() can only return a zone within
> +	 * (0..ZONE_NORMAL] or ZONE_MOVABLE.

But what if that changes, will this function need to change as well?

> +	 * If the zone is within the range (0..ZONE_NORMAL],
> +	 * we need to check if:
> +	 * 1) We need to set the node for N_NORMAL_MEMORY
> +	 * 2) On CONFIG_HIGHMEM systems, we need to also set
> +	 *    the node for N_HIGH_MEMORY.
> +	 * 3) On !CONFIG_HIGHMEM, we can disregard N_HIGH_MEMORY,
> +	 *    as N_HIGH_MEMORY falls back to N_NORMAL_MEMORY.
>  	 */
> -	if (N_MEMORY == N_NORMAL_MEMORY)
> -		zone_last = ZONE_MOVABLE;
>  
> -	/*
> -	 * if the memory to be online is in a zone of 0...zone_last, and
> -	 * the zones of 0...zone_last don't have memory before online, we will
> -	 * need to set the node to node_states[N_NORMAL_MEMORY] after
> -	 * the memory is online.
> -	 */
> -	if (zone_idx(zone) <= zone_last && !node_state(nid, N_NORMAL_MEMORY))
> -		arg->status_change_nid_normal = nid;
> -	else
> -		arg->status_change_nid_normal = -1;
> -
> -#ifdef CONFIG_HIGHMEM
> -	/*
> -	 * If we have movable node, node_states[N_HIGH_MEMORY]
> -	 * contains nodes which have zones of 0...ZONE_HIGHMEM,
> -	 * set zone_last to ZONE_HIGHMEM.
> -	 *
> -	 * If we don't have movable node, node_states[N_NORMAL_MEMORY]
> -	 * contains nodes which have zones of 0...ZONE_MOVABLE,
> -	 * set zone_last to ZONE_MOVABLE.
> -	 */
> -	zone_last = ZONE_HIGHMEM;
> -	if (N_MEMORY == N_HIGH_MEMORY)
> -		zone_last = ZONE_MOVABLE;
> +	if (zone_idx(zone) <= ZONE_NORMAL) {
> +		if (!node_state(nid, N_NORMAL_MEMORY))
> +			arg->status_change_nid_normal = nid;
> +		else
> +			arg->status_change_nid_normal = -1;
>  
> -	if (zone_idx(zone) <= zone_last && !node_state(nid, N_HIGH_MEMORY))
> -		arg->status_change_nid_high = nid;
> -	else
> -		arg->status_change_nid_high = -1;
> -#else
> -	/*
> -	 * When !CONFIG_HIGHMEM, N_HIGH_MEMORY equals N_NORMAL_MEMORY
> -	 * so setting the node for N_NORMAL_MEMORY is enough.
> -	 */
> -	arg->status_change_nid_high = -1;
> -#endif
> +		if (IS_ENABLED(CONFIG_HIGHMEM)) {
> +			if (!node_state(nid, N_HIGH_MEMORY))
> +				arg->status_change_nid_high = nid;

Should not we have:
			else
				arg->status_change_nid_high = -1; ?

> +		} else
> +			arg->status_change_nid_high = -1;


I prefer to have braces in else part as well when if has braces.

> +	}
>  
>  	/*
> -	 * if the node don't have memory befor online, we will need to
> -	 * set the node to node_states[N_MEMORY] after the memory
> -	 * is online.
> +	 * if the node doesn't have memory before onlining it, we will need
> +	 * to set the node to node_states[N_MEMORY] after the memory
> +	 * gets onlined.
>  	 */
>  	if (!node_state(nid, N_MEMORY))
>  		arg->status_change_nid = nid;
> 

I think it is simpler to have something like this:

        int nid = zone_to_nid(zone);

        arg->status_change_nid_high = -1;
        arg->status_change_nid = -1;
        arg->status_change_nid = -1;

        if (!node_state(nid, N_MEMORY))
                arg->status_change_nid = nid; 
        if (zone_idx(zone) <= ZONE_NORMAL && !node_state(nid, N_NORMAL_MEMORY))
                arg->status_change_nid_normal = nid; 
#ifdef CONFIG_HIGHMEM
        if (zone_idx(zone) <= N_HIGH_MEMORY && !node_state(nid, N_HIGH_MEMORY))
                arg->status_change_nid_high = nid; 
#endif


Pavel

  reply	other threads:[~2018-09-21  0:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 10:08 [PATCH 0/5] Refactor node_states_check_changes_online/offline Oscar Salvador
2018-09-19 10:08 ` [PATCH 1/5] mm/memory_hotplug: Spare unnecessary calls to node_set_state Oscar Salvador
2018-09-20 20:53   ` Pasha Tatashin
2018-09-19 10:08 ` [PATCH 2/5] mm/memory_hotplug: Avoid node_set/clear_state(N_HIGH_MEMORY) when !CONFIG_HIGHMEM Oscar Salvador
2018-09-20 20:59   ` Pasha Tatashin
2018-09-21 10:31     ` Oscar Salvador
2018-09-19 10:08 ` [PATCH 3/5] mm/memory_hotplug: Tidy up node_states_clear_node Oscar Salvador
2018-09-20 23:40   ` Pasha Tatashin
2018-09-19 10:08 ` [PATCH 4/5] mm/memory_hotplug: Simplify node_states_check_changes_online Oscar Salvador
2018-09-21  0:15   ` Pasha Tatashin [this message]
2018-09-21 10:30     ` Oscar Salvador
2018-09-19 10:08 ` [PATCH 5/5] mm/memory_hotplug: Clean up node_states_check_changes_offline Oscar Salvador
2018-09-21  0:38   ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71676241-8aa5-2b58-b2fa-706bf21b9cfb@microsoft.com \
    --to=pavel.tatashin@microsoft.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=malat@debian.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=osalvador@techadventures.net \
    --cc=yasu.isimatu@gmail.com \
    --subject='Re: [PATCH 4/5] mm/memory_hotplug: Simplify node_states_check_changes_online' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.