All of lore.kernel.org
 help / color / mirror / Atom feed
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] ARM: bcm281xx: Device Tree bindings for GPIO driver
Date: Mon, 19 Aug 2013 23:45:31 +0200	[thread overview]
Message-ID: <7172097.b0dioE2CoB@flatron> (raw)
In-Reply-To: <1376938761-13657-4-git-send-email-markus.mayer@linaro.org>

Hi Markus,

The patch looks good overall, just a little nitpick about the commit 
message.

On Monday 19 of August 2013 11:59:21 Markus Mayer wrote:
> GPIO device tree bindings for the Broadcom bcm281xx family of chips

Device tree bindings are sets of properties and subnodes defined for 
device nodes used to describe those devices. In other words, bindings are 
what you have described in numerous files 
Documentation/devicetree/bindings.

What this patch is adding is a device node for the GPIO controller of 
bcm11351.

Other than that:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

  reply	other threads:[~2013-08-19 21:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 18:59 [PATCH v4 0/3] ARM: bcm281xx: GPIO driver Markus Mayer
2013-08-19 18:59 ` [PATCH v4 1/3] ARM: bcm281xx: Add " Markus Mayer
2013-08-19 19:02   ` Florian Fainelli
2013-08-19 19:05     ` Markus Mayer
2013-08-19 19:11       ` Florian Fainelli
2013-08-19 19:23         ` Markus Mayer
2013-08-19 20:54           ` Florian Fainelli
2013-08-19 22:47   ` Tomasz Figa
2013-08-19 22:52     ` Stephen Warren
2013-08-19 22:50   ` Stephen Warren
2013-08-23 17:34   ` Linus Walleij
2013-08-23 17:58     ` Markus Mayer
2013-08-23 19:30       ` Markus Mayer
2013-08-28 19:50         ` Linus Walleij
2013-08-28 19:50           ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 2/3] ARM: bcm281xx: Enable " Markus Mayer
2013-08-23 17:37   ` Linus Walleij
2013-08-19 18:59 ` [PATCH v4 3/3] ARM: bcm281xx: Device Tree bindings for " Markus Mayer
2013-08-19 21:45   ` Tomasz Figa [this message]
2013-08-19 22:31     ` Markus Mayer
2013-08-23 17:38   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7172097.b0dioE2CoB@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.