From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E61CC4742C for ; Fri, 13 Nov 2020 12:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC23722249 for ; Fri, 13 Nov 2020 12:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=maquefel.me header.i=@maquefel.me header.b="tTEnTkT7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbgKMMLy (ORCPT ); Fri, 13 Nov 2020 07:11:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbgKMMLx (ORCPT ); Fri, 13 Nov 2020 07:11:53 -0500 X-Greylist: delayed 429 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 13 Nov 2020 04:11:53 PST Received: from forward500j.mail.yandex.net (forward500j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA96C0613D1; Fri, 13 Nov 2020 04:11:53 -0800 (PST) Received: from mxback18j.mail.yandex.net (mxback18j.mail.yandex.net [IPv6:2a02:6b8:0:1619::94]) by forward500j.mail.yandex.net (Yandex) with ESMTP id 0AB2411C1C33; Fri, 13 Nov 2020 15:04:37 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback18j.mail.yandex.net (mxback/Yandex) with ESMTP id 4fGUZinil1-4aKaNgI3; Fri, 13 Nov 2020 15:04:36 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1605269076; bh=8JTSwotuRGgc/44wdb4s+/iJsvCU7rusxQ3UllDMBSU=; h=References:Date:Message-Id:Cc:Subject:To:From; b=tTEnTkT72hcEIYLWsXMMSADjwPt9KZLUcKGwXTma1LLMqzxze/DckwxDHLIytcAN6 YtriDipyDVALu1fu1GqOM0Ej89xQxi9lb9/M4kHRxmYobzEx1SPAiqHSzWDzDiWpaa 62+JarJ5J4idn12vn0XChnzmvpTDckTqhY2F8V9w= Authentication-Results: mxback18j.mail.yandex.net; dkim=pass header.i=@maquefel.me Received: by sas1-c37eebe3eab8.qloud-c.yandex.net with HTTP; Fri, 13 Nov 2020 15:04:35 +0300 From: "nikita.shubin@maquefel.me" To: Fabio Estevam Cc: Clark Wang , Mark Brown , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team , linux-kernel , linux-spi , Sascha Hauer , Shawn Guo References: <20200727063354.17031-1-xiaoning.wang@nxp.com> <20201113091800.27469-1-nikita.shubin@maquefel.me> Subject: Re: [PATCH] spi: imx: enable runtime pm support MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 13 Nov 2020 15:04:35 +0300 Message-Id: <717261605268864@mail.yandex.ru> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabio, Apllied on the top of    Revert "spi: imx: Fix freeing of DMA channels if spi_bitbang_start() fails"    This reverts commit 9e68d974b2fd4977e896e166656c36e2f80293d6. Still experiencing the same issue: [ 4.322131] inv-mpu6000-spi spi2.0: I/O Error in PIO [ 4.329353] inv-mpu6000-spi spi2.0: SPI transfer failed: -110 [ 4.391504] spi_master spi2: failed to transfer one message from queue I have config CONFIG_PM=y. 13.11.2020, 14:26, "Fabio Estevam" : > Hi Nikita, > > On Fri, Nov 13, 2020 at 6:18 AM Nikita Shubin wrote: >>  Hello Clark, >> >>  This patch breaks spi-imx on imx7d. >>  Toradex Colibri imx7d spi reports with: >> >>      [ 4.258468] inv-mpu6000-spi spi2.0: I/O Error in PIO >>      [ 4.264269] inv-mpu6000-spi spi2.0: SPI transfer failed: -110 >>      [ 4.264305] spi_master spi2: failed to transfer one message from queue >> >>  We are using spi-imx with dma. >> >>  Reverting your patch fixes this issue. >> >>  The baseline commit 951cbbc386ff01b50da4f46387e994e81d9ab431 (tag: v5.9.8, stable/linux-5.9.y) >> >>  Could you please give some comments on this issue ? > > Could you please try this patch from Sascha? > https://lkml.org/lkml/2020/10/12/981 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB44C388F7 for ; Fri, 13 Nov 2020 12:06:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA78722240 for ; Fri, 13 Nov 2020 12:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="00A2oose"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=maquefel.me header.i=@maquefel.me header.b="tTEnTkT7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA78722240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=maquefel.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:MIME-Version:Subject:References:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Owner; bh=BiErBQ0IgzDnE/7kfoV94s3kFsTlLefUC0GCu3VapQc=; b=00A2ooseQdsOfRSx/72QluQpM EouAk4jmBAClR+FJ1PUvmz1V7YLXJgiz7zeqSI5PnYa8QnfPE+4/WIPnDWMOrs/v9dPYWJiri9ZiT AkRCfuJDLWgnv/ybrgwLKtSieJH2cPhS9Jyk3Z9+FQ+3LfEd7Iq962K1x14sQH12rR2ku04NKO35b RGiADy4nv/gKkWNbTz4HjgeS7r3b4z1SMqCEXF/MS4fDglOmIR3xhXBk1gsBXxmZAqGl0SgkPbLnF nSJ9yUaliUOuLAFBespyKqQQssXCE3n46I9+1VcXTUkSpcsZGfDwn6ck19rHK0XQgPyl21vtQpzoT CRQZPTxpg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdXor-0004le-JG; Fri, 13 Nov 2020 12:04:45 +0000 Received: from forward500j.mail.yandex.net ([2a02:6b8:0:801:2::110]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdXon-0004kE-VF for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 12:04:43 +0000 Received: from mxback18j.mail.yandex.net (mxback18j.mail.yandex.net [IPv6:2a02:6b8:0:1619::94]) by forward500j.mail.yandex.net (Yandex) with ESMTP id 0AB2411C1C33; Fri, 13 Nov 2020 15:04:37 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback18j.mail.yandex.net (mxback/Yandex) with ESMTP id 4fGUZinil1-4aKaNgI3; Fri, 13 Nov 2020 15:04:36 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1605269076; bh=8JTSwotuRGgc/44wdb4s+/iJsvCU7rusxQ3UllDMBSU=; h=References:Date:Message-Id:Cc:Subject:To:From; b=tTEnTkT72hcEIYLWsXMMSADjwPt9KZLUcKGwXTma1LLMqzxze/DckwxDHLIytcAN6 YtriDipyDVALu1fu1GqOM0Ej89xQxi9lb9/M4kHRxmYobzEx1SPAiqHSzWDzDiWpaa 62+JarJ5J4idn12vn0XChnzmvpTDckTqhY2F8V9w= Authentication-Results: mxback18j.mail.yandex.net; dkim=pass header.i=@maquefel.me Received: by sas1-c37eebe3eab8.qloud-c.yandex.net with HTTP; Fri, 13 Nov 2020 15:04:35 +0300 From: "nikita.shubin@maquefel.me" To: Fabio Estevam References: <20200727063354.17031-1-xiaoning.wang@nxp.com> <20201113091800.27469-1-nikita.shubin@maquefel.me> Subject: Re: [PATCH] spi: imx: enable runtime pm support MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Fri, 13 Nov 2020 15:04:35 +0300 Message-Id: <717261605268864@mail.yandex.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_070442_182519_DF10D334 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , linux-kernel , linux-spi , Mark Brown , Clark Wang , NXP Linux Team , Sascha Hauer , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRmFiaW8sCgpBcGxsaWVkIG9uIHRoZSB0b3Agb2YKCsKgwqDCoFJldmVydCAic3BpOiBpbXg6 IEZpeCBmcmVlaW5nIG9mIERNQSBjaGFubmVscyBpZiBzcGlfYml0YmFuZ19zdGFydCgpIGZhaWxz IgoKwqDCoMKgVGhpcyByZXZlcnRzIGNvbW1pdCA5ZTY4ZDk3NGIyZmQ0OTc3ZTg5NmUxNjY2NTZj MzZlMmY4MDI5M2Q2LgoKU3RpbGwgZXhwZXJpZW5jaW5nIHRoZSBzYW1lIGlzc3VlOgoKWyAgICA0 LjMyMjEzMV0gaW52LW1wdTYwMDAtc3BpIHNwaTIuMDogSS9PIEVycm9yIGluIFBJTwpbICAgIDQu MzI5MzUzXSBpbnYtbXB1NjAwMC1zcGkgc3BpMi4wOiBTUEkgdHJhbnNmZXIgZmFpbGVkOiAtMTEw ClsgICAgNC4zOTE1MDRdIHNwaV9tYXN0ZXIgc3BpMjogZmFpbGVkIHRvIHRyYW5zZmVyIG9uZSBt ZXNzYWdlIGZyb20gcXVldWUKCkkgaGF2ZSBjb25maWcgQ09ORklHX1BNPXkuCgoxMy4xMS4yMDIw LCAxNDoyNiwgIkZhYmlvIEVzdGV2YW0iIDxmZXN0ZXZhbUBnbWFpbC5jb20+Ogo+IEhpIE5pa2l0 YSwKPgo+IE9uIEZyaSwgTm92IDEzLCAyMDIwIGF0IDY6MTggQU0gTmlraXRhIFNodWJpbiA8bmlr aXRhLnNodWJpbkBtYXF1ZWZlbC5tZT4gd3JvdGU6Cj4+IMKgSGVsbG8gQ2xhcmssCj4+Cj4+IMKg VGhpcyBwYXRjaCBicmVha3Mgc3BpLWlteCBvbiBpbXg3ZC4KPj4gwqBUb3JhZGV4IENvbGlicmkg aW14N2Qgc3BpIHJlcG9ydHMgd2l0aDoKPj4KPj4gwqDCoMKgwqDCoFsgNC4yNTg0NjhdIGludi1t cHU2MDAwLXNwaSBzcGkyLjA6IEkvTyBFcnJvciBpbiBQSU8KPj4gwqDCoMKgwqDCoFsgNC4yNjQy NjldIGludi1tcHU2MDAwLXNwaSBzcGkyLjA6IFNQSSB0cmFuc2ZlciBmYWlsZWQ6IC0xMTAKPj4g wqDCoMKgwqDCoFsgNC4yNjQzMDVdIHNwaV9tYXN0ZXIgc3BpMjogZmFpbGVkIHRvIHRyYW5zZmVy IG9uZSBtZXNzYWdlIGZyb20gcXVldWUKPj4KPj4gwqBXZSBhcmUgdXNpbmcgc3BpLWlteCB3aXRo IGRtYS4KPj4KPj4gwqBSZXZlcnRpbmcgeW91ciBwYXRjaCBmaXhlcyB0aGlzIGlzc3VlLgo+Pgo+ PiDCoFRoZSBiYXNlbGluZSBjb21taXQgOTUxY2JiYzM4NmZmMDFiNTBkYTRmNDYzODdlOTk0ZTgx ZDlhYjQzMSAodGFnOiB2NS45LjgsIHN0YWJsZS9saW51eC01LjkueSkKPj4KPj4gwqBDb3VsZCB5 b3UgcGxlYXNlIGdpdmUgc29tZSBjb21tZW50cyBvbiB0aGlzIGlzc3VlID8KPgo+IENvdWxkIHlv dSBwbGVhc2UgdHJ5IHRoaXMgcGF0Y2ggZnJvbSBTYXNjaGE/Cj4gaHR0cHM6Ly9sa21sLm9yZy9s a21sLzIwMjAvMTAvMTIvOTgxCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==