From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E2DCC32750 for ; Fri, 2 Aug 2019 15:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8B91204EC for ; Fri, 2 Aug 2019 15:18:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730124AbfHBPSy (ORCPT ); Fri, 2 Aug 2019 11:18:54 -0400 Received: from mga12.intel.com ([192.55.52.136]:11592 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727599AbfHBPSy (ORCPT ); Fri, 2 Aug 2019 11:18:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 08:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,338,1559545200"; d="scan'208";a="175610387" Received: from vivekcha-mobl1.amr.corp.intel.com (HELO [10.251.131.115]) ([10.251.131.115]) by orsmga003.jf.intel.com with ESMTP; 02 Aug 2019 08:18:52 -0700 Subject: Re: [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE To: Vinod Koul Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com, Sanyog Kale References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-10-pierre-louis.bossart@linux.intel.com> <20190802120319.GL12733@vkoul-mobl.Dlink> From: Pierre-Louis Bossart Message-ID: <71786692-7bdc-d8f2-676a-b2e955675474@linux.intel.com> Date: Fri, 2 Aug 2019 10:18:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190802120319.GL12733@vkoul-mobl.Dlink> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/19 7:03 AM, Vinod Koul wrote: > On 25-07-19, 18:40, Pierre-Louis Bossart wrote: > >> int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns) >> { >> - int ret; >> - >> _cdns_enable_interrupt(cdns); >> - ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE, >> - CDNS_MCP_CONFIG_UPDATE_BIT); >> - if (ret < 0) >> - dev_err(cdns->dev, "Config update timedout\n"); > > I was expecting cdns_update_config() to be invoked here?? > >> >> - return ret; >> + return 0; > > It would be better if we return a value here a not success always > >> @@ -943,7 +953,10 @@ int sdw_cdns_init(struct sdw_cdns *cdns) >> >> cdns_writel(cdns, CDNS_MCP_CONFIG, val); >> >> - return 0; >> + /* commit changes */ >> + ret = cdns_update_config(cdns); >> + >> + return ret; > > return cdns_update_config() yes, all of this is fixed already.