From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Jose R. Ziviani" <jziviani@suse.de>,
qemu-devel@nongnu.org, Miroslav Rezanina <mrezanin@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org,
richard.henderson@linaro.org
Subject: Re: [PATCH] tcg/arm: Fix tcg_out_vec_op function signature
Date: Wed, 8 Sep 2021 22:21:02 +0200 [thread overview]
Message-ID: <71839203-0d36-1cac-9693-3b195c159b80@amsat.org> (raw)
In-Reply-To: <20210908185338.7927-1-jziviani@suse.de>
On 9/8/21 8:53 PM, Jose R. Ziviani wrote:
> Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op
> for arm is missing. It causes a build error on armv6 and armv7:
>
> tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *'
> {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=]
> const TCGArg *args, const int *const_args)
> ~~~~~~~~~~~~~~^~~~
> ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]'
> {aka 'const unsigned int[16]'}
> const TCGArg args[TCG_MAX_OP_ARGS],
> ~~~~~~~~~~~~~~^~~~
>
> Signed-off-by: Jose R. Ziviani <jziviani@suse.de>
> ---
> tcg/arm/tcg-target.c.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
> index 007ceee68e..e5b4f86841 100644
> --- a/tcg/arm/tcg-target.c.inc
> +++ b/tcg/arm/tcg-target.c.inc
> @@ -2715,7 +2715,8 @@ static const ARMInsn vec_cmp0_insn[16] = {
>
> static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc,
> unsigned vecl, unsigned vece,
> - const TCGArg *args, const int *const_args)
> + const TCGArg args[TCG_MAX_OP_ARGS],
> + const int const_args[TCG_MAX_OP_ARGS])
> {
> TCGType type = vecl + TCG_TYPE_V64;
> unsigned q = vecl;
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-09-08 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 18:53 [PATCH] tcg/arm: Fix tcg_out_vec_op function signature Jose R. Ziviani
2021-09-08 20:21 ` Philippe Mathieu-Daudé [this message]
2021-09-10 12:26 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71839203-0d36-1cac-9693-3b195c159b80@amsat.org \
--to=f4bug@amsat.org \
--cc=jziviani@suse.de \
--cc=mrezanin@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.