From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C214C433EF for ; Sun, 15 May 2022 21:20:04 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L1Zz62bB5z3c80 for ; Mon, 16 May 2022 07:20:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kaod.org (client-ip=178.33.105.233; helo=2.mo552.mail-out.ovh.net; envelope-from=clg@kaod.org; receiver=) X-Greylist: delayed 136137 seconds by postgrey-1.36 at boromir; Mon, 16 May 2022 07:19:36 AEST Received: from 2.mo552.mail-out.ovh.net (2.mo552.mail-out.ovh.net [178.33.105.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L1Zyc6b8fz3bdB for ; Mon, 16 May 2022 07:19:33 +1000 (AEST) Received: from mxplan5.mail.ovh.net (unknown [10.109.146.173]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id D25D026545; Sun, 15 May 2022 21:19:27 +0000 (UTC) Received: from kaod.org (37.59.142.108) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Sun, 15 May 2022 23:19:26 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-108S002c6684bdc-49b2-42b0-ad63-36f164cb272d, 43753C8B2FFFCD567C459F3D30927D04895098CF) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <7187a877-354e-5e79-7ad1-a6e368678002@kaod.org> Date: Sun, 15 May 2022 23:19:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices Content-Language: en-US To: Peter Delevoryas References: <20220513040220.3657135-1-pdel@fb.com> <20220513040220.3657135-3-pdel@fb.com> <443933f2-069f-df96-ec62-76c21fc644b2@kaod.org> <05F5C72F-8424-476C-82B7-7D30BA48CDEB@fb.com> <5CBDFE96-B354-4EE6-BEA3-48E4CC68FBA5@fb.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <5CBDFE96-B354-4EE6-BEA3-48E4CC68FBA5@fb.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.108] X-ClientProxiedBy: DAG4EX2.mxp5.local (172.16.2.32) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 3a68d27b-a6c1-49b8-8af6-5d5475c034d2 X-Ovh-Tracer-Id: 7953075467965926322 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrheefgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeelleeiiefgkeefiedtvdeigeetueetkeffkeelheeugfetteegvdekgfehgffgkeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehjohgvlhesjhhmshdrihgurdgruh X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "zev@bewilderbeest.net" , Andrew Jeffery , Iris Chen , OpenBMC List , Cameron Esfahani via , qemu-arm , Joel Stanley Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" [ ... ] >> The problem is that it is breaking compatibility with previous QEMUs. > > It is? We can still run things the old way too, I specifically > wrote this with the intention that it would support backwards > compatibility. You are right. Let's start with your patchset. We can add the "uart" machine option when the need arises. I have sent a small cleanup of aspeed_soc_get_irq() that should avoid the duplication of the serial init in the different SoC models. Please give it a try. Thanks, C. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5740C433F5 for ; Sun, 15 May 2022 21:20:55 +0000 (UTC) Received: from localhost ([::1]:40624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqLfa-0005UP-RY for qemu-devel@archiver.kernel.org; Sun, 15 May 2022 17:20:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqLeT-0004af-6Z for qemu-devel@nongnu.org; Sun, 15 May 2022 17:19:45 -0400 Received: from 4.mo552.mail-out.ovh.net ([178.33.43.201]:44341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqLeQ-0000gA-RL for qemu-devel@nongnu.org; Sun, 15 May 2022 17:19:44 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.173]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id D25D026545; Sun, 15 May 2022 21:19:27 +0000 (UTC) Received: from kaod.org (37.59.142.108) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Sun, 15 May 2022 23:19:26 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-108S002c6684bdc-49b2-42b0-ad63-36f164cb272d, 43753C8B2FFFCD567C459F3D30927D04895098CF) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <7187a877-354e-5e79-7ad1-a6e368678002@kaod.org> Date: Sun, 15 May 2022 23:19:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices Content-Language: en-US To: Peter Delevoryas CC: Iris Chen , "patrick@stwcx.xyz" , qemu-arm , Cameron Esfahani via , "zev@bewilderbeest.net" , OpenBMC List , Andrew Jeffery , Peter Maydell , Joel Stanley References: <20220513040220.3657135-1-pdel@fb.com> <20220513040220.3657135-3-pdel@fb.com> <443933f2-069f-df96-ec62-76c21fc644b2@kaod.org> <05F5C72F-8424-476C-82B7-7D30BA48CDEB@fb.com> <5CBDFE96-B354-4EE6-BEA3-48E4CC68FBA5@fb.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <5CBDFE96-B354-4EE6-BEA3-48E4CC68FBA5@fb.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.108] X-ClientProxiedBy: DAG4EX2.mxp5.local (172.16.2.32) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 3a68d27b-a6c1-49b8-8af6-5d5475c034d2 X-Ovh-Tracer-Id: 7953075467965926322 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrheefgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgihesthejredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeelleeiiefgkeefiedtvdeigeetueetkeffkeelheeugfetteegvdekgfehgffgkeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehjohgvlhesjhhmshdrihgurdgruh Received-SPF: pass client-ip=178.33.43.201; envelope-from=clg@kaod.org; helo=4.mo552.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" [ ... ] >> The problem is that it is breaking compatibility with previous QEMUs. > > It is? We can still run things the old way too, I specifically > wrote this with the intention that it would support backwards > compatibility. You are right. Let's start with your patchset. We can add the "uart" machine option when the need arises. I have sent a small cleanup of aspeed_soc_get_irq() that should avoid the duplication of the serial init in the different SoC models. Please give it a try. Thanks, C.