From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967378AbdCXTea (ORCPT ); Fri, 24 Mar 2017 15:34:30 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:36356 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967110AbdCXTcm (ORCPT ); Fri, 24 Mar 2017 15:32:42 -0400 From: Andrey Konovalov To: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Konovalov Subject: [PATCH v4 3/9] kasan: change allocation and freeing stack traces headers Date: Fri, 24 Mar 2017 20:32:29 +0100 Message-Id: <7191548e9fda9658cea0d6a2313bc8ba0424e5c4.1490383597.git.andreyknvl@google.com> X-Mailer: git-send-email 2.12.1.578.ge9c3154ca4-goog In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change stack traces headers from: Allocated: PID = 42 to: Allocated by task 42: Makes the report one line shorter and look better. Signed-off-by: Andrey Konovalov --- mm/kasan/report.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index fc0577d15671..382d4d2b9052 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -175,9 +175,9 @@ static void kasan_end_report(unsigned long *flags) kasan_enable_current(); } -static void print_track(struct kasan_track *track) +static void print_track(struct kasan_track *track, const char *prefix) { - pr_err("PID = %u\n", track->pid); + pr_err("%s by task %u:\n", prefix, track->pid); if (track->stack) { struct stack_trace trace; @@ -199,10 +199,8 @@ static void kasan_object_err(struct kmem_cache *cache, void *object) if (!(cache->flags & SLAB_KASAN)) return; - pr_err("Allocated:\n"); - print_track(&alloc_info->alloc_track); - pr_err("Freed:\n"); - print_track(&alloc_info->free_track); + print_track(&alloc_info->alloc_track, "Allocated"); + print_track(&alloc_info->free_track, "Freed"); } void kasan_report_double_free(struct kmem_cache *cache, void *object, -- 2.12.1.578.ge9c3154ca4-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 2539A6B0351 for ; Fri, 24 Mar 2017 15:32:42 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id h188so6342763wma.4 for ; Fri, 24 Mar 2017 12:32:42 -0700 (PDT) Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com. [2a00:1450:400c:c0c::236]) by mx.google.com with ESMTPS id v8si4361033wmb.31.2017.03.24.12.32.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2017 12:32:40 -0700 (PDT) Received: by mail-wr0-x236.google.com with SMTP id u1so7987785wra.2 for ; Fri, 24 Mar 2017 12:32:40 -0700 (PDT) From: Andrey Konovalov Subject: [PATCH v4 3/9] kasan: change allocation and freeing stack traces headers Date: Fri, 24 Mar 2017 20:32:29 +0100 Message-Id: <7191548e9fda9658cea0d6a2313bc8ba0424e5c4.1490383597.git.andreyknvl@google.com> In-Reply-To: References: In-Reply-To: References: Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Konovalov Change stack traces headers from: Allocated: PID = 42 to: Allocated by task 42: Makes the report one line shorter and look better. Signed-off-by: Andrey Konovalov --- mm/kasan/report.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index fc0577d15671..382d4d2b9052 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -175,9 +175,9 @@ static void kasan_end_report(unsigned long *flags) kasan_enable_current(); } -static void print_track(struct kasan_track *track) +static void print_track(struct kasan_track *track, const char *prefix) { - pr_err("PID = %u\n", track->pid); + pr_err("%s by task %u:\n", prefix, track->pid); if (track->stack) { struct stack_trace trace; @@ -199,10 +199,8 @@ static void kasan_object_err(struct kmem_cache *cache, void *object) if (!(cache->flags & SLAB_KASAN)) return; - pr_err("Allocated:\n"); - print_track(&alloc_info->alloc_track); - pr_err("Freed:\n"); - print_track(&alloc_info->free_track); + print_track(&alloc_info->alloc_track, "Allocated"); + print_track(&alloc_info->free_track, "Freed"); } void kasan_report_double_free(struct kmem_cache *cache, void *object, -- 2.12.1.578.ge9c3154ca4-goog -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org