All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] iputils: set the permissions with IPUTILS_PERMISSIONS
Date: Mon, 10 Jun 2019 23:26:37 +0200	[thread overview]
Message-ID: <7191f609-e5d8-7bd6-77ca-83296f96d0f1@mind.be> (raw)
In-Reply-To: <20190610200645.GA10261@x230>



On 10/06/2019 22:06, Petr Vorel wrote:
> Hi Arnout,
> 
>>  Applied to master, thanks. I updated the commit message a little.
> Thanks! You've been faster, I might try to think about setcap (xattr) use if
> USE_CAP=true, and setuid if USE_CAP=false.

 Great!

> Is there an easy way to detect
> iso9660 usage?

 BR2_TARGET_ROOTFS_ISO9660 of course. Well, that one is special actually because
in case of BR2_TARGET_ROOTFS_INITRAMFS or BR2_TARGET_ROOTFS_ISO9660_INITRD, the
rootfs is not actually stored in the iso9660.

 But I don't know which other filesystems lack support for xattrs.

 So maybe just assume the filesystem supports xattrs, we can fix things later if
needed.

> (+ setcap being available on host).

 setcap can't be used, since setting xattrs can only be done by root and we're
not root while building. It could be used when running in a fakeroot
environment, but I believe fakeroot is a bit flakey when it comes to
capabilities. So the appropriate xattrs should instead be set with
IPUTILS_PERMISSIONS.

 Regards,
 Arnout


> I'm not aware any other xattr limitations thatn iso9660.
> 
>>> it'd be great also create symlink ping -> ping6, but don't know how.
> 
>>  This can be done with a post-install hook.
> Thanks, I'll do it in separate patch sometimes this week.
> 
>>  Also, the bump to s20190515 should not have removed the traceroute6 program.
>> Could you make a second patch that adds it back?
> Sure, I'll try to do it this week.
> 
>>  Regards,
>>  Arnout
> 
> Kind regards,
> Petr
> 

  reply	other threads:[~2019-06-10 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-09 23:07 [Buildroot] [PATCH 1/1] iputils: set the permissions with IPUTILS_PERMISSIONS Petr Vorel
2019-06-10 13:45 ` Arnout Vandecappelle
2019-06-10 20:06   ` Petr Vorel
2019-06-10 21:26     ` Arnout Vandecappelle [this message]
2019-06-13 19:37       ` Peter Korsgaard
2019-06-14 16:24         ` Petr Vorel
2019-06-18 12:45           ` Peter Korsgaard
2019-06-18 20:52             ` Petr Vorel
2019-06-18 21:31               ` Arnout Vandecappelle
2019-06-19  5:01                 ` Petr Vorel
2019-06-19  6:50                   ` Arnout Vandecappelle
2019-06-19  6:52                     ` Petr Vorel
2019-06-19  7:11                     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7191f609-e5d8-7bd6-77ca-83296f96d0f1@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.