From mboxrd@z Thu Jan 1 00:00:00 1970 From: Edward Cree Subject: Re: [PATCH bpf-next] bpf/verifier: properly clear union members after a ctx read Date: Wed, 5 Sep 2018 14:47:22 +0100 Message-ID: <719de66a-0cd4-262a-d2d9-578df3a3fdca@solarflare.com> References: <0b724ba4-9ddf-e635-0bd5-201658355cf5@solarflare.com> <20180905022323.6lkmq2kmv5ejwy3c@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: , , To: Alexei Starovoitov Return-path: Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:41136 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbeIESRr (ORCPT ); Wed, 5 Sep 2018 14:17:47 -0400 In-Reply-To: <20180905022323.6lkmq2kmv5ejwy3c@ast-mbp.dhcp.thefacebook.com> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 05/09/18 03:23, Alexei Starovoitov wrote: > So would you agree it's fair to add > Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") > ? Sure.  Though I don't think it needs backporting, as it's a conservative  bug (i.e. it merely prevents pruning, but that's safe security-wise). > How about patch like the following: > ------------ > From 422fd975ed78645ab67d2eb50ff6e1ff6fb3de32 Mon Sep 17 00:00:00 2001 > From: Alexei Starovoitov > Date: Tue, 4 Sep 2018 19:13:44 -0700 > Subject: [PATCH] bpf/verifier: fix verifier instability > > Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") > Debugged-by: Edward Cree > Signed-off-by: Alexei Starovoitov Acked-by: Edward Cree