From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAAFC433DB for ; Fri, 19 Feb 2021 07:38:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A884064EC4 for ; Fri, 19 Feb 2021 07:38:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbhBSHhp (ORCPT ); Fri, 19 Feb 2021 02:37:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhBSHhn (ORCPT ); Fri, 19 Feb 2021 02:37:43 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD247C061574 for ; Thu, 18 Feb 2021 23:37:02 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id y7so13120368lji.7 for ; Thu, 18 Feb 2021 23:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hMFTSQVEQdn8VWL0ezmTYZhJ794Avz6LQ2YGElVmR+g=; b=J5ZjRaRYv9jAGNuog88pH01utfrJHP9eb8F+rg+agHiWogWsXTJTbBzOHIRFC/d8uD UANShOhkCnFg6wLMZ3m7ZZ07bII2n5QrFVzL/KK0DTMHuee2ePW9mzkcueGnamJciNCw 7nKAlAs5ljEWGeAU/8XQQY6lCbODrn03KxYVo6UF2T1gLY836OQXIGxtZjBGTspcAXmJ IZ/AekqQaJkb6prwgBj9YmZnYcreUGxvStvxlpafSWHMlmB4yLPSBe1fSbtmlDaIul4P ukMo/KsVgwUd2Cx4FwF+ndys5Q4pvQw2asQlxzu3LS/1g4ua+3/g7EvCQLdzhbU7odi7 9fDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hMFTSQVEQdn8VWL0ezmTYZhJ794Avz6LQ2YGElVmR+g=; b=KPOqKDa/rwOgTzcF4i8DeFLG19txJzIeLPMHPKtkgQKqx6b78bLDV1IyPurXospv8l 80neAy7Qo40LHri/roOVEo0llKQyCXiAn/hOxcjzB/310GCDK6uebtrc1kjPpNyoaDsS hOataucaTrI1MVuSz61lcucdHGLDkhLlYtF3W/uvE2KgVWXGQs0Y7kJg5yIB62cQaf6a TyfnvkVbMyakA0HtD+KBCYaE3mzZ0O5u8681E43OIGMXElDRfdEo/7ADOMedII/UKAwL kUrt7GtEhREymoX8S7E1CAadb5HaOgWbba0vYfHUHU5qfwOgUlUHXDkBV+2B/6bKwzJX ZO7g== X-Gm-Message-State: AOAM533BtT7J5i3MJUZjmwLxXYUpjbzKqmfCF9soFLfFZUSt0N6hpMqf 7EnxnhQm00tLoallMEKEb8Y= X-Google-Smtp-Source: ABdhPJw88JAS94euyyb7uOlXgZYpRNzmJje7834JAO9tSY5FyJTv314ZupV4vwoS+s7zRSY5WelwFA== X-Received: by 2002:a2e:878a:: with SMTP id n10mr4719780lji.418.1613720221307; Thu, 18 Feb 2021 23:37:01 -0800 (PST) Received: from [192.168.0.160] (10.177.smarthome.spb.ru. [109.71.177.10]) by smtp.gmail.com with ESMTPSA id c18sm842938lft.258.2021.02.18.23.37.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Feb 2021 23:37:00 -0800 (PST) Subject: Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c To: Greg Kroah-Hartman References: <20210217154255.112115-1-pritthijit.nath@icloud.com> Cc: devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" , Dan Carpenter , Pritthijit Nath From: Ivan Safonov Message-ID: <71a79d2e-6f03-c2c6-738a-8b862f52e48f@gmail.com> Date: Fri, 19 Feb 2021 10:37:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210217154255.112115-1-pritthijit.nath@icloud.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote: > This change fixes a sparse warning "incorrect type in argument 1 > (different address spaces)". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/wlan-ng/p80211netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c > index 6f9666dc0277..70570e8a5ad2 100644 > --- a/drivers/staging/wlan-ng/p80211netdev.c > +++ b/drivers/staging/wlan-ng/p80211netdev.c > @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, > goto bail; > } > > - msgbuf = memdup_user(req->data, req->len); > + msgbuf = memdup_user((void __user *)req->data, req->len); > if (IS_ERR(msgbuf)) { > result = PTR_ERR(msgbuf); > goto bail; > Reviewed-by: Ivan Safonov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF80AC433E0 for ; Fri, 19 Feb 2021 07:37:06 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CD7C6186A for ; Fri, 19 Feb 2021 07:37:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CD7C6186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id F260787436; Fri, 19 Feb 2021 07:37:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kSbQuUZiFnrK; Fri, 19 Feb 2021 07:37:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 85D878742C; Fri, 19 Feb 2021 07:37:05 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 99E6B1BF321 for ; Fri, 19 Feb 2021 07:37:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9688F8742C for ; Fri, 19 Feb 2021 07:37:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5fdG8zbYx4T2 for ; Fri, 19 Feb 2021 07:37:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by hemlock.osuosl.org (Postfix) with ESMTPS id 64F3F873E6 for ; Fri, 19 Feb 2021 07:37:03 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id g1so9265612ljj.13 for ; Thu, 18 Feb 2021 23:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hMFTSQVEQdn8VWL0ezmTYZhJ794Avz6LQ2YGElVmR+g=; b=J5ZjRaRYv9jAGNuog88pH01utfrJHP9eb8F+rg+agHiWogWsXTJTbBzOHIRFC/d8uD UANShOhkCnFg6wLMZ3m7ZZ07bII2n5QrFVzL/KK0DTMHuee2ePW9mzkcueGnamJciNCw 7nKAlAs5ljEWGeAU/8XQQY6lCbODrn03KxYVo6UF2T1gLY836OQXIGxtZjBGTspcAXmJ IZ/AekqQaJkb6prwgBj9YmZnYcreUGxvStvxlpafSWHMlmB4yLPSBe1fSbtmlDaIul4P ukMo/KsVgwUd2Cx4FwF+ndys5Q4pvQw2asQlxzu3LS/1g4ua+3/g7EvCQLdzhbU7odi7 9fDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hMFTSQVEQdn8VWL0ezmTYZhJ794Avz6LQ2YGElVmR+g=; b=RLmOTgEp/vgqTj7ILNL13hv9WOhhK7UF7mEkCm5st+u2krtS6tDlEhYxDeyW/rxtMK YoAWbEOlVJzR49ptGxi4qV8NX5cIBpGfEVjXryfcH4+x1tdFb/p2ZMGbowIF/W7HaT2t lHTtzeGRBw5BnUsolcnlJsCgQQbACgybOEFhiy3orovG9zbHxd+RNsCWLVhuBpxZ5ON5 5PU5iXJU9hE8I37hy1mOq+ODDMyR6DIgTUffwVxCD3IbABvW5KIhbJB3KvvbQrMK9NlZ hyCus3GB72Zll/JIkJpAkU+10GfVKW7jp1VXCRbf8cjqTFxrXOLBHQ2hcF7RZWVkY09V dXZg== X-Gm-Message-State: AOAM530WHiTrYS3cKvu9CG6JOPmaLBhaD53oOqeLTO26LPwJqN4zFfFE I9D3AgymflLmiHVu80CWhZo= X-Google-Smtp-Source: ABdhPJw88JAS94euyyb7uOlXgZYpRNzmJje7834JAO9tSY5FyJTv314ZupV4vwoS+s7zRSY5WelwFA== X-Received: by 2002:a2e:878a:: with SMTP id n10mr4719780lji.418.1613720221307; Thu, 18 Feb 2021 23:37:01 -0800 (PST) Received: from [192.168.0.160] (10.177.smarthome.spb.ru. [109.71.177.10]) by smtp.gmail.com with ESMTPSA id c18sm842938lft.258.2021.02.18.23.37.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Feb 2021 23:37:00 -0800 (PST) Subject: Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c To: Greg Kroah-Hartman References: <20210217154255.112115-1-pritthijit.nath@icloud.com> From: Ivan Safonov Message-ID: <71a79d2e-6f03-c2c6-738a-8b862f52e48f@gmail.com> Date: Fri, 19 Feb 2021 10:37:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210217154255.112115-1-pritthijit.nath@icloud.com> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Pritthijit Nath , "linux-kernel@vger.kernel.org" , Dan Carpenter Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 2/17/21 6:42 PM, pritthijit.nath at icloud.com (Pritthijit Nath) wrote: > This change fixes a sparse warning "incorrect type in argument 1 > (different address spaces)". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/wlan-ng/p80211netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c > index 6f9666dc0277..70570e8a5ad2 100644 > --- a/drivers/staging/wlan-ng/p80211netdev.c > +++ b/drivers/staging/wlan-ng/p80211netdev.c > @@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, > goto bail; > } > > - msgbuf = memdup_user(req->data, req->len); > + msgbuf = memdup_user((void __user *)req->data, req->len); > if (IS_ERR(msgbuf)) { > result = PTR_ERR(msgbuf); > goto bail; > Reviewed-by: Ivan Safonov _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel