From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8ED9C6FD1F for ; Thu, 16 Mar 2023 07:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbjCPHmd (ORCPT ); Thu, 16 Mar 2023 03:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjCPHma (ORCPT ); Thu, 16 Mar 2023 03:42:30 -0400 X-Greylist: delayed 122 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 16 Mar 2023 00:42:29 PDT Received: from wrqvtbkv.outbound-mail.sendgrid.net (wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B5526A9E6 for ; Thu, 16 Mar 2023 00:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=mime-version:subject:references:from:in-reply-to:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=ZWwGTHexF6h20HWK4/YZaywEOo9OIk01UmuCZ40Dnr0=; b=AC/8Lf21I8hh2e+1LlOiZsfEQJdSnnRFdU+qOunRG0NfscVXCnB0F4IGSuqCV1DHQUAE uFwcKBIB5FuyFySW5kIY182bv+W7F1b/EoMCe+1izR4m4NSyzBbS0S5+cCuRRB0Q/reI8A n8LLC4QCxjEklcCHCifOeMTWfKKlOCrfeOtbCm/xOzDYqBfa2K/EviXLUc8NiJ2R/NfZAV WfqDpP9uBRqWl36Fna/SZVx9dZLmNEXZEy8qUVAgD2qH2VEe0Y63cB09OKlrohqDq33QIe /xQn0tNPNGwWiM5YCcv9REagYEgyXc4gSSwj1qLLH2HBfPNflUJfWoRnzhx/aTWg== Received: by filterdrecv-7946957d94-r22tt with SMTP id filterdrecv-7946957d94-r22tt-1-6412C72D-2B 2023-03-16 07:37:18.137528517 +0000 UTC m=+1929878.570872038 Received: from [192.168.1.50] (unknown) by geopod-ismtpd-5 (SG) with ESMTP id cGqmaXWQSM-1ucf0-jjlAQ Thu, 16 Mar 2023 07:37:17.573 +0000 (UTC) Message-ID: <71b16513-49b1-d9b3-b0b9-4c47e68563ba@kwiboo.se> Date: Thu, 16 Mar 2023 07:37:18 +0000 (UTC) MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S References: <20230315160228.2362-1-cnsztl@gmail.com> <20230315160228.2362-5-cnsztl@gmail.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h8fP5Wx2WYJ38D5dU?= =?us-ascii?Q?wcR+6Srt3JMfPlR6UGX3NWLrZR0xg25ke7YP8l7?= =?us-ascii?Q?a57FER1y1AHZBnD4zO+alVSlLkO7N5AfHJkJjWq?= =?us-ascii?Q?un4zVTJWoOhCVicYkSRQToOZx5MZ2SI60PgnnlJ?= =?us-ascii?Q?lApu5uPxEI2jVw1ZYXhVySx8TObO1bg1XCG191?= To: Tianling Shen , Vasily Khoruzhick Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jagan Teki , Peter Geis , Andy Yan , Brian Norris , Chris Morgan , Sebastian Reichel , Andrew Lunn , Michael Riesch , Maya Matuszczyk , Andrew Powers-Holmes , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tianling, On 2023-03-16 06:34, Tianling Shen wrote: > Hi Vasily, > > On Thu, Mar 16, 2023 at 8:16 AM Vasily Khoruzhick wrote: >> >> On Wed, Mar 15, 2023 at 9:02 AM Tianling Shen wrote: >>> >>> - Changed phy-mode to rgmii. >>> >>> - Fixed pull type in pinctrl for gmac0. >>> >>> - Removed duplicate properties in mdio node. >>> These properties are defined in the gmac0 node already. >>> >>> Signed-off-by: Tianling Shen >>> --- >>> arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >>> index e9adf5e66529..2a1118f15c29 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >>> @@ -57,7 +57,7 @@ >>> assigned-clock-rates = <0>, <125000000>; >>> clock_in_out = "output"; >>> phy-handle = <&rgmii_phy0>; >>> - phy-mode = "rgmii-id"; >>> + phy-mode = "rgmii"; >>> pinctrl-names = "default"; >>> pinctrl-0 = <&gmac0_miim >>> &gmac0_tx_bus2 >>> @@ -79,9 +79,6 @@ >>> reg = <1>; >>> pinctrl-0 = <ð_phy0_reset_pin>; >>> pinctrl-names = "default"; >>> - reset-assert-us = <10000>; >>> - reset-deassert-us = <50000>; >>> - reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; >> >> Hmm, I don't see RK_PC4 being used anywhere else. gmac0 has RK_PC5 as > > Yes, it's a typo, it should be RK_RC5. > >> snsp,reset-gpio. So it essentially drops reset for the PHY. Is it >> expected? > > snsp,reset-gpio defined reset already, so we don't need to set it here again. > > --- > > snsp,reset-gpio is the legacy binding, but I still have no idea why > reset-gpios doesn't work, > the dwmac driver will fail to lookup phy: > > [ 10.398514] rk_gmac-dwmac fe2a0000.ethernet eth0: no phy found > [ 10.399061] rk_gmac-dwmac fe2a0000.ethernet eth0: __stmmac_open: > Cannot attach to PHY (error: -19) > > Any ideas would be appreciated. Generic ethernet phy driver is not resetting the phy in the same way that snsp,reset-gpio does, please see top two commits at [1]. I have been meaning to send that out as an RFC but I got stuck in a u-boot rabbit hole, and I also do not know what the correct way to fix this would be, so I played with both device tree and code changes. Will prioritize this and send out a RFC later today. [1] https://github.com/Kwiboo/linux-rockchip/commits/rk3568-eth-phy-reset Regards, Jonas > > Thanks, > Tianling. > >> >>> }; >>> }; >>> >>> @@ -115,7 +112,7 @@ >>> &pinctrl { >>> gmac0 { >>> eth_phy0_reset_pin: eth-phy0-reset-pin { >>> - rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_down>; >>> + rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_up>; >>> }; >>> }; >>> >>> -- >>> 2.17.1 >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C836BC6FD1F for ; Thu, 16 Mar 2023 07:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:From:References: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ec18ymHL14dtru9sDASJVZj1bAJwEimiCxkACdolGE=; b=DUGX3FcLDEGGOd KiO2YfCLFMxQl3OC3CeXhefjJDTrCk5sExZG/fA8lZ5vE32G4E5y2IIWbIW+CR+RDalhim18wpqxd 7VJBTcu3rQo7a2gCh5r11QAlG+qZSkoOdppTECVPSmXtXqyeMmqCwex30jcOWvFZuPdYUPCmrDh9D wrVm5Y0ylxfooc2rWtbjF7MMpV+VaJIDUSZse+AmCMS9tA7ZIQaNestYE593N1wUY6PO+bhZkGIR3 nk/3Rn+L4eV35Nb9eDbcAFrJWnY34ZcTMSq7CmUMJcyaTGEDWh1LbEMjHpyztbbyZT/7XeYGiA5UA FDjVQlZlTs/fNVMXHU1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pciG8-00FXeG-2r; Thu, 16 Mar 2023 07:42:48 +0000 Received: from wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pciG4-00FXcx-1v for linux-rockchip@lists.infradead.org; Thu, 16 Mar 2023 07:42:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=mime-version:subject:references:from:in-reply-to:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=ZWwGTHexF6h20HWK4/YZaywEOo9OIk01UmuCZ40Dnr0=; b=AC/8Lf21I8hh2e+1LlOiZsfEQJdSnnRFdU+qOunRG0NfscVXCnB0F4IGSuqCV1DHQUAE uFwcKBIB5FuyFySW5kIY182bv+W7F1b/EoMCe+1izR4m4NSyzBbS0S5+cCuRRB0Q/reI8A n8LLC4QCxjEklcCHCifOeMTWfKKlOCrfeOtbCm/xOzDYqBfa2K/EviXLUc8NiJ2R/NfZAV WfqDpP9uBRqWl36Fna/SZVx9dZLmNEXZEy8qUVAgD2qH2VEe0Y63cB09OKlrohqDq33QIe /xQn0tNPNGwWiM5YCcv9REagYEgyXc4gSSwj1qLLH2HBfPNflUJfWoRnzhx/aTWg== Received: by filterdrecv-7946957d94-r22tt with SMTP id filterdrecv-7946957d94-r22tt-1-6412C72D-2B 2023-03-16 07:37:18.137528517 +0000 UTC m=+1929878.570872038 Received: from [192.168.1.50] (unknown) by geopod-ismtpd-5 (SG) with ESMTP id cGqmaXWQSM-1ucf0-jjlAQ Thu, 16 Mar 2023 07:37:17.573 +0000 (UTC) Message-ID: <71b16513-49b1-d9b3-b0b9-4c47e68563ba@kwiboo.se> Date: Thu, 16 Mar 2023 07:37:18 +0000 (UTC) MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S References: <20230315160228.2362-1-cnsztl@gmail.com> <20230315160228.2362-5-cnsztl@gmail.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h8fP5Wx2WYJ38D5dU?= =?us-ascii?Q?wcR+6Srt3JMfPlR6UGX3NWLrZR0xg25ke7YP8l7?= =?us-ascii?Q?a57FER1y1AHZBnD4zO+alVSlLkO7N5CS8jouvNq?= =?us-ascii?Q?X4ZPd9hhEFNYblsqd7X6zfUlgWjLEEYY1OvWiTx?= =?us-ascii?Q?xvpiizuDFF+MDNprZzdRvnmInh5RcGbJJGy8VuS?= =?us-ascii?Q?aHnHqM2ZOUNxrYk0ONG=2Fw=3D=3D?= To: Tianling Shen , Vasily Khoruzhick Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jagan Teki , Peter Geis , Andy Yan , Brian Norris , Chris Morgan , Sebastian Reichel , Andrew Lunn , Michael Riesch , Maya Matuszczyk , Andrew Powers-Holmes , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_004244_766589_FA6670A5 X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgVGlhbmxpbmcsCk9uIDIwMjMtMDMtMTYgMDY6MzQsIFRpYW5saW5nIFNoZW4gd3JvdGU6Cj4g SGkgVmFzaWx5LAo+IAo+IE9uIFRodSwgTWFyIDE2LCAyMDIzIGF0IDg6MTbigK9BTSBWYXNpbHkg S2hvcnV6aGljayA8YW5hcnNvdWxAZ21haWwuY29tPiB3cm90ZToKPj4KPj4gT24gV2VkLCBNYXIg MTUsIDIwMjMgYXQgOTowMuKAr0FNIFRpYW5saW5nIFNoZW4gPGNuc3p0bEBnbWFpbC5jb20+IHdy b3RlOgo+Pj4KPj4+IC0gQ2hhbmdlZCBwaHktbW9kZSB0byByZ21paS4KPj4+Cj4+PiAtIEZpeGVk IHB1bGwgdHlwZSBpbiBwaW5jdHJsIGZvciBnbWFjMC4KPj4+Cj4+PiAtIFJlbW92ZWQgZHVwbGlj YXRlIHByb3BlcnRpZXMgaW4gbWRpbyBub2RlLgo+Pj4gICBUaGVzZSBwcm9wZXJ0aWVzIGFyZSBk ZWZpbmVkIGluIHRoZSBnbWFjMCBub2RlIGFscmVhZHkuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTog VGlhbmxpbmcgU2hlbiA8Y25zenRsQGdtYWlsLmNvbT4KPj4+IC0tLQo+Pj4gIGFyY2gvYXJtNjQv Ym9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LW5hbm9waS1yNXMuZHRzIHwgNyArKy0tLS0tCj4+PiAg MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjgtbmFub3BpLXI1 cy5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1uYW5vcGktcjVzLmR0 cwo+Pj4gaW5kZXggZTlhZGY1ZTY2NTI5Li4yYTExMThmMTVjMjkgMTAwNjQ0Cj4+PiAtLS0gYS9h cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1uYW5vcGktcjVzLmR0cwo+Pj4gKysr IGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjgtbmFub3BpLXI1cy5kdHMKPj4+ IEBAIC01Nyw3ICs1Nyw3IEBACj4+PiAgICAgICAgIGFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDA+ LCA8MTI1MDAwMDAwPjsKPj4+ICAgICAgICAgY2xvY2tfaW5fb3V0ID0gIm91dHB1dCI7Cj4+PiAg ICAgICAgIHBoeS1oYW5kbGUgPSA8JnJnbWlpX3BoeTA+Owo+Pj4gLSAgICAgICBwaHktbW9kZSA9 ICJyZ21paS1pZCI7Cj4+PiArICAgICAgIHBoeS1tb2RlID0gInJnbWlpIjsKPj4+ICAgICAgICAg cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4+ICAgICAgICAgcGluY3RybC0wID0gPCZnbWFj MF9taWltCj4+PiAgICAgICAgICAgICAgICAgICAgICAmZ21hYzBfdHhfYnVzMgo+Pj4gQEAgLTc5 LDkgKzc5LDYgQEAKPj4+ICAgICAgICAgICAgICAgICByZWcgPSA8MT47Cj4+PiAgICAgICAgICAg ICAgICAgcGluY3RybC0wID0gPCZldGhfcGh5MF9yZXNldF9waW4+Owo+Pj4gICAgICAgICAgICAg ICAgIHBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4+PiAtICAgICAgICAgICAgICAgcmVzZXQt YXNzZXJ0LXVzID0gPDEwMDAwPjsKPj4+IC0gICAgICAgICAgICAgICByZXNldC1kZWFzc2VydC11 cyA9IDw1MDAwMD47Cj4+PiAtICAgICAgICAgICAgICAgcmVzZXQtZ3Bpb3MgPSA8JmdwaW8wIFJL X1BDNCBHUElPX0FDVElWRV9MT1c+Owo+Pgo+PiBIbW0sIEkgZG9uJ3Qgc2VlIFJLX1BDNCBiZWlu ZyB1c2VkIGFueXdoZXJlIGVsc2UuIGdtYWMwIGhhcyBSS19QQzUgYXMKPiAKPiBZZXMsIGl0J3Mg YSB0eXBvLCBpdCBzaG91bGQgYmUgUktfUkM1Lgo+IAo+PiBzbnNwLHJlc2V0LWdwaW8uIFNvIGl0 IGVzc2VudGlhbGx5IGRyb3BzIHJlc2V0IGZvciB0aGUgUEhZLiBJcyBpdAo+PiBleHBlY3RlZD8K PiAKPiBzbnNwLHJlc2V0LWdwaW8gZGVmaW5lZCByZXNldCBhbHJlYWR5LCBzbyB3ZSBkb24ndCBu ZWVkIHRvIHNldCBpdCBoZXJlIGFnYWluLgo+IAo+IC0tLQo+IAo+IHNuc3AscmVzZXQtZ3BpbyBp cyB0aGUgbGVnYWN5IGJpbmRpbmcsIGJ1dCBJIHN0aWxsIGhhdmUgbm8gaWRlYSB3aHkKPiByZXNl dC1ncGlvcyBkb2Vzbid0IHdvcmssCj4gdGhlIGR3bWFjIGRyaXZlciB3aWxsIGZhaWwgdG8gbG9v a3VwIHBoeToKPiAKPiBbICAgMTAuMzk4NTE0XSBya19nbWFjLWR3bWFjIGZlMmEwMDAwLmV0aGVy bmV0IGV0aDA6IG5vIHBoeSBmb3VuZAo+IFsgICAxMC4zOTkwNjFdIHJrX2dtYWMtZHdtYWMgZmUy YTAwMDAuZXRoZXJuZXQgZXRoMDogX19zdG1tYWNfb3BlbjoKPiBDYW5ub3QgYXR0YWNoIHRvIFBI WSAoZXJyb3I6IC0xOSkKPiAKPiBBbnkgaWRlYXMgd291bGQgYmUgYXBwcmVjaWF0ZWQuCgpHZW5l cmljIGV0aGVybmV0IHBoeSBkcml2ZXIgaXMgbm90IHJlc2V0dGluZyB0aGUgcGh5IGluIHRoZSBz YW1lIHdheQp0aGF0IHNuc3AscmVzZXQtZ3BpbyBkb2VzLCBwbGVhc2Ugc2VlIHRvcCB0d28gY29t bWl0cyBhdCBbMV0uCgpJIGhhdmUgYmVlbiBtZWFuaW5nIHRvIHNlbmQgdGhhdCBvdXQgYXMgYW4g UkZDIGJ1dCBJIGdvdCBzdHVjayBpbiBhCnUtYm9vdCByYWJiaXQgaG9sZSwgYW5kIEkgYWxzbyBk byBub3Qga25vdyB3aGF0IHRoZSBjb3JyZWN0IHdheSB0byBmaXgKdGhpcyB3b3VsZCBiZSwgc28g SSBwbGF5ZWQgd2l0aCBib3RoIGRldmljZSB0cmVlIGFuZCBjb2RlIGNoYW5nZXMuCldpbGwgcHJp b3JpdGl6ZSB0aGlzIGFuZCBzZW5kIG91dCBhIFJGQyBsYXRlciB0b2RheS4KClsxXSBodHRwczov L2dpdGh1Yi5jb20vS3dpYm9vL2xpbnV4LXJvY2tjaGlwL2NvbW1pdHMvcmszNTY4LWV0aC1waHkt cmVzZXQKClJlZ2FyZHMsCkpvbmFzCgo+IAo+IFRoYW5rcywKPiBUaWFubGluZy4KPiAKPj4KPj4+ ICAgICAgICAgfTsKPj4+ICB9Owo+Pj4KPj4+IEBAIC0xMTUsNyArMTEyLDcgQEAKPj4+ICAmcGlu Y3RybCB7Cj4+PiAgICAgICAgIGdtYWMwIHsKPj4+ICAgICAgICAgICAgICAgICBldGhfcGh5MF9y ZXNldF9waW46IGV0aC1waHkwLXJlc2V0LXBpbiB7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAg ICByb2NrY2hpcCxwaW5zID0gPDAgUktfUEM0IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX2Rvd24+ Owo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcm9ja2NoaXAscGlucyA9IDwwIFJLX1BDNCBS S19GVU5DX0dQSU8gJnBjZmdfcHVsbF91cD47Cj4+PiAgICAgICAgICAgICAgICAgfTsKPj4+ICAg ICAgICAgfTsKPj4+Cj4+PiAtLQo+Pj4gMi4xNy4xCj4+PgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApM aW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE5E0C6FD1F for ; Thu, 16 Mar 2023 07:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:From:References: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nSbam+cFghEdlSr05GdC9VhMgxCcYUua3rBgM9u3w7g=; b=fUTyA76x0qUCs7 qV9f9xk9G/7gSUOw7VHhkDfud+9Mwpk0uVGNK7tl56xUEnGqL6ZY7zzW2nNa2/ELNfE+H4LegQOIY j8cQPvQfItBlR5Uh72bZTvaM2vq7BIdEzgrBwVpg+eO01mSNvG9+Fk3lVefuOwb54Rb23uYxOrtgk +M01OwZj4i9isO5bU7JDWlreCwC01TODWl8CyOV02LiT9vkfl5CmPDUblmta+a6qfHGNkg7EAM+ek Bwv9SO1PJ4D/JDbOM94nNKzWUb6wX/ZoVirTcpQmBZTMsnyYwmRiWAw8OMEy1U/jWaZDHEA1Epgr/ E2E417jwacf8XGeJDGGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pciG7-00FXdu-36; Thu, 16 Mar 2023 07:42:47 +0000 Received: from wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pciG4-00FXcv-0T for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 07:42:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=mime-version:subject:references:from:in-reply-to:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=ZWwGTHexF6h20HWK4/YZaywEOo9OIk01UmuCZ40Dnr0=; b=AC/8Lf21I8hh2e+1LlOiZsfEQJdSnnRFdU+qOunRG0NfscVXCnB0F4IGSuqCV1DHQUAE uFwcKBIB5FuyFySW5kIY182bv+W7F1b/EoMCe+1izR4m4NSyzBbS0S5+cCuRRB0Q/reI8A n8LLC4QCxjEklcCHCifOeMTWfKKlOCrfeOtbCm/xOzDYqBfa2K/EviXLUc8NiJ2R/NfZAV WfqDpP9uBRqWl36Fna/SZVx9dZLmNEXZEy8qUVAgD2qH2VEe0Y63cB09OKlrohqDq33QIe /xQn0tNPNGwWiM5YCcv9REagYEgyXc4gSSwj1qLLH2HBfPNflUJfWoRnzhx/aTWg== Received: by filterdrecv-7946957d94-r22tt with SMTP id filterdrecv-7946957d94-r22tt-1-6412C72D-2B 2023-03-16 07:37:18.137528517 +0000 UTC m=+1929878.570872038 Received: from [192.168.1.50] (unknown) by geopod-ismtpd-5 (SG) with ESMTP id cGqmaXWQSM-1ucf0-jjlAQ Thu, 16 Mar 2023 07:37:17.573 +0000 (UTC) Message-ID: <71b16513-49b1-d9b3-b0b9-4c47e68563ba@kwiboo.se> Date: Thu, 16 Mar 2023 07:37:18 +0000 (UTC) MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/5] arm64: dts: rockchip: fix gmac support for NanoPi R5S References: <20230315160228.2362-1-cnsztl@gmail.com> <20230315160228.2362-5-cnsztl@gmail.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: X-SG-EID: =?us-ascii?Q?TdbjyGynYnRZWhH+7lKUQJL+ZxmxpowvO2O9SQF5CwCVrYgcwUXgU5DKUU3QxA?= =?us-ascii?Q?fZekEeQsTe+RrMu3cja6a0h8fP5Wx2WYJ38D5dU?= =?us-ascii?Q?wcR+6Srt3JMfPlR6UGX3NWLrZR0xg25ke7YP8l7?= =?us-ascii?Q?a57FER1y1AHZBnD4zO+alVSlLkO7N5ANkTUu57o?= =?us-ascii?Q?JL3esb1HlHcXyMV2+nCmABPxKmaVN9J0v6Vs2L9?= =?us-ascii?Q?Q9wd2xxJ4x7qov79rlz5Tmc=2FP7aQnEnzw8sqze9?= =?us-ascii?Q?zfD9Xk9iGTX=2FhveZirCdA=3D=3D?= To: Tianling Shen , Vasily Khoruzhick Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Jagan Teki , Peter Geis , Andy Yan , Brian Norris , Chris Morgan , Sebastian Reichel , Andrew Lunn , Michael Riesch , Maya Matuszczyk , Andrew Powers-Holmes , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Entity-ID: P7KYpSJvGCELWjBME/J5tg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_004244_320687_47678A3B X-CRM114-Status: GOOD ( 24.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVGlhbmxpbmcsCk9uIDIwMjMtMDMtMTYgMDY6MzQsIFRpYW5saW5nIFNoZW4gd3JvdGU6Cj4g SGkgVmFzaWx5LAo+IAo+IE9uIFRodSwgTWFyIDE2LCAyMDIzIGF0IDg6MTbigK9BTSBWYXNpbHkg S2hvcnV6aGljayA8YW5hcnNvdWxAZ21haWwuY29tPiB3cm90ZToKPj4KPj4gT24gV2VkLCBNYXIg MTUsIDIwMjMgYXQgOTowMuKAr0FNIFRpYW5saW5nIFNoZW4gPGNuc3p0bEBnbWFpbC5jb20+IHdy b3RlOgo+Pj4KPj4+IC0gQ2hhbmdlZCBwaHktbW9kZSB0byByZ21paS4KPj4+Cj4+PiAtIEZpeGVk IHB1bGwgdHlwZSBpbiBwaW5jdHJsIGZvciBnbWFjMC4KPj4+Cj4+PiAtIFJlbW92ZWQgZHVwbGlj YXRlIHByb3BlcnRpZXMgaW4gbWRpbyBub2RlLgo+Pj4gICBUaGVzZSBwcm9wZXJ0aWVzIGFyZSBk ZWZpbmVkIGluIHRoZSBnbWFjMCBub2RlIGFscmVhZHkuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTog VGlhbmxpbmcgU2hlbiA8Y25zenRsQGdtYWlsLmNvbT4KPj4+IC0tLQo+Pj4gIGFyY2gvYXJtNjQv Ym9vdC9kdHMvcm9ja2NoaXAvcmszNTY4LW5hbm9waS1yNXMuZHRzIHwgNyArKy0tLS0tCj4+PiAg MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4+Cj4+PiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjgtbmFub3BpLXI1 cy5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1uYW5vcGktcjVzLmR0 cwo+Pj4gaW5kZXggZTlhZGY1ZTY2NTI5Li4yYTExMThmMTVjMjkgMTAwNjQ0Cj4+PiAtLS0gYS9h cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2OC1uYW5vcGktcjVzLmR0cwo+Pj4gKysr IGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjgtbmFub3BpLXI1cy5kdHMKPj4+ IEBAIC01Nyw3ICs1Nyw3IEBACj4+PiAgICAgICAgIGFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDA+ LCA8MTI1MDAwMDAwPjsKPj4+ICAgICAgICAgY2xvY2tfaW5fb3V0ID0gIm91dHB1dCI7Cj4+PiAg ICAgICAgIHBoeS1oYW5kbGUgPSA8JnJnbWlpX3BoeTA+Owo+Pj4gLSAgICAgICBwaHktbW9kZSA9 ICJyZ21paS1pZCI7Cj4+PiArICAgICAgIHBoeS1tb2RlID0gInJnbWlpIjsKPj4+ICAgICAgICAg cGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4+ICAgICAgICAgcGluY3RybC0wID0gPCZnbWFj MF9taWltCj4+PiAgICAgICAgICAgICAgICAgICAgICAmZ21hYzBfdHhfYnVzMgo+Pj4gQEAgLTc5 LDkgKzc5LDYgQEAKPj4+ICAgICAgICAgICAgICAgICByZWcgPSA8MT47Cj4+PiAgICAgICAgICAg ICAgICAgcGluY3RybC0wID0gPCZldGhfcGh5MF9yZXNldF9waW4+Owo+Pj4gICAgICAgICAgICAg ICAgIHBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4+PiAtICAgICAgICAgICAgICAgcmVzZXQt YXNzZXJ0LXVzID0gPDEwMDAwPjsKPj4+IC0gICAgICAgICAgICAgICByZXNldC1kZWFzc2VydC11 cyA9IDw1MDAwMD47Cj4+PiAtICAgICAgICAgICAgICAgcmVzZXQtZ3Bpb3MgPSA8JmdwaW8wIFJL X1BDNCBHUElPX0FDVElWRV9MT1c+Owo+Pgo+PiBIbW0sIEkgZG9uJ3Qgc2VlIFJLX1BDNCBiZWlu ZyB1c2VkIGFueXdoZXJlIGVsc2UuIGdtYWMwIGhhcyBSS19QQzUgYXMKPiAKPiBZZXMsIGl0J3Mg YSB0eXBvLCBpdCBzaG91bGQgYmUgUktfUkM1Lgo+IAo+PiBzbnNwLHJlc2V0LWdwaW8uIFNvIGl0 IGVzc2VudGlhbGx5IGRyb3BzIHJlc2V0IGZvciB0aGUgUEhZLiBJcyBpdAo+PiBleHBlY3RlZD8K PiAKPiBzbnNwLHJlc2V0LWdwaW8gZGVmaW5lZCByZXNldCBhbHJlYWR5LCBzbyB3ZSBkb24ndCBu ZWVkIHRvIHNldCBpdCBoZXJlIGFnYWluLgo+IAo+IC0tLQo+IAo+IHNuc3AscmVzZXQtZ3BpbyBp cyB0aGUgbGVnYWN5IGJpbmRpbmcsIGJ1dCBJIHN0aWxsIGhhdmUgbm8gaWRlYSB3aHkKPiByZXNl dC1ncGlvcyBkb2Vzbid0IHdvcmssCj4gdGhlIGR3bWFjIGRyaXZlciB3aWxsIGZhaWwgdG8gbG9v a3VwIHBoeToKPiAKPiBbICAgMTAuMzk4NTE0XSBya19nbWFjLWR3bWFjIGZlMmEwMDAwLmV0aGVy bmV0IGV0aDA6IG5vIHBoeSBmb3VuZAo+IFsgICAxMC4zOTkwNjFdIHJrX2dtYWMtZHdtYWMgZmUy YTAwMDAuZXRoZXJuZXQgZXRoMDogX19zdG1tYWNfb3BlbjoKPiBDYW5ub3QgYXR0YWNoIHRvIFBI WSAoZXJyb3I6IC0xOSkKPiAKPiBBbnkgaWRlYXMgd291bGQgYmUgYXBwcmVjaWF0ZWQuCgpHZW5l cmljIGV0aGVybmV0IHBoeSBkcml2ZXIgaXMgbm90IHJlc2V0dGluZyB0aGUgcGh5IGluIHRoZSBz YW1lIHdheQp0aGF0IHNuc3AscmVzZXQtZ3BpbyBkb2VzLCBwbGVhc2Ugc2VlIHRvcCB0d28gY29t bWl0cyBhdCBbMV0uCgpJIGhhdmUgYmVlbiBtZWFuaW5nIHRvIHNlbmQgdGhhdCBvdXQgYXMgYW4g UkZDIGJ1dCBJIGdvdCBzdHVjayBpbiBhCnUtYm9vdCByYWJiaXQgaG9sZSwgYW5kIEkgYWxzbyBk byBub3Qga25vdyB3aGF0IHRoZSBjb3JyZWN0IHdheSB0byBmaXgKdGhpcyB3b3VsZCBiZSwgc28g SSBwbGF5ZWQgd2l0aCBib3RoIGRldmljZSB0cmVlIGFuZCBjb2RlIGNoYW5nZXMuCldpbGwgcHJp b3JpdGl6ZSB0aGlzIGFuZCBzZW5kIG91dCBhIFJGQyBsYXRlciB0b2RheS4KClsxXSBodHRwczov L2dpdGh1Yi5jb20vS3dpYm9vL2xpbnV4LXJvY2tjaGlwL2NvbW1pdHMvcmszNTY4LWV0aC1waHkt cmVzZXQKClJlZ2FyZHMsCkpvbmFzCgo+IAo+IFRoYW5rcywKPiBUaWFubGluZy4KPiAKPj4KPj4+ ICAgICAgICAgfTsKPj4+ICB9Owo+Pj4KPj4+IEBAIC0xMTUsNyArMTEyLDcgQEAKPj4+ICAmcGlu Y3RybCB7Cj4+PiAgICAgICAgIGdtYWMwIHsKPj4+ICAgICAgICAgICAgICAgICBldGhfcGh5MF9y ZXNldF9waW46IGV0aC1waHkwLXJlc2V0LXBpbiB7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAg ICByb2NrY2hpcCxwaW5zID0gPDAgUktfUEM0IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX2Rvd24+ Owo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcm9ja2NoaXAscGlucyA9IDwwIFJLX1BDNCBS S19GVU5DX0dQSU8gJnBjZmdfcHVsbF91cD47Cj4+PiAgICAgICAgICAgICAgICAgfTsKPj4+ICAg ICAgICAgfTsKPj4+Cj4+PiAtLQo+Pj4gMi4xNy4xCj4+PgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK