From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A02D7C07E97 for ; Sat, 3 Jul 2021 08:49:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36D72613FB for ; Sat, 3 Jul 2021 08:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36D72613FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzbKj-0006Np-4v for qemu-devel@archiver.kernel.org; Sat, 03 Jul 2021 04:49:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzbJt-0005jB-KW for qemu-devel@nongnu.org; Sat, 03 Jul 2021 04:48:13 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:44668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzbJs-0003sd-5c for qemu-devel@nongnu.org; Sat, 03 Jul 2021 04:48:13 -0400 Received: by mail-wr1-x434.google.com with SMTP id t15so12102464wry.11 for ; Sat, 03 Jul 2021 01:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F8H3F+XSTiImVumwvmAuDbL5fkYEqRYzkQqfRRnqq0I=; b=ZwlOzQDHCwRoY2Xqeey6wi1SvqDzIo6qSNY+rTCqhKcyvCx2DeVOkI+3ttFe0KtAPk d+wyECY8jhbGHdBl98Kjg1ohAKbcQJqqH8twjrcSt3U9SIgAUWMCpXwvTuumlOMHxZI2 oQBoUYz9dsZdFsxBGyT50+WNKsMxyz+v5oYwSxTSfMJZqLVBgJD9GzW5rRv/bImte6s5 XGXTGq6xnqHnPEDd4gA7T+Mba16880KQI7rcXw0fcSu1vPe6otduq4kfgmnzh4xQTbVP QWAZ8rJhx2oCU/9/XCiw3e+F04CGmfUlZYYWN/XA6ts4n6mglfgx5zbK8nXr/l6Qytoy JEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F8H3F+XSTiImVumwvmAuDbL5fkYEqRYzkQqfRRnqq0I=; b=XTlFI/zibJP+awfc9Sdi27uT9+OaScE507caB+f4NIupt+pDFNi3YNfNJBfLNWWGNI VB8CYSfFePKgXuJf+gIX8g8BrZsPirxsCk4zJsx2MzCHHoGDrWR0o7vTzxZPWhu51X49 xg/afwdVRbtD67LPV1XjvCKb2oNHG/6t670S8b3kJQomof2WPSuLipsDcSrs/Cy3/Mn0 o/X+phYbLEpH4/NwqPvDP0Jvl5wi1Vh5xPCsXQ296mdPhvEO20BsSoP2UBlrpMSWPnky HDq7HO3+zCob/QP+4BwrYlEY9zLPR1H9aw218CMv+4y3E3rKDfqAZOtGArXQVfa86S4G 123g== X-Gm-Message-State: AOAM530hlli6SRN97Z3MedtEDJEhr+zeHuB72UuSXqMBwP1L5pL7kmFR tACopKZmxc/GaS/RXsaRTNw= X-Google-Smtp-Source: ABdhPJxI22fBzB0H05Td7vXYdKZ0xExhJRfO2rk01Di+oyqGqZju4PLXHKhjuOSScTv/aUcBg6D05A== X-Received: by 2002:a5d:498d:: with SMTP id r13mr4121722wrq.379.1625302088997; Sat, 03 Jul 2021 01:48:08 -0700 (PDT) Received: from [192.168.11.95] (pop.92-184-110-177.mobile.abo.orange.fr. [92.184.110.177]) by smtp.gmail.com with ESMTPSA id p18sm1706561wrt.18.2021.07.03.01.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jul 2021 01:48:08 -0700 (PDT) Subject: Re: [PATCH v2 00/10] dp8393x: fixes for MacOS toolbox ROM To: Mark Cave-Ayland , qemu-devel@nongnu.org, hpoussin@reactos.org, aleksandar.rikalo@syrmia.com, aurelien@aurel32.net, jiaxun.yang@flygoat.com, jasowang@redhat.com, fthain@telegraphics.com.au, laurent@vivier.eu References: <20210625065401.30170-1-mark.cave-ayland@ilande.co.uk> <70ea194a-af86-454e-d9cc-494805d953eb@ilande.co.uk> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <71bfbd7d-cd35-4d54-f4a4-1b08a927c2a9@amsat.org> Date: Sat, 3 Jul 2021 10:48:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <70ea194a-af86-454e-d9cc-494805d953eb@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/3/21 8:32 AM, Mark Cave-Ayland wrote: > On 02/07/2021 14:03, Philippe Mathieu-Daudé wrote: > What was the issue with patch 9 "dp8393x: fix CAM descriptor entry > index"? That patch ensures that the CAM index is read from the > descriptor, and not taken from the for() loop i.e. it is unrelated to > register access size. No issue, simply nobody reviewed it and I was not confident enough. > See section 4.1.1 "The Load CAM Command" in the > DP83932C datasheet for more information. I'll have a look. The patch could go via Jason's tree or Trivial then.