From: Martyn Welch <martyn.welch@collabora.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Adam Ford <aford173@gmail.com>,
Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] soc: imx: imx8m-blk-ctrl: fix display clock for LCDIF2 power domain
Date: Fri, 27 May 2022 10:43:11 +0100 [thread overview]
Message-ID: <71d7f10ed242a9342adcaa6d7ba6783a0205f28a.camel@collabora.com> (raw)
In-Reply-To: <20220524073934.319134-1-alexander.stein@ew.tq-group.com>
On Tue, 2022-05-24 at 09:39 +0200, Alexander Stein wrote:
> LCDIF2 has its own display clock, use this one.
>
> Fixes: 07614fed00e9 ("soc: imx: imx8m-blk-ctrl: Add i.MX8MP media
> blk-ctrl")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Tested along with related patches, driving InnoLux G150XNE LVDS panel
attached to NXP i.MX 8M Plus EVK.
Tree: https://gitlab.collabora.com/martyn/linux/-/tree/imx8mp
Tested-by: Martyn Welch <martyn.welch@collabora.com>
> ---
> I noticed this while trying to get LVDS (on LCDIF2) working.
> Apparently
> it is not strictly required, but better to have this right.
>
> drivers/soc/imx/imx8m-blk-ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c
> b/drivers/soc/imx/imx8m-blk-ctrl.c
> index 7f49385ed2f8..7ebc28709e94 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -667,7 +667,7 @@ static const struct imx8m_blk_ctrl_domain_data
> imx8mp_media_blk_ctl_domain_data[
> },
> [IMX8MP_MEDIABLK_PD_LCDIF_2] = {
> .name = "mediablk-lcdif-2",
> - .clk_names = (const char *[]){ "disp1", "apb", "axi",
> },
> + .clk_names = (const char *[]){ "disp2", "apb", "axi",
> },
> .num_clks = 3,
> .gpc_name = "lcdif2",
> .rst_mask = BIT(11) | BIT(12) | BIT(24),
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-27 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:39 [PATCH 1/1] soc: imx: imx8m-blk-ctrl: fix display clock for LCDIF2 power domain Alexander Stein
2022-05-27 5:02 ` paul.elder
2022-05-27 9:43 ` Martyn Welch [this message]
2022-06-12 1:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71d7f10ed242a9342adcaa6d7ba6783a0205f28a.camel@collabora.com \
--to=martyn.welch@collabora.com \
--cc=aford173@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=paul.elder@ideasonboard.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.