All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Simon Ser <contact@emersion.fr>,
	"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
Cc: Stylon Wang <stylon.wang@amd.com>,
	amd-gfx@lists.freedesktop.org, Harry.Wentland@amd.com,
	Rodrigo.Siqueira@amd.com
Subject: Re: [PATCH] drm/amd/display: Fix error handling on waiting for completion
Date: Tue, 26 Oct 2021 18:11:24 +0200	[thread overview]
Message-ID: <71deb3f1-4f46-43a7-98e8-99879d231dd4@daenzer.net> (raw)
In-Reply-To: <P81H3ot388-2r8h9f2D4jqbP7eys1TKtvXWTwXkgEWslTv6PcsQObN_hSX6KaH_MMkhscnt4TFF6B11fqho5Yd2a3q_qS-AUog7vaaylVrA=@emersion.fr>

On 2021-10-26 18:08, Simon Ser wrote:
> On Tuesday, October 26th, 2021 at 18:03, Kazlauskas, Nicholas <nicholas.kazlauskas@amd.com> wrote:
> 
>> If it's just an error in the log without a functional issue then maybe
>> we should downgrade it to a debug statement in the case where it returns
>> -ERESTARTSYS.
>>
>> If this is a functional issue (DRM not automatically retrying the
>> commit?) then maybe we should take a deeper look into the IOCTL itself.
> 
> libdrm handles EINTR but not ERESTARTSYS. So, if the kernel returns ERESTARTSYS
> then Mutter will error out.
> 
> Should the kernel be fixed to return EINTR instead of ERESTARTSYS, or should
> libdrm be fixed to handle ERESTARTSYS?

The kernel is supposed to convert ERESTARTSYS to EINTR when returning to user space (when the kernel can't restart the system call itself), so user space doesn't need to handle the former.


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer

  reply	other threads:[~2021-10-26 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 11:07 [PATCH] drm/amd/display: Fix error handling on waiting for completion Stylon Wang
2021-10-26 13:29 ` Kazlauskas, Nicholas
2021-10-26 15:51 ` Michel Dänzer
2021-10-26 16:03   ` Kazlauskas, Nicholas
2021-10-26 16:08     ` Simon Ser
2021-10-26 16:11       ` Michel Dänzer [this message]
2021-10-27  7:20     ` Christian König
2021-11-01 15:00   ` Wang, Chao-kai (Stylon)
2021-11-03 14:54     ` Michel Dänzer
2021-11-03 14:54       ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71deb3f1-4f46-43a7-98e8-99879d231dd4@daenzer.net \
    --to=michel@daenzer.net \
    --cc=Harry.Wentland@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=contact@emersion.fr \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=stylon.wang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.