From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D746CC4727D for ; Tue, 29 Sep 2020 14:06:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F3AF2145D for ; Tue, 29 Sep 2020 14:06:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730551AbgI2OGx convert rfc822-to-8bit (ORCPT ); Tue, 29 Sep 2020 10:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbgI2OGx (ORCPT ); Tue, 29 Sep 2020 10:06:53 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CC7C061755 for ; Tue, 29 Sep 2020 07:06:52 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNGHF-0008Ih-G2; Tue, 29 Sep 2020 16:06:45 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kNGHE-0001LI-Gy; Tue, 29 Sep 2020 16:06:44 +0200 Message-ID: <71e129112af93a3ba618e8046313cd4b3871a7a8.camel@pengutronix.de> Subject: Re: [PATCH 01/20] media: coda: use semicolons rather than commas to separate statements From: Philipp Zabel To: Julia Lawall Cc: Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , Joe Perches , Thomas Gleixner , kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 29 Sep 2020 16:06:44 +0200 In-Reply-To: <1601385283-26144-2-git-send-email-Julia.Lawall@inria.fr> References: <1601385283-26144-1-git-send-email-Julia.Lawall@inria.fr> <1601385283-26144-2-git-send-email-Julia.Lawall@inria.fr> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-09-29 at 15:14 +0200, Julia Lawall wrote: > Replace commas with semicolons. Commas introduce unnecessary > variability in the code structure and are hard to see. What is done > is essentially described by the following Coccinelle semantic patch > (http://coccinelle.lip6.fr/): > > // > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/media/platform/coda/coda-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > index eeba6c060981..1bb16cc0a823 100644 > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -2861,7 +2861,7 @@ static int coda_register_device(struct coda_dev *dev, int i) > strscpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name)); > vfd->fops = &coda_fops; > vfd->ioctl_ops = &coda_ioctl_ops; > - vfd->release = video_device_release_empty, > + vfd->release = video_device_release_empty; > vfd->lock = &dev->dev_mutex; > vfd->v4l2_dev = &dev->v4l2_dev; > vfd->vfl_dir = VFL_DIR_M2M; > > Thank you, Reviewed-by: Philipp Zabel regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Date: Tue, 29 Sep 2020 14:06:44 +0000 Subject: Re: [PATCH 01/20] media: coda: use semicolons rather than commas to separate statements Message-Id: <71e129112af93a3ba618e8046313cd4b3871a7a8.camel@pengutronix.de> List-Id: References: <1601385283-26144-1-git-send-email-Julia.Lawall@inria.fr> <1601385283-26144-2-git-send-email-Julia.Lawall@inria.fr> In-Reply-To: <1601385283-26144-2-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , Joe Perches , Thomas Gleixner , kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 2020-09-29 at 15:14 +0200, Julia Lawall wrote: > Replace commas with semicolons. Commas introduce unnecessary > variability in the code structure and are hard to see. What is done > is essentially described by the following Coccinelle semantic patch > (http://coccinelle.lip6.fr/): > > // > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/media/platform/coda/coda-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > index eeba6c060981..1bb16cc0a823 100644 > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -2861,7 +2861,7 @@ static int coda_register_device(struct coda_dev *dev, int i) > strscpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name)); > vfd->fops = &coda_fops; > vfd->ioctl_ops = &coda_ioctl_ops; > - vfd->release = video_device_release_empty, > + vfd->release = video_device_release_empty; > vfd->lock = &dev->dev_mutex; > vfd->v4l2_dev = &dev->v4l2_dev; > vfd->vfl_dir = VFL_DIR_M2M; > > Thank you, Reviewed-by: Philipp Zabel regards Philipp