From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FEDC432C3 for ; Fri, 15 Nov 2019 22:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3867820723 for ; Fri, 15 Nov 2019 22:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfKOWqy (ORCPT ); Fri, 15 Nov 2019 17:46:54 -0500 Received: from baldur.buserror.net ([165.227.176.147]:55598 "EHLO baldur.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbfKOWqx (ORCPT ); Fri, 15 Nov 2019 17:46:53 -0500 Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVkKM-0007zt-Nm; Fri, 15 Nov 2019 16:44:31 -0600 Message-ID: <71e4f8797fa6e4a116a6d1cabcb63871d7a0c4e0.camel@buserror.net> From: Scott Wood To: Timur Tabi , Rasmus Villemoes Cc: Qiang Zhao , Li Yang , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , lkml , linux-serial@vger.kernel.org Date: Fri, 15 Nov 2019 16:44:29 -0600 In-Reply-To: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: timur@kernel.org, linux@rasmusvillemoes.dk, qiang.zhao@nxp.com, leoyang.li@nxp.com, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-11-15 at 08:35 -0600, Timur Tabi wrote: > On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > > That would be a separate patch, this patch is only concerned with > > eliminating the implicit assumption of the host being big-endian. And > > there's already been some pushback to adding arch-specific ifdefs (which > > I agree with, but as I responded there see as the lesser evil), so > > unless there's a very good reason to add that complexity, I'd rather not. > > We don't want to encourage people to introduce device trees that don't > have the brg-frequency property in them. Yeah, workarounds like this should be as targeted as possible. If we knew the specific chips/boards on which U-Boot has this problem, then limiting it to those would have been even better (e.g. fix up the device tree from the platform code), but at this point containing the damage to PPC seems like the most reasonable approach. It's not relevant to this specific patch, but it is relevant to a patchset expanding the set of platforms on which this code builds. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4B3C432C3 for ; Fri, 15 Nov 2019 22:49:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBB3720723 for ; Fri, 15 Nov 2019 22:49:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBB3720723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47FD6s1KSKzF6m0 for ; Sat, 16 Nov 2019 09:49:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=buserror.net (client-ip=165.227.176.147; helo=baldur.buserror.net; envelope-from=oss@buserror.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=buserror.net Received: from baldur.buserror.net (baldur.buserror.net [165.227.176.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47FD4C45RczF3pC for ; Sat, 16 Nov 2019 09:46:50 +1100 (AEDT) Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVkKM-0007zt-Nm; Fri, 15 Nov 2019 16:44:31 -0600 Message-ID: <71e4f8797fa6e4a116a6d1cabcb63871d7a0c4e0.camel@buserror.net> From: Scott Wood To: Timur Tabi , Rasmus Villemoes Date: Fri, 15 Nov 2019 16:44:29 -0600 In-Reply-To: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: timur@kernel.org, linux@rasmusvillemoes.dk, qiang.zhao@nxp.com, leoyang.li@nxp.com, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkml , Li Yang , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2019-11-15 at 08:35 -0600, Timur Tabi wrote: > On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > > That would be a separate patch, this patch is only concerned with > > eliminating the implicit assumption of the host being big-endian. And > > there's already been some pushback to adding arch-specific ifdefs (which > > I agree with, but as I responded there see as the lesser evil), so > > unless there's a very good reason to add that complexity, I'd rather not. > > We don't want to encourage people to introduce device trees that don't > have the brg-frequency property in them. Yeah, workarounds like this should be as targeted as possible. If we knew the specific chips/boards on which U-Boot has this problem, then limiting it to those would have been even better (e.g. fix up the device tree from the platform code), but at this point containing the damage to PPC seems like the most reasonable approach. It's not relevant to this specific patch, but it is relevant to a patchset expanding the set of platforms on which this code builds. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0EAC432C3 for ; Fri, 15 Nov 2019 22:49:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2ECA20730 for ; Fri, 15 Nov 2019 22:49:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U0l/Vbab" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2ECA20730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=buserror.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Mime-Version:References: In-Reply-To:Date:To:From:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1UIS3CETAh2eZaVa3bm3qWGKi0oCO+hYuWEu3WvgC8g=; b=U0l/Vbab7WX+DP SAr+JERKZ8U+OtKUV3WoBwIoZKgnNBHFUXyF2ibUPUCPdfsXOj7JCZUU15BGURrnxK1piy/cDtgWz BSBV1R2yF5RfkpzVnZWGcZUvXNDOxvkTFPm9SBhBGs0rWo6tMpQKqiGAi4098Qz2QQrVLwN/j9UEp njLz++LxCV0sQbuTgoq30aEknyTvi8djeY8nl9/Ossvpr03hxmKeyjPKOxsmd3bkNXKGf2Ebeydv/ Kv1hvD77Ccgejx2/KwbAh0dQN6Zso5d4XgpzSTRvkAxGRqvmV1G3+EJxMbicfXb+KjZcocXBWzL3J T3YKMxY9gywqcIyMa6Gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVkOi-0008JI-Jx; Fri, 15 Nov 2019 22:49:00 +0000 Received: from baldur.buserror.net ([165.227.176.147]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVkOf-0008Ij-EM for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 22:48:58 +0000 Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVkKM-0007zt-Nm; Fri, 15 Nov 2019 16:44:31 -0600 Message-ID: <71e4f8797fa6e4a116a6d1cabcb63871d7a0c4e0.camel@buserror.net> From: Scott Wood To: Timur Tabi , Rasmus Villemoes Date: Fri, 15 Nov 2019 16:44:29 -0600 In-Reply-To: <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-33-linux@rasmusvillemoes.dk> <9f1a846b-c303-92fa-9620-f492ef940de7@rasmusvillemoes.dk> <02dd5acd-b81e-fde3-028c-16e754e846b5@kernel.org> Organization: Red Hat X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: timur@kernel.org, linux@rasmusvillemoes.dk, qiang.zhao@nxp.com, leoyang.li@nxp.com, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v4 32/47] serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe() X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_144857_547264_00566751 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , lkml , Li Yang , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-11-15 at 08:35 -0600, Timur Tabi wrote: > On 11/15/19 2:01 AM, Rasmus Villemoes wrote: > > That would be a separate patch, this patch is only concerned with > > eliminating the implicit assumption of the host being big-endian. And > > there's already been some pushback to adding arch-specific ifdefs (which > > I agree with, but as I responded there see as the lesser evil), so > > unless there's a very good reason to add that complexity, I'd rather not. > > We don't want to encourage people to introduce device trees that don't > have the brg-frequency property in them. Yeah, workarounds like this should be as targeted as possible. If we knew the specific chips/boards on which U-Boot has this problem, then limiting it to those would have been even better (e.g. fix up the device tree from the platform code), but at this point containing the damage to PPC seems like the most reasonable approach. It's not relevant to this specific patch, but it is relevant to a patchset expanding the set of platforms on which this code builds. -Scott _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel