All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <jgrall@amazon.com>,
	George Dunlap <George.Dunlap@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly
Date: Tue, 12 May 2020 12:00:22 +0100	[thread overview]
Message-ID: <71e63752-b6b0-9578-e79a-0bef30a7c50a@xen.org> (raw)
In-Reply-To: <cabaa3f1-5eca-c7a5-e819-1c7487c4add1@suse.com>

Hi Jan,

On 12/05/2020 11:15, Jan Beulich wrote:
> On 12.05.2020 12:08, Julien Grall wrote:
>> On 12/05/2020 08:18, Jan Beulich wrote:
>>> On 11.05.2020 19:14, Ian Jackson wrote:
>>>> Jan Beulich writes ("Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly"):
>>>>> I'm trying to make the point that your patch, to me, looks to be
>>>>> trying to overcome a problem for which we have had a solution all
>>>>> the time.
>>>>
>>>> Thanks for this clear statement of your objection.  I'm afraid I don't
>>>> agree.  Even though .config exists (and is even used by osstest, so I
>>>> know about it) I don't think it is as good as having it in
>>>> menuconfig.
>>>
>>> But you realize that my objection is (was) more towards the reasoning
>>> behind the change, than towards the change itself. If, as a community,
>>> we decide to undo what we might now call a mistake, and if we're ready
>>> to deal with the consequences, so be it.
>>
>> Would you mind to explain the fall out you expect from this patch? Are
>> you worry more people may contact security@xen.org for non-security issue?
> 
> That's one possible thing that might happen. But even more generally
> the likelihood will increase that people report issues without paying
> attention that they depend on their choice of configuration.
I agree that you are going to get more report because there are more 
users to try new things. So inevitently, you will get more incomplete 
report. This is always the downside of allowing more flexibility.

But we also need to look at the upside. I can see 2 advantages:
     1) It will be easier to try upcoming features (e.g Argo). The more 
testing and input, the more chance a feature will be a success.
     2) It will be easier to tailor Xen (such as built-in command line).

In both cases, you make Xen more compelling because you allow to 
experiment and make it more flexible. IHMO, this is one of the best way 
to attract users and possible new contributors/reviewers to Xen community.

>  We'll
> have to both take this into consideration and ask back for the
> specific .config they've used.
Correct me if I am wrong, but this is not very specific to EXPERT mode. 
You can already select different options that will affect the behavior 
of the hypervisor. For instance, on x86, you can disable PV guest 
support. How do you figure that out today without asking the .config?

Cheers,

-- 
Julien Grall


  reply	other threads:[~2020-05-12 11:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 14:25 [PATCH RESEND 0/2] xen: Allow EXPERT mode to be selected from the menuconfig directly Julien Grall
2020-04-30 14:25 ` [PATCH RESEND 1/2] xen/Kconfig: define EXPERT a bool rather than a string Julien Grall
2020-05-07 16:43   ` Dario Faggioli
2020-05-12 11:37   ` Julien Grall
2020-05-12 15:32     ` Stefano Stabellini
2020-04-30 14:25 ` [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly Julien Grall
2020-04-30 14:50   ` Jan Beulich
2020-04-30 15:35     ` Julien Grall
2020-05-04  9:18       ` Jan Beulich
2020-05-04  9:30         ` Julien Grall
2020-05-04  9:37           ` Jan Beulich
2020-05-04  9:54             ` Julien Grall
2020-05-04 10:18               ` Jan Beulich
2020-05-04 10:23                 ` Julien Grall
2020-05-04 11:10     ` George Dunlap
2020-05-04 12:34       ` Ian Jackson
2020-05-06  9:47         ` Julien Grall
2020-05-07 17:01           ` Ian Jackson
2020-05-11 13:30             ` Julien Grall
2020-05-11 13:40               ` Jan Beulich
2020-05-11 13:57                 ` Julien Grall
2020-05-11 14:07                   ` Jan Beulich
2020-05-11 14:11                     ` Julien Grall
2020-05-11 14:14                       ` Jan Beulich
2020-05-11 14:31                         ` Julien Grall
2020-05-11 17:14                         ` Ian Jackson
2020-05-12  7:18                           ` Jan Beulich
2020-05-12 10:08                             ` Julien Grall
2020-05-12 10:15                               ` Jan Beulich
2020-05-12 11:00                                 ` Julien Grall [this message]
2020-05-12 11:03                                   ` Jan Beulich
2020-05-12 11:05                                     ` George Dunlap
2020-05-12 11:18                                       ` Jan Beulich
2020-05-11 14:27                       ` George Dunlap
2020-05-11 15:27               ` George Dunlap
2020-05-11 15:29                 ` Julien Grall
2020-05-11 17:12                   ` Ian Jackson
2020-05-06  9:46       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71e63752-b6b0-9578-e79a-0bef30a7c50a@xen.org \
    --to=julien@xen.org \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=George.Dunlap@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgrall@amazon.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.