From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43561C433F5 for ; Thu, 25 Nov 2021 17:13:42 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.231730.401161 (Exim 4.92) (envelope-from ) id 1mqIJF-0000zs-J3; Thu, 25 Nov 2021 17:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 231730.401161; Thu, 25 Nov 2021 17:13:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mqIJF-0000zl-Fq; Thu, 25 Nov 2021 17:13:21 +0000 Received: by outflank-mailman (input) for mailman id 231730; Thu, 25 Nov 2021 17:13:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mqIJE-0000zf-7X for xen-devel@lists.xenproject.org; Thu, 25 Nov 2021 17:13:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mqIJB-00082E-3E; Thu, 25 Nov 2021 17:13:17 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.27.59]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mqIJA-0002ez-Sa; Thu, 25 Nov 2021 17:13:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5OUwl+L333Vh3BdKaTFrNgus+IbftCeV48wUwglZ5EM=; b=FnzFzkjiRo1JjM2KNEpQ02f/OP dsKKeQfTw+IqtOWEPJ1ZTlGoXBzFINYRZmbL3BiTDHNYmWS19XGntZ4esZi9UrzdXZNRiurWaIf2S 3zYlVsubOE3FO4U7/Ll0I0Q4yMN4I5Pri/8YdTw2zcUAikmJ/BntsZJBoLlzfI3uN398=; Message-ID: <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org> Date: Thu, 25 Nov 2021 17:13:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com> <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com> From: Julien Grall In-Reply-To: <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 25/11/2021 17:03, Jan Beulich wrote: > On 25.11.2021 17:54, Julien Grall wrote: >> On 25/11/2021 16:49, Julien Grall wrote: >>> On 19/11/2021 10:21, Jan Beulich wrote: >>>> From: Lasse Collin >>>> >>>> It's good style. I was also told that GCC 7 is more strict and might >>>> give a warning when such comments are missing. >>>> >>>> Suggested-by: Andrei Borzenkov >>>> Signed-off-by: Lasse Collin >> >> Actually, any reason why there are some signed-off-by missing? > > I often keep the author's, but drop ones which clearly got there only > because of the path a patch has taken through trees. This might be clear for you. For me, as a reviewer, I have to do extra work to check whether you keeped the relevant signed-off-by. > These aren't > relevant imo when pulling over the change; They are technically part of the "chain of approval". > I could as well take the > email submission as my basis, after all, where just the single S-o-b > would be there. That's a fair point. That said, you took the commit-as-is from linus.git so I think we ought to keep them. Cheers, -- Julien Grall