From: Philippe CORNU <philippe.cornu@st.com>
To: Sean Paul <seanpaul@chromium.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/panel: panasonic-vvx10f034n00: More return value fixes
Date: Thu, 18 Jan 2018 10:48:52 +0000 [thread overview]
Message-ID: <71fbb5d3-4aaf-77c7-af82-408ff1ded6dc@st.com> (raw)
In-Reply-To: <20180117213751.54668-1-seanpaul@chromium.org>
Hi Sean,
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
(do you mean you write patches during meetings :o ... I never did that
and I will not ;-)
Philippe :-)
On 01/17/2018 10:37 PM, Sean Paul wrote:
> A couple more return value fixes which Philippe brought up during our
> previous review.
>
> Suggested-by: Philippe CORNU <philippe.cornu@st.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> index 91dc5a6b14f9..74a806121f80 100644
> --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> @@ -59,35 +59,28 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)
>
> static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt)
> {
> - struct mipi_dsi_device *dsi = wuxga_nt->dsi;
> - int ret;
> -
> - ret = mipi_dsi_turn_on_peripheral(dsi);
> - if (ret < 0)
> - return ret;
> -
> - return 0;
> + return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi);
> }
>
> static int wuxga_nt_panel_disable(struct drm_panel *panel)
> {
> struct wuxga_nt_panel *wuxga_nt = to_wuxga_nt_panel(panel);
> - int ret;
> + int mipi_ret, bl_ret = 0;
>
> if (!wuxga_nt->enabled)
> return 0;
>
> - ret = mipi_dsi_shutdown_peripheral(wuxga_nt->dsi);
> + mipi_ret = mipi_dsi_shutdown_peripheral(wuxga_nt->dsi);
>
> if (wuxga_nt->backlight) {
> wuxga_nt->backlight->props.power = FB_BLANK_POWERDOWN;
> wuxga_nt->backlight->props.state |= BL_CORE_FBBLANK;
> - backlight_update_status(wuxga_nt->backlight);
> + bl_ret = backlight_update_status(wuxga_nt->backlight);
> }
>
> wuxga_nt->enabled = false;
>
> - return ret;
> + return mipi_ret ? mipi_ret : bl_ret;
> }
>
> static int wuxga_nt_panel_unprepare(struct drm_panel *panel)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-18 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:37 [PATCH] drm/panel: panasonic-vvx10f034n00: More return value fixes Sean Paul
2018-01-18 10:48 ` Philippe CORNU [this message]
2018-01-22 17:52 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71fbb5d3-4aaf-77c7-af82-408ff1ded6dc@st.com \
--to=philippe.cornu@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.