All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Rybak <rybak.a.v@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] rerere: enable by default
Date: Mon, 7 Jun 2021 12:34:07 +0200	[thread overview]
Message-ID: <720154c0-eedb-db92-1b61-1df2e22fb128@gmail.com> (raw)
In-Reply-To: <xmqqfsxvxjj2.fsf@gitster.g>

On 06/06/2021 14:30, Junio C Hamano wrote:
> By default, the rerere machinery has been disabled since a bug in
> the machinery could screw up the end user's data at the most
> stressful time during the end user's workday (i.e. during conflict
> resolution).
> 
> It however has been in wide use without causing much trouble (other
> than, obviously, replaying a broken conflict resolution that was
> recorded earlier when the user made a mismerge), and it is about
> time to enable it by default.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>   Documentation/config/rerere.txt |  5 ++---
>   rerere.c                        | 12 +++---------
>   t/t2030-unresolve-info.sh       |  3 +++
>   3 files changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/config/rerere.txt b/Documentation/config/rerere.txt
> index 40abdf6a6b..45e97fc0fa 100644
> --- a/Documentation/config/rerere.txt
> +++ b/Documentation/config/rerere.txt
> @@ -7,6 +7,5 @@ rerere.enabled::
>   	Activate recording of resolved conflicts, so that identical
>   	conflict hunks can be resolved automatically, should they be
>   	encountered again.  By default, linkgit:git-rerere[1] is
> -	enabled if there is an `rr-cache` directory under the
> -	`$GIT_DIR`, e.g. if "rerere" was previously used in the
> -	repository.
> +	enabled, but this configuration can be set to 'false' to

At the moment, backticks are used more often than single quotes
for formatting of boolean values in documentation:

     $ git grep -oE "\`(false|true)\`" -- Documentation/*.txt Documentation/config/*.txt | wc -l
     121
     $ git grep -oE "'(false|true)'" -- Documentation/*.txt Documentation/config/*.txt | wc -l
     53

> +	turn it off.

  parent reply	other threads:[~2021-06-07 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 12:30 [PATCH] rerere: enable by default Junio C Hamano
2021-06-07  0:56 ` brian m. carlson
2021-06-07  9:51   ` Junio C Hamano
2021-06-07  9:50 ` Ævar Arnfjörð Bjarmason
2021-06-07 11:05   ` Junio C Hamano
2021-06-07 12:56     ` Ævar Arnfjörð Bjarmason
2021-06-07 10:34 ` Andrei Rybak [this message]
2021-06-07 16:41 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=720154c0-eedb-db92-1b61-1df2e22fb128@gmail.com \
    --to=rybak.a.v@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.