From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXscI-0005sN-Dk for qemu-devel@nongnu.org; Tue, 26 Jun 2018 14:23:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXscH-0003EY-Jy for qemu-devel@nongnu.org; Tue, 26 Jun 2018 14:23:02 -0400 References: <20180626135035.133432-1-vsementsov@virtuozzo.com> From: John Snow Message-ID: <720156db-7910-2825-5485-6ce328a68ba3@redhat.com> Date: Tue, 26 Jun 2018 14:22:53 -0400 MIME-Version: 1.0 In-Reply-To: <20180626135035.133432-1-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] fix persistent bitmaps migration logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: dgilbert@redhat.com, quintela@redhat.com, stefanha@redhat.com, famz@redhat.com, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > To continue talk about correct loading of persistent bitmaps here is > a patch (04), with some surrounding. > > Patch 04 contains new (and I hope, more clean) logic of bitmaps > loading/inactivation/invalidation/migration, with the whole description. > Let me not duplicate it here, you can safely start reading from 04 > commit message and internal big comment. > > Vladimir Sementsov-Ogievskiy (6): > iotests: 169: drop deprecated 'autoload' parameter > block/qcow2: improve error message in qcow2_inactivate > bloc/qcow2: drop dirty_bitmaps_loaded state variable > dirty-bitmaps: clean-up bitmaps loading and migration logic > iotests: improve 169 > iotests: 169: add cases for source vm resuming > > block/qcow2.h | 1 - > include/block/dirty-bitmap.h | 2 +- > block.c | 11 ++++-- > block/dirty-bitmap.c | 36 +++++++----------- > block/qcow2-bitmap.c | 16 ++++++++ > block/qcow2.c | 86 ++++++++++++++++++++++++++++++++---------- > migration/block-dirty-bitmap.c | 10 ++++- > tests/qemu-iotests/169 | 70 +++++++++++++++++++++++++++++++++- > tests/qemu-iotests/169.out | 4 +- > 9 files changed, 182 insertions(+), 54 deletions(-) > Does this effectively supersede "[PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded"? (I'll review it in just a moment, regardless, but I'm trying to keep my notes tidy.) --js