All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Norbert Lange <nolange79@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot <buildroot@buildroot.org>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/systemd: Allow extra config options
Date: Mon, 10 Jan 2022 08:26:00 +0100	[thread overview]
Message-ID: <7229983a-cbde-eb3f-83cb-984544f3b355@mind.be> (raw)
In-Reply-To: <CADYdroMDCcUYSj6XyrXUHi4hwDWjtTXNX7BOmLt-Eb3JK_3fQQ@mail.gmail.com>



On 09/01/2022 23:52, Norbert Lange wrote:
> Not only missing, but I sometimes need a *different* config. For example i don't 
> want to link against lz4, since I use zstd instead.

  Which is a great example of why the option doesn't work: it would affect 
dependencies as well.

  However, specifically for this one, we have in the .mk file:

ifeq ($(BR2_PACKAGE_ZSTD),y)
SYSTEMD_DEPENDENCIES += zstd
SYSTEMD_CONF_OPTS += -Dzstd=true
else
SYSTEMD_CONF_OPTS += -Dzstd=false
endif

ifeq ($(BR2_PACKAGE_LZ4),y)
SYSTEMD_DEPENDENCIES += lz4
SYSTEMD_CONF_OPTS += -Dlz4=true
else
SYSTEMD_CONF_OPTS += -Dlz4=false
endif

So it should already do what you need, no?

  Regards,
  Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-10  7:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 15:28 [Buildroot] [PATCH 1/1] package/systemd: Allow extra config options Norbert Lange
2022-01-08 11:04 ` Romain Naour
2022-01-08 14:23   ` Arnout Vandecappelle
2022-01-08 14:36   ` Norbert Lange
2022-01-08 19:04 ` James Hilliard
2022-01-08 21:31   ` Norbert Lange
2022-01-08 22:37     ` Arnout Vandecappelle
2022-01-09 22:40     ` James Hilliard
2022-01-09 22:52       ` Norbert Lange
2022-01-10  7:26         ` Arnout Vandecappelle [this message]
2022-01-10  8:28           ` Norbert Lange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7229983a-cbde-eb3f-83cb-984544f3b355@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=maxime.hadjinlian@gmail.com \
    --cc=nolange79@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.