All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] clocksource/drivers: Add Realtek Otto timer driver
Date: Mon, 17 Jan 2022 09:03:02 +0100	[thread overview]
Message-ID: <722bbfb582ab948fd994de880e4fa98c49f8bece.camel@svanheule.net> (raw)
In-Reply-To: <202201170911.q3u7GptA-lkp@intel.com>

On Mon, 2022-01-17 at 09:28 +0800, kernel test robot wrote:
>    drivers/clocksource/timer-realtek-otto.c: In function 'otto_tc_init':
>    drivers/clocksource/timer-realtek-otto.c:182:16: error: implicit
> declaration of function 'kzalloc'; did you mean 'd_alloc'? [-Werror=implicit-
> function-declaration]
>      182 |         ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
>          |                ^~~~~~~
>          |                d_alloc
> > > drivers/clocksource/timer-realtek-otto.c:182:14: warning: assignment to
> > > 'struct otto_tc_ctrl *' from 'int' makes pointer from integer without a
> > > cast [-Wint-conversion]
>      182 |         ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
>          |              ^
>    drivers/clocksource/timer-realtek-otto.c:212:9: error: implicit declaration
> of function 'kfree' [-Werror=implicit-function-declaration]
>      212 |         kfree(ctrl);
>          |         ^~~~~
>    cc1: some warnings being treated as errors
> 
> 
> vim +182 drivers/clocksource/timer-realtek-otto.c
> 
>    176  
>    177  static int __init otto_tc_init(struct device_node *node)
>    178  {
>    179          struct otto_tc_ctrl *ctrl;
>    180          int err;
>    181  
>  > 182          ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);

I'll include linux/slab.h in v2.

Best,
Sander

WARNING: multiple messages have this Message-ID (diff)
From: Sander Vanheule <sander@svanheule.net>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/2] clocksource/drivers: Add Realtek Otto timer driver
Date: Mon, 17 Jan 2022 09:03:02 +0100	[thread overview]
Message-ID: <722bbfb582ab948fd994de880e4fa98c49f8bece.camel@svanheule.net> (raw)
In-Reply-To: <202201170911.q3u7GptA-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

On Mon, 2022-01-17 at 09:28 +0800, kernel test robot wrote:
>    drivers/clocksource/timer-realtek-otto.c: In function 'otto_tc_init':
>    drivers/clocksource/timer-realtek-otto.c:182:16: error: implicit
> declaration of function 'kzalloc'; did you mean 'd_alloc'? [-Werror=implicit-
> function-declaration]
>      182 |         ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
>          |                ^~~~~~~
>          |                d_alloc
> > > drivers/clocksource/timer-realtek-otto.c:182:14: warning: assignment to
> > > 'struct otto_tc_ctrl *' from 'int' makes pointer from integer without a
> > > cast [-Wint-conversion]
>      182 |         ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);
>          |              ^
>    drivers/clocksource/timer-realtek-otto.c:212:9: error: implicit declaration
> of function 'kfree' [-Werror=implicit-function-declaration]
>      212 |         kfree(ctrl);
>          |         ^~~~~
>    cc1: some warnings being treated as errors
> 
> 
> vim +182 drivers/clocksource/timer-realtek-otto.c
> 
>    176  
>    177  static int __init otto_tc_init(struct device_node *node)
>    178  {
>    179          struct otto_tc_ctrl *ctrl;
>    180          int err;
>    181  
>  > 182          ctrl = kzalloc(sizeof(*ctrl), GFP_KERNEL);

I'll include linux/slab.h in v2.

Best,
Sander

  reply	other threads:[~2022-01-17  8:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-16 21:39 [PATCH 0/2] Realtek Otto timer/counter support Sander Vanheule
2022-01-16 21:39 ` [PATCH 1/2] dt-bindings: timer: Add realtek,otto-tc binding Sander Vanheule
2022-02-09  2:49   ` Rob Herring
2022-02-09 10:58     ` Sander Vanheule
2022-01-16 21:39 ` [PATCH 2/2] clocksource/drivers: Add Realtek Otto timer driver Sander Vanheule
2022-01-17  1:28   ` kernel test robot
2022-01-17  1:28     ` kernel test robot
2022-01-17  8:03     ` Sander Vanheule [this message]
2022-01-17  8:03       ` Sander Vanheule
2022-01-17  7:38   ` kernel test robot
2022-01-17  7:38     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=722bbfb582ab948fd994de880e4fa98c49f8bece.camel@svanheule.net \
    --to=sander@svanheule.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.