From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0201C4338F for ; Tue, 24 Aug 2021 10:23:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BB426127B for ; Tue, 24 Aug 2021 10:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BB426127B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mITb0-0006Gp-Pa for qemu-devel@archiver.kernel.org; Tue, 24 Aug 2021 06:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mITZx-0004PW-Kq; Tue, 24 Aug 2021 06:22:50 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:35625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mITZw-0001So-3x; Tue, 24 Aug 2021 06:22:49 -0400 Received: by mail-wr1-x433.google.com with SMTP id i6so6750313wrv.2; Tue, 24 Aug 2021 03:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p2UX9W5MONyIpO+iTH3a+HC08jNHyBB2IVRC0AfcjBM=; b=BdGfAePAf3DMKxhSUnrOWAwvMfANUF16hVC9TIRL5onFpX6kTtBUs5BFx55adabxAm cIjQctaClAeVkgUn99I0A8RXtHih1x4BP8/cjUPBYMi1V3hrv87urhLi3Ibsnpv8n1mf QH4jcxABZqvlB9v0ZOdHkavsc3WYZ9wMZHq1Nbivi8xPiMe8d39nbihk0oQW/BHXZBAY F8+LgNWBOA2U6ATqS9idBHIt0b7R9z0pmSfBCBrw0G8ivsZjLKO9Dq3qe5CXwjDQTmXG WmfaAZB8Km3rMQFH3l9SwKaf/9yM0M92fqUmfUo18xP9NNq6xXwaJn4qghgpUB6qPoZ9 jiDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p2UX9W5MONyIpO+iTH3a+HC08jNHyBB2IVRC0AfcjBM=; b=UKVf0RDvbzMbL2kcxbh7sIMaSy5AX1ephSMPzASaoldBccBcJrtwHbbkkOD7CGMxw6 U8GF2GIit4qWPE/JT9bzsm8G5IWB0IAvpdwkxuHbbDsj1I4G/1dZx4NeKyuet1OR/N3S GcDUXKTj9DdHqB6mFWIyuTIN0pw9alMfQUAkc3KU9RdlVw1f/XOorpBiGJKMO/WqyNml 0Yz9CduYU3OKPbH2bPP/wpN4yrzFyMjOTZ99I2yiL1wDyeeV6n5yp6jT3oZAye+V/6co icFgLZJn9ULq93i27ve5VusIocLQrnkylFXeBQGl6TXtITV3dJcrNyNz844+hqaL/O2M U5TQ== X-Gm-Message-State: AOAM530fF5SKDloiPiAsmVN6yALqlIOmyPCRQ7wuPe8/4aNacHrvtR6k jO+b8c8bdJcOl1JTeQa+K6OkrFmUX4o= X-Google-Smtp-Source: ABdhPJxDdb/s3COeaYlciQcK0L9EDnVspGYpVPJCqQ4HervuDHLNCzTklfI0bWkRId2d2iNmrbE1ZA== X-Received: by 2002:adf:dcc7:: with SMTP id x7mr18706608wrm.173.1629800565650; Tue, 24 Aug 2021 03:22:45 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id a133sm1889684wme.5.2021.08.24.03.22.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Aug 2021 03:22:45 -0700 (PDT) Subject: Re: [RFC 08/10] hw/mos6522: Call mos6522_update_irq() when appropriate To: Finn Thain , Mark Cave-Ayland , David Gibson , Greg Kurz References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <72321786-8179-da83-2d50-e60ba781163e@amsat.org> Date: Tue, 24 Aug 2021 12:22:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.023, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Laurent Vivier , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/24/21 12:09 PM, Finn Thain wrote: > It necessary to call mos6522_update_irq() when the interrupt flags > change and unnecessary when they haven't. > > Signed-off-by: Finn Thain > --- > hw/misc/mos6522.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé