From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4052BC43465 for ; Mon, 21 Sep 2020 15:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD5E42085B for ; Mon, 21 Sep 2020 15:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LXGbD7AT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727989AbgIUPac (ORCPT ); Mon, 21 Sep 2020 11:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbgIUPac (ORCPT ); Mon, 21 Sep 2020 11:30:32 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B9BC061755 for ; Mon, 21 Sep 2020 08:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=1koMiRQbFFf0p9r9d0UTi54c7bEUA3DdvcMtOF4qjUg=; b=LXGbD7ATyDxuyUP7lUEf0o1j6p 0RX3/QtQREPDsj4JG5mphPxND8eR5gR5C+P42PjS1v5VZklJWR/xj0+SiZxPSAWx2uZow1dMsFmc4 bloGVlIXnb/umUBNc5CL7eRPgekfV2Jxav0FBVNx/lUhbxKYBKC3XaVhosOoZZWwRopMsckGL3Cws l4MDHmF5P+cJ+yj7UJrKE71GAQ0h88GI/iWi7ghq9bY002eVC2SSB9ImtHx4cjEpZQJG1PgnNu8IW YrYBEXb96xzb6bMM+2z8p5eVrZk1D3TapZrUpKeMSMYFffbHL2wveIFfJGkLmiu/CAcLG5hxvbyf3 wJXcu/pg==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNlt-0008U3-3m; Mon, 21 Sep 2020 15:30:29 +0000 Subject: Re: [PATCH v2 02/32] auxdisplay: Introduce hd44780_common.[ch] To: poeschel@lemonage.de, Miguel Ojeda Sandonis , Willy Tarreau , Ksenija Stanojevic , open list References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> <20200921144645.2061313-3-poeschel@lemonage.de> From: Randy Dunlap Message-ID: <7239765f-bcbe-2149-e38a-bd03e33a7099@infradead.org> Date: Mon, 21 Sep 2020 08:30:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200921144645.2061313-3-poeschel@lemonage.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 9/21/20 7:46 AM, poeschel@lemonage.de wrote: > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 81757eeded68..153fa426ae7d 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -14,12 +14,31 @@ menuconfig AUXDISPLAY > > If you say N, all options in this submenu will be skipped and disabled. > > +config CHARLCD > + tristate "Character LCD core support" if COMPILE_TEST > + help > + This is the base system for character based lcd displays. character-based LCD > + It makes no sense to have this alone, you select your display driver > + and if it needs the charlcd core, it will select it automatically. > + This is some character lcd core interface that multiple drivers can LCD > + use. > + > +config HD44780_COMMON > + tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST > + help > + This is a module with the common symbols for HD44780 (and compatibles) > + displays. This is the code that multiple other modules use. It is not > + useful alone. If you have some sort of HD44780 compatible display, > + you very likely use this. It is selected automatically by selecting > + your concrete display. thanks. -- ~Randy