From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1bvWqk-0004Km-Tb
	for qemu-devel@nongnu.org; Sat, 15 Oct 2016 17:50:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1bvWqf-0006eL-Tf
	for qemu-devel@nongnu.org; Sat, 15 Oct 2016 17:50:38 -0400
Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:35726
	helo=mail.comstyle.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <brad@comstyle.com>) id 1bvWqU-0004GK-BR
	for qemu-devel@nongnu.org; Sat, 15 Oct 2016 17:50:33 -0400
References: <20161007012832.nfv2ctxri3z76pnp@humpty.home.comstyle.com>
From: Brad Smith <brad@comstyle.com>
Message-ID: <723b0ca2-c950-bc31-3c6c-98fa47adfee4@comstyle.com>
Date: Sat, 15 Oct 2016 17:44:41 -0400
MIME-Version: 1.0
In-Reply-To: <20161007012832.nfv2ctxri3z76pnp@humpty.home.comstyle.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] tap-bsd: OpenBSD uses tap(4) now
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, jasowang@redhat.com

On 10/06/16 21:28, Brad Smith wrote:
> Update the tap-bsd code now that OpenBSD uses tap(4).
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
> v2: Allow the code to deal with newer vs older OpenBSD releases

ping.

> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index c506ac3..6c96922 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -35,6 +35,10 @@
>  #include <net/if_tap.h>
>  #endif
>
> +#if defined(__OpenBSD__)
> +#include <sys/param.h>
> +#endif
> +
>  #ifndef __FreeBSD__
>  int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
>               int vnet_hdr_required, int mq_required, Error **errp)
> @@ -55,7 +59,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
>          if (*ifname) {
>              snprintf(dname, sizeof dname, "/dev/%s", ifname);
>          } else {
> -#if defined(__OpenBSD__)
> +#if defined(__OpenBSD__) && OpenBSD < 201605
>              snprintf(dname, sizeof dname, "/dev/tun%d", i);
>  #else
>              snprintf(dname, sizeof dname, "/dev/tap%d", i);
>