All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: bitbake-devel@lists.openembedded.org
Subject: [PATCH 1/6] fetch2/npm: explicitly specify workdir
Date: Tue,  6 Sep 2016 10:57:28 +1200	[thread overview]
Message-ID: <723d0da75410eb692f123a1b5835e367a408fcb8.1473116117.git.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <cover.1473116117.git.paul.eggleton@linux.intel.com>
In-Reply-To: <cover.1473116117.git.paul.eggleton@linux.intel.com>

We were downloading into the current directory here, which is fine if
that current directory can be expected to be the right place - but
that's not true when called from recipetool within OE. We should
explicitly specify the directory to run the command in and then there
won't be a problem.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 lib/bb/fetch2/npm.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/bb/fetch2/npm.py b/lib/bb/fetch2/npm.py
index b26ac22..65ccb0d 100644
--- a/lib/bb/fetch2/npm.py
+++ b/lib/bb/fetch2/npm.py
@@ -102,7 +102,8 @@ class Npm(FetchMethod):
     def _runwget(self, ud, d, command, quiet):
         logger.debug(2, "Fetching %s using command '%s'" % (ud.url, command))
         bb.fetch2.check_network_access(d, command)
-        runfetchcmd(command, d, quiet)
+        dldir = d.getVar("DL_DIR", True)
+        runfetchcmd(command, d, quiet, workdir=dldir)
 
     def _unpackdep(self, ud, pkg, data, destdir, dldir, d):
         file = data[pkg]['tgz']
-- 
2.5.5



  reply	other threads:[~2016-09-05 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 22:57 [PATCH 0/6] npm fetcher fixes Paul Eggleton
2016-09-05 22:57 ` Paul Eggleton [this message]
2016-09-05 22:57 ` [PATCH 2/6] fetch2/npm: fix broken fetches if more than one npm URL fetched Paul Eggleton
2016-09-05 22:57 ` [PATCH 3/6] fetch2/npm: support subdir= parameter Paul Eggleton
2016-09-05 22:57 ` [PATCH 4/6] fetch2/npm: handle top-level shrinkwrap file Paul Eggleton
2016-09-05 22:57 ` [PATCH 5/6] fetch2/npm: clarify comment Paul Eggleton
2016-09-05 22:57 ` [PATCH 6/6] lib/bb/utils: edit_metadata() comment tweaks Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=723d0da75410eb692f123a1b5835e367a408fcb8.1473116117.git.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.